From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id CItjIv8f6l+wUgAA0tVLHw (envelope-from ) for ; Mon, 28 Dec 2020 18:12:15 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id OJg5Hv8f6l+dIwAAB5/wlQ (envelope-from ) for ; Mon, 28 Dec 2020 18:12:15 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4B4709403CD for ; Mon, 28 Dec 2020 18:12:15 +0000 (UTC) Received: from localhost ([::1]:37386 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ktx09-0002MP-UF for larch@yhetil.org; Mon, 28 Dec 2020 13:12:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58046) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ktwzy-0002GJ-8B for guix-patches@gnu.org; Mon, 28 Dec 2020 13:12:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:53488) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ktwzy-0006JY-0w for guix-patches@gnu.org; Mon, 28 Dec 2020 13:12:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ktwzx-00007R-Ri for guix-patches@gnu.org; Mon, 28 Dec 2020 13:12:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#45498] [PATCH 00/12] Add ocaml-merlin. Resent-From: pukkamustard Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 28 Dec 2020 18:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45498 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Julien Lepiller Received: via spool by 45498-submit@debbugs.gnu.org id=B45498.1609179070392 (code B ref 45498); Mon, 28 Dec 2020 18:12:01 +0000 Received: (at 45498) by debbugs.gnu.org; 28 Dec 2020 18:11:10 +0000 Received: from localhost ([127.0.0.1]:36801 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ktwz4-00006B-2E for submit@debbugs.gnu.org; Mon, 28 Dec 2020 13:11:09 -0500 Received: from mout01.posteo.de ([185.67.36.65]:41900) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ktwyy-00005d-UK for 45498@debbugs.gnu.org; Mon, 28 Dec 2020 13:11:04 -0500 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 41A74160061 for <45498@debbugs.gnu.org>; Mon, 28 Dec 2020 19:10:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1609179054; bh=qNqqH7sP9GOVRkGFhi/HFpvdypkO3ojoCpIRPtCG5do=; h=From:To:Cc:Subject:Date:From; b=DHSp+d4qSeSUVzbIMZoBhI/8qsJN8XGHaCrTw+0ftcq1+TT9ENLliLG+J+LahPMhu jJ6jHxV/2jmKhUMmLYZ0EkRETxlNkECJhwsEvIYtsnt+z5+Pc6znl7omFnc2br1t0m Eqke830/V7dAaHjCh7jkt2D1+T0sPxThKWqdDLDIvit9JgeZm2L6Xg0M8djCAz+YwJ TKZ7KMPkYme9p7HUnTr11SXzY2hY5KH37yqqXwjsmFul9D+ERpO0ynhjX484jyCZfz puW3/4Ex7Qg14mrcQtHpxK7b0h44j/nKx1pY4L6cFa25fGaUWK6yhfK/5MIJKm9z1v BJwPQiRKqCf2A== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4D4Qb14tjZz6tmK; Mon, 28 Dec 2020 19:10:53 +0100 (CET) References: <20201228124017.24295-1-pukkamustard@posteo.net> <20201228150655.101e4704@tachikoma.lepiller.eu> User-agent: mu4e 1.4.13; emacs 27.1 From: pukkamustard In-reply-to: <20201228150655.101e4704@tachikoma.lepiller.eu> Date: Mon, 28 Dec 2020 19:10:48 +0100 Message-ID: <86pn2tn6mv.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 45498@debbugs.gnu.org Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -1.22 Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=posteo.net header.s=2017 header.b=DHSp+d4q; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 4B4709403CD X-Spam-Score: -1.22 X-Migadu-Scanner: scn0.migadu.com X-TUID: Gwh02xX7SGjb Thank you for the feedback! v2 of patch series coming shortly... I was not aware of the `ocaml4.07-variant` property. It makes things a lot nicer! I've added it for `ocaml-markup` and `ocaml-odoc` and also `ocaml-sexplib0`, `ocaml-parsexp`, `ocaml-base` and `ocaml-sexplib`. This makes `ocaml4.07-*` vanish from lot of places in favor of `(package-with-ocaml4.07 *)`. > Have you tried updating dune to the latest version that builds > with > ocaml 4.07? Not yet. For ocaml-markup 1.0.0 the problem is that the dune file version is set to 2.7. Any dune below 2.7.x will probably not work. For other packages it might work... > >> >> This is quite cumbersome as two trees of OCaml packages need >> to be >> maintained. > > Actually 3, there are ocaml 4.07, 4.09 and 4.11 currently. I'm > working > on a bootstrap for ocaml 4.07 (ocaml builds from a binary > version of > itself), so I don't think it'll disappear soon, but at least we > can try > and make ocaml4.07-* packages disappear :) > \o/ Looking forward to the bootstrap! With the `ocaml4.*-variant` property managing the 3 trees does not seem so bad after all. Currently there are a lot of packages only for 4.07. It would be nicer to have packages for default compiler and when needed variants for older compilers. I plan to do some OCaml hacking in the next months and will send in patches toward this, if that is ok. >> - Some OCaml libraries have dependencies in `inputs` that seem >> to be >> required from packages using the libraries. E.g. >> `ocaml-yojson` >> depends on `ocaml-biniou`. Packages depending on `ocaml-yojson` >> need >> to manually add `ocaml-biniou` to their inputs. Would it >> work/make >> sense to add `ocaml-biniou` to `propagated-inputs` of >> `ocaml-yojson`? > > Yeah, could you provide an additional patch for that? Done. Patch 13 in v2. -pukkamustard