From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id CDI5KArP+GBzngAAgWs5BA (envelope-from ) for ; Thu, 22 Jul 2021 03:51:06 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id eBrHIwrP+GC+bQAAbx9fmQ (envelope-from ) for ; Thu, 22 Jul 2021 01:51:06 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5C21E9655 for ; Thu, 22 Jul 2021 03:51:06 +0200 (CEST) Received: from localhost ([::1]:43374 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m6Nrd-0002ra-Da for larch@yhetil.org; Wed, 21 Jul 2021 21:51:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40196) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m6Nra-0002rN-05 for guix-patches@gnu.org; Wed, 21 Jul 2021 21:51:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:55772) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m6NrZ-0007yI-PO for guix-patches@gnu.org; Wed, 21 Jul 2021 21:51:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m6NrZ-0007am-PV for guix-patches@gnu.org; Wed, 21 Jul 2021 21:51:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49578] [PATCH] Add bolt Resent-From: Sarah Morgensen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 22 Jul 2021 01:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49578 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: phodina Cc: 49578@debbugs.gnu.org Received: via spool by 49578-submit@debbugs.gnu.org id=B49578.162691865329167 (code B ref 49578); Thu, 22 Jul 2021 01:51:01 +0000 Received: (at 49578) by debbugs.gnu.org; 22 Jul 2021 01:50:53 +0000 Received: from localhost ([127.0.0.1]:39085 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6NrQ-0007aN-QB for submit@debbugs.gnu.org; Wed, 21 Jul 2021 21:50:53 -0400 Received: from out2.migadu.com ([188.165.223.204]:35944) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6NrO-0007aD-5w for 49578@debbugs.gnu.org; Wed, 21 Jul 2021 21:50:51 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1626918647; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=V+6l2A+/xzk7nIF19fPwY8V5Tkd9pXf/d6rJd2habXI=; b=JHyEOujFNhovZ7r0k8XcRmWC/Lh/AfOP6liueYmle1duG7mtP3xlsh4KKHJnD5u1gC26zk 2g2jxnwRnRpqj9t1hdRjc+w33GjpNJ8VD8RE4Gc/YmrNii59E1E3vjlY2f8ElECyspbV7i C8H/RsT9LcE/VOSNXvPDpNueC004qpU= From: Sarah Morgensen References: Date: Wed, 21 Jul 2021 18:50:45 -0700 In-Reply-To: (phodina@protonmail.com's message of "Thu, 15 Jul 2021 16:46:01 +0000") Message-ID: <86o8avrua2.fsf@mgsn.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Migadu-Auth-User: iskarian@mgsn.dev X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1626918666; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=V+6l2A+/xzk7nIF19fPwY8V5Tkd9pXf/d6rJd2habXI=; b=WFyGGEzTU6syPEo2obvzkj41YWw5dnr6P3H4VvGCbzv3NHr3WugoCuqeU+7V7JHWblanbD FO8s9KLaS+JYLEaSGh2LX6txDJKdsU5fBxCrhsBXImraoyc0w8a+aEPoAMcuVvO0loTNQ9 8SxMqWZQyy60SqjggRrNJvRFutdMB88FTwdYEq/MSicgVkFQ6ABBkXDuYhv0rL2PzKlfES /kuI1wto/478oZl8lbS7MpuZGQWB+xF6emnPRNNel+2lzzFXuseKQN2NDOdIi2snYZs/U5 gK8W3/RVtJaTsT82N0GstG+x5fPD7xp+3L/p4logeNdob8mhKV0WEcW/N5oCIw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1626918666; a=rsa-sha256; cv=none; b=rWJZFLhI/ZxUsy/SH5fuD4AGLRdijmSEsTXmCPwFTc4a+XrykpoX3JLV8b+tRamA+uheWe WLYbMFg5JziZ7xfbwqfNXcxEEvYAahWSkkvhwDkyItis0pLc2Ga5J7nzKFBzXcgHRKB8HI usWWq9snW5sdO5KvasqjAO/TinXVrQQC3vThZaXTkgexEy6frBnti9CgveGdxXXk+n2HzY VwHIHDDXyLLvKnaGDduo64eLzlCvZAKtFsBeJ8VC5EhyxDc7Yrf1No5dfzurmveRIBeaO8 p/1fuvrJ5/WZXcFFsbCy6c/BgT5xDzJPP7wkXXx3bRkL7klSm5lQTuTN5O7zQg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=mgsn.dev header.s=key1 header.b=JHyEOujF; dmarc=fail reason="SPF not aligned (relaxed)" header.from=mgsn.dev (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.31 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=mgsn.dev header.s=key1 header.b=JHyEOujF; dmarc=fail reason="SPF not aligned (relaxed)" header.from=mgsn.dev (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 5C21E9655 X-Spam-Score: -1.31 X-Migadu-Scanner: scn0.migadu.com X-TUID: XbEtqnoF9MVR Hello, Thanks for the patch. It's always good to see new contributors around here! I have a few suggestions for your patch. phodina writes: > --- > index 4b57bc1f24..d07ee33a7e 100644 > --- a/gnu/packages/linux.scm > +++ b/gnu/packages/linux.scm > @@ -123,6 +123,7 @@ > #:use-module (gnu packages pulseaudio) > #:use-module (gnu packages python) > #:use-module (gnu packages python-xyz) > + #:use-module (gnu packages polkit) > #:use-module (gnu packages readline) > #:use-module (gnu packages rrdtool) > #:use-module (gnu packages samba) > @@ -2479,6 +2480,52 @@ IPv6 packet filter. > Both commands are targeted at system administrators.") > (license license:gpl2+))) > > +(define-public bolt > + (package > + (name "bolt") > + (version "0.9.1") > + (source (origin > + (method git-fetch) > + (uri > + (git-reference > + (url "https://gitlab.freedesktop.org/bolt/bolt") > + (commit version))) > + (sha256 > + (base32 > + "1phgp8fs0dlj74kbkqlvfniwc32daz47b3pvsxlfxqzyrp77xrfm"))= )) > + (build-system meson-build-system) > + (arguments > + `(#:configure-flags (list (string-append "--localstatedir=3D" (asso= c-ref %outputs "out") "/var")) Are you sure this shouldn't be "--localstatedir=3D/var"? As it is, it refers to the read-only directory /gnu/store/...-bolt-0.9.1/var. > + #:phases > + (modify-phases %standard-phases > + (add-after 'unpack 'fix-udev-rules-directory > + (lambda* (#:key outputs #:allow-other-keys) > + (let ((out (assoc-ref outputs "out"))) > + (mkdir-p (string-append out "/lib/udev/rules.d")) ^ I think this is not necessary... > + (substitute* "meson.build" > + (("udev.get_pkgconfig_variable..udevdir..") > + (string-append "'" out "/lib'")))#t))) ...with this change: ^ /lib/udev > + (add-before 'install 'no-polkit-magic > + (lambda* (#:key outputs #:allow-other-keys) > + ;; Meson =E2=80=98magically=E2=80=99 invokes pkexec, which = fails (not setuid). > + (setenv "PKEXEC_UID" "something") > + #t))))) ^ Phases no longer need to end with #t, so you can omit thi= s. > + (native-inputs `(("pkg-config" ,pkg-config) ("dbus" ,dbus) ("asciido= c" ,asciidoc) ("umockdev" ,umockdev))) Please wrap lines at 80 characters, and in the special case of package inputs like here, each input should get its own line, like: (native-inputs `(("pkg-config" ,pkg-config) ("dbus" ,dbus) ("asciidoc" ,asciidoc) ("umockdev" ,umockdev))) > + (inputs `(("glib:bin" ,glib "bin") ("eudev" ,eudev) ("polkit" ,polki= t))) > + (synopsis "Userspace system daemon to enable security levels for Thu= nderbolt=E2=84=A2 > +on GNU/Linux=C2=AE.") > + (description "Thunderbolt=E2=84=A2 is the brand name of a hardware i= nterface developed by > +Intel=C2=AE that allows the connection of external peripherals to a > +computer. > +Devices connected via Thunderbolt can be DMA masters and thus read > +system memory without interference of the operating system (or even > +the CPU). Version 3 of the interface introduced 5 different security > +levels, in order to mitigate the aforementioned security risk that > +connected devices pose to the system. The security level is set by the > +system firmware.") > + (home-page "https://gitlab.freedesktop.org/bolt/bolt") > + (license license:gpl2+))) > + > (define-public jitterentropy-rngd > (package > (name "jitterentropy-rngd") > -- > 2.31.1 -- Sarah