* [bug#44006] [PATCH] doc: Fix typo
@ 2020-10-15 7:47 Aniket Patil
2020-10-15 13:09 ` zimoun
0 siblings, 1 reply; 5+ messages in thread
From: Aniket Patil @ 2020-10-15 7:47 UTC (permalink / raw)
To: 44006
[-- Attachment #1.1: Type: text/plain, Size: 724 bytes --]
*doc/guix.texi (section 7.5): Fix typo
---
doc/guix.texi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/guix.texi b/doc/guix.texi
index ff33735c3a..ce569f6fbf 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -10105,7 +10105,7 @@ package expressions for all those packages that are
not yet in Guix.
When @option{--archive=bioconductor} is added, metadata is imported from
@uref{https://www.bioconductor.org/, Bioconductor}, a repository of R
-packages for for the analysis and comprehension of high-throughput
+packages for the analysis and comprehension of high-throughput
genomic data in bioinformatics.
Information is extracted from the @file{DESCRIPTION} file contained in the
--
2.28.0
[-- Attachment #1.2: Type: text/html, Size: 869 bytes --]
[-- Attachment #2: 0001-doc-Fix-typo.patch --]
[-- Type: text/x-patch, Size: 915 bytes --]
From 886079e699d1de55288aacb84095b65a9ef18927 Mon Sep 17 00:00:00 2001
From: Aniket Patil <aniket112.patil@gmail.com>
Date: Thu, 15 Oct 2020 08:56:43 +0530
Subject: [PATCH] doc: Fix typo
*doc/guix.texi (section 7.5): Fix typo
---
doc/guix.texi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/guix.texi b/doc/guix.texi
index ff33735c3a..ce569f6fbf 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -10105,7 +10105,7 @@ package expressions for all those packages that are not yet in Guix.
When @option{--archive=bioconductor} is added, metadata is imported from
@uref{https://www.bioconductor.org/, Bioconductor}, a repository of R
-packages for for the analysis and comprehension of high-throughput
+packages for the analysis and comprehension of high-throughput
genomic data in bioinformatics.
Information is extracted from the @file{DESCRIPTION} file contained in the
--
2.28.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [bug#44006] [PATCH] doc: Fix typo
2020-10-15 7:47 [bug#44006] [PATCH] doc: Fix typo Aniket Patil
@ 2020-10-15 13:09 ` zimoun
2020-10-15 13:15 ` Aniket Patil
0 siblings, 1 reply; 5+ messages in thread
From: zimoun @ 2020-10-15 13:09 UTC (permalink / raw)
To: Aniket Patil, 44006
Dear,
Thank you for your contribution. It is almost fine. Three things are
not “correct“.
1. The commit subject must end with a dot. Like:
doc: Fix typo.
2. Idem inside the commit message.
3. It is “star space path/to/file”, see below.
And last, about the message itself:
> *doc/guix.texi (section 7.5): Fix typo
Usually, the section numbering does not appear. It does not make sense
since it is a moving target. Instead, it seems better to provide the
node name, e.g.,
* doc/guix.texi (Invoking guix import): Fix typo.
Does it make sense?
Now, you should send an updated patch. To do so, you should
‘interactively rebase’. Using Emacs and Magit , it looks like:
r i
edit C-c C-c
# do your tweaks
r r
W c C-m b origin/master C-m v 2 c
! git send-email --to= 44006@debbugs.gnu.org v2-0001-blabla.patch
How does it sound for you?
All the best,
simon
^ permalink raw reply [flat|nested] 5+ messages in thread
* [bug#44006] [PATCH] doc: Fix typo
2020-10-15 13:09 ` zimoun
@ 2020-10-15 13:15 ` Aniket Patil
2020-10-15 13:42 ` zimoun
0 siblings, 1 reply; 5+ messages in thread
From: Aniket Patil @ 2020-10-15 13:15 UTC (permalink / raw)
To: zimoun; +Cc: 44006
[-- Attachment #1: Type: text/plain, Size: 1280 bytes --]
Thanks for the feedback sir!
But I didn’t get
>> 2. Idem inside the commit message.
What does Idem means?
I will do new changes As well.
Aniket.
On Thu, 15 Oct 2020 at 6:39 PM, zimoun <zimon.toutoune@gmail.com> wrote:
> Dear,
>
> Thank you for your contribution. It is almost fine. Three things are
> not “correct“.
>
> 1. The commit subject must end with a dot. Like:
>
> doc: Fix typo.
>
> 2. Idem inside the commit message.
> 3. It is “star space path/to/file”, see below.
>
>
> And last, about the message itself:
>
> > *doc/guix.texi (section 7.5): Fix typo
>
> Usually, the section numbering does not appear. It does not make sense
> since it is a moving target. Instead, it seems better to provide the
> node name, e.g.,
>
> * doc/guix.texi (Invoking guix import): Fix typo.
>
>
> Does it make sense?
>
>
> Now, you should send an updated patch. To do so, you should
> ‘interactively rebase’. Using Emacs and Magit , it looks like:
>
> r i
> edit C-c C-c
> # do your tweaks
> r r
> W c C-m b origin/master C-m v 2 c
> ! git send-email --to= 44006@debbugs.gnu.org v2-0001-blabla.patch
>
> How does it sound for you?
>
>
> All the best,
> simon
>
>
[-- Attachment #2: Type: text/html, Size: 2292 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-10-15 15:41 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-15 7:47 [bug#44006] [PATCH] doc: Fix typo Aniket Patil
2020-10-15 13:09 ` zimoun
2020-10-15 13:15 ` Aniket Patil
2020-10-15 13:42 ` zimoun
2020-10-15 13:44 ` Aniket Patil
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).