From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 2IPNGpy9NmH1GwAAgWs5BA (envelope-from ) for ; Tue, 07 Sep 2021 03:17:16 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id CGDNFZy9NmGBJgAAbx9fmQ (envelope-from ) for ; Tue, 07 Sep 2021 01:17:16 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id EBC191AC1C for ; Tue, 7 Sep 2021 03:17:15 +0200 (CEST) Received: from localhost ([::1]:35758 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mNPjf-00049b-0y for larch@yhetil.org; Mon, 06 Sep 2021 21:17:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38008) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mNPjS-00047P-T2 for guix-patches@gnu.org; Mon, 06 Sep 2021 21:17:06 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:43315) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mNPjS-000655-LU for guix-patches@gnu.org; Mon, 06 Sep 2021 21:17:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mNPjS-00051y-HT for guix-patches@gnu.org; Mon, 06 Sep 2021 21:17:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50072] [PATCH WIP 4/4] upstream: Support updating git-fetch origins. Resent-From: Sarah Morgensen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 07 Sep 2021 01:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50072 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: 50072@debbugs.gnu.org Received: via spool by 50072-submit@debbugs.gnu.org id=B50072.163097737519280 (code B ref 50072); Tue, 07 Sep 2021 01:17:02 +0000 Received: (at 50072) by debbugs.gnu.org; 7 Sep 2021 01:16:15 +0000 Received: from localhost ([127.0.0.1]:54861 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mNPih-00050t-FZ for submit@debbugs.gnu.org; Mon, 06 Sep 2021 21:16:15 -0400 Received: from out0.migadu.com ([94.23.1.103]:58996) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mNPid-00050i-SB for 50072@debbugs.gnu.org; Mon, 06 Sep 2021 21:16:13 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1630977370; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8iyvOhaY+3kNs84M8MiKXnW9p8M5JIIje9zC1QfALbc=; b=RDOlMmEUscGwwLv1AmShUgkF9OabDNc05xRhDf0FOHrSlvSQgvBOsuG8K5wt1s5IK8IXrD jOvdo7GbQaUdW0wC77xQ+Q3dgrEW8WrUOxEmr/0ssb0E1lTOdoUFOp3qUhc3ls1g243gsj JbBwAX/59hkSPRxIFiuyTsqrkrI6lSc= From: Sarah Morgensen References: <8d1ae518b23fac5b15812a30b11df1c360ab3fbf.1629068119.git.iskarian@mgsn.dev> Date: Mon, 06 Sep 2021 18:16:08 -0700 In-Reply-To: (Maxime Devos's message of "Mon, 16 Aug 2021 12:46:25 +0200 (3 weeks, 14 hours, 27 minutes ago)") Message-ID: <86mtopi3s7.fsf@mgsn.dev> MIME-Version: 1.0 Content-Type: text/plain X-Migadu-Auth-User: iskarian@mgsn.dev X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1630977436; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=8iyvOhaY+3kNs84M8MiKXnW9p8M5JIIje9zC1QfALbc=; b=bBZ2KGEk3YBa9tAsihV9Ftc9JWsaf0uKuvfd8gDe0XtWyObOU23IOx8PdpCqeVeuq794oV 9dSXuAOaab+3BC6Q6a8qGMAz74OulV7gMr6CdopW7wFjP+0kgkyVskgRbi60oLtKP7Q7Gm vwOcYvpvi03CTBXV/yzy+Ial9vuDzCYSzM0cht1TSN1ohywHNNhioXEgnq5FQu0C/17ENr XuxD5jBeFGaV1ONtzJEAUScmD3GFu5GpoTNaha/v1k87WuH1IvVltgr0BFNrZhGzpLA+O+ M8vYCcMfiBq2OKGTtA5LXx+Y79jmbxlNQ2gAw4lA3dqGhsiTp/FXEO+UVCEQSQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1630977436; a=rsa-sha256; cv=none; b=eo1630LzPZkaDwqmGNiKATaUb2noRSo5M+5cxLrTfi/1gD/MJoJDxmD3q7Ldf+uw4Z6TXc 9T2A2X2Dhy3/tx20/j9wX0HA3TqdEX9IpRmNkSvZjHMdamwcIlZipMFDU7Zje05u4QAohW YYNwEJMnebpLwgYUb5KZxU9iZcv/4s4GYC4YZwKxkyF4Ft3jT9ko3Xt1LSSHiRTf/1ukvp ZYFnLs2yKbTyG4RvSZmZkS6fqyE1rbNr9zDHRO/ve90ysvlsZrPK4yd7EMMVQlEhIC0t2o 5UMbOlKcSQI8HozdROpU3F3lk3tD85vgG8FqtXSKWHnzoHRbTkGwmTzaWgtOag== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=mgsn.dev header.s=key1 header.b=RDOlMmEU; dmarc=fail reason="SPF not aligned (relaxed)" header.from=mgsn.dev (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: 0.18 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=mgsn.dev header.s=key1 header.b=RDOlMmEU; dmarc=fail reason="SPF not aligned (relaxed)" header.from=mgsn.dev (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: EBC191AC1C X-Spam-Score: 0.18 X-Migadu-Scanner: scn0.migadu.com X-TUID: sYDoDRyxtT7U Hi Maxime, Maxime Devos writes: > Sarah Morgensen schreef op zo 15-08-2021 om 16:25 [-0700]: >> * guix/git-download.scm (checkout-to-store): New procedure. >> * guix/upstream.scm (guess-version-transform) >> (package-update/git-fetch): New procedures. >> (%method-updates): Add GIT-FETCH mapping. > > Does it support packages defined like (a) > > (define-public gnash > (let ((commit "583ccbc1275c7701dc4843ec12142ff86bb305b4") > (revision "0")) > (package > (name "gnash") > (version (git-version "0.8.11" revision commit)) > (source (git-reference > (url "https://example.org") > (commit commit))) > [...]))) Thinking about this again, since updaters typically returns actual versions (tags) instead of commits, how much would such a feature be used? OTOH, I could definitely see use for an ability to update packages like these to proper versions (removing the surrounding 'let') but that's probably more rare and may not be worth the implementation effort. -- SEarah