From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 02SQKn3US2Fr/wAAgWs5BA (envelope-from ) for ; Thu, 23 Sep 2021 03:12:29 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id u/2UJX3US2F2eAAAbx9fmQ (envelope-from ) for ; Thu, 23 Sep 2021 01:12:29 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C4E9E180B8 for ; Thu, 23 Sep 2021 03:12:28 +0200 (CEST) Received: from localhost ([::1]:34846 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mTDHn-0002I7-5S for larch@yhetil.org; Wed, 22 Sep 2021 21:12:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57584) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mTDHO-0001ix-4K for guix-patches@gnu.org; Wed, 22 Sep 2021 21:12:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:40691) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mTDHN-0003fF-Re for guix-patches@gnu.org; Wed, 22 Sep 2021 21:12:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mTDHN-0006x8-Le for guix-patches@gnu.org; Wed, 22 Sep 2021 21:12:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49578] [PATCH v3 1/2] gnu: Add bolt. Resent-From: Sarah Morgensen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 23 Sep 2021 01:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49578 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: phodina Cc: 49578@debbugs.gnu.org Received: via spool by 49578-submit@debbugs.gnu.org id=B49578.163235949126675 (code B ref 49578); Thu, 23 Sep 2021 01:12:01 +0000 Received: (at 49578) by debbugs.gnu.org; 23 Sep 2021 01:11:31 +0000 Received: from localhost ([127.0.0.1]:52237 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mTDGt-0006wB-AW for submit@debbugs.gnu.org; Wed, 22 Sep 2021 21:11:31 -0400 Received: from out1.migadu.com ([91.121.223.63]:61552) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mTDGp-0006vw-Uc for 49578@debbugs.gnu.org; Wed, 22 Sep 2021 21:11:29 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1632359485; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WLUeFHlDYgwtV2VW1qAAdldSbiPgSsi2XDbwp5dyMZM=; b=AgG3PS6WrQR8/o9j5E7ysfQqNyCsvnMLfLyf1vH8eaxJU3b38xG+a7D3iszBc9k3BkgloW EOra7bpRo84VygLF1zyHhDvcgSCAJjPzlCr7T2edL8TCrMnHQbQ37O1IEEoeIaH8zXLw30 ocER1XdlfoaMYVJUJmUlCybBh6+eSo4= From: Sarah Morgensen References: Date: Wed, 22 Sep 2021 18:11:23 -0700 In-Reply-To: (phodina@protonmail.com's message of "Sat, 18 Sep 2021 11:20:38 +0000 (4 days, 12 hours, 42 minutes ago)") Message-ID: <86mto4w0xw.fsf@mgsn.dev> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1632359549; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=WLUeFHlDYgwtV2VW1qAAdldSbiPgSsi2XDbwp5dyMZM=; b=ihb0vj7yTrsJhsCI/n47bEIyJ8i/cTZ3w2AKHLjFvTipUEyiOOMp2178XwK9PSJZyrWtxG O6BmZcPjCuCnAOASi4lQVyLlJKB2E4sNxV2/ujMxSbWpEoTQbz7ix637ocwtGJRN6ald69 aT1exVmA5gKV3TXWCLdlvyS9Y4WtlcXOBaBTvdIDU7Ec16f7MirCEc9VGQXHDZJWhwVmle bZmEe3RmytJ7Q78qQgJxN9XKI5MluHVw/8cSXT5LWUuVxIqdOCcxygTX+cMd/t27mb8WOm kZ4eP/KDhYoQ/0bNaIcZx++bnuY2CpiqfoiJm8lxmn7IthkbOgtLhB9PY97fYA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1632359549; a=rsa-sha256; cv=none; b=rkSM0ZuE3ZwSlyONNEqAaVvPq6Rk0O+P+5qHr1+5uobneC2bRNxFufshpeZZqcfJK3ImSX Vt/bdpA/y32F3lLl0J4mX7uAZUxXd2yphsr5odz/z/rdTw3TLi8IMy15/lTZPg/49COso4 97cOz0bhqULPNbEtuzwQidZ8QbkN1OftRdG0CjIks2/8Zie6M8hDNb5P5djzF0/WtfQSjv 1bvT+l0FHjWZoofH/pP/T57lyH8i0XiRhH41Nc40ZZhUX/bSRfbHqfwN2fsNEyJPpv+KlG jnlAotQkLV+LLrfCV42vG+mhJQAbmcfDUfCECQ9XsWHrDKjeQSKjJMsE0o0lsw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=mgsn.dev header.s=key1 header.b=AgG3PS6W; dmarc=fail reason="SPF not aligned (relaxed)" header.from=mgsn.dev (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.29 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=mgsn.dev header.s=key1 header.b=AgG3PS6W; dmarc=fail reason="SPF not aligned (relaxed)" header.from=mgsn.dev (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: C4E9E180B8 X-Spam-Score: -1.29 X-Migadu-Scanner: scn0.migadu.com X-TUID: sSLAe0ufAyby Hello Petr, Thanks for the updated patch :) I don't have any experiences with services, so I can't comment on the second patch in this series, and I don't have a Thunderbolt controller or devices, so I can't test the actual program, but other than the commit message/synopsis/description this package LGTM. phodina writes: > * gnu/packages/linux.scm: (bolt): New variable. ^ no ":" > + (synopsis "Userspace system daemon for Thunderbolt") Consider this instead (taken from their repository tagline, more understandable to more users): (synopsis "Thunderbolt 3 device manager") > + (description "Userspace daemon @code{boltd} exposes devices via D-Bus to clients. > +It stores database of previously authorized devices and depending > +on the policy set for the individual devices, automatically authorize newly > +connected devices without user interaction. It also adapts its behaivour when > +iommu support is detected. > +Command line utility 'boltctl' can be used to manage thundebolt devices. > +It can list devices, monitor changes and initiate authorization of device.") Consider this instead: (description "This package provides @command{boltd}, a userspace daemon for Thunderbolt devices, and @command{boltctl}, a command-line utility for managing those devices. The daemon @command{boltd} exposes devices via D-Bus to clients. It also stores a database of previously authorized devices and will, depending on the policy set for the individual devices, automatically authorize newly connected devices without user interaction. The command-line utility @command{boltctl} manages Thunderbolt devices via @command{boltd}. It can list devices, monitor changes, and initiate authorization of devices.") > + (home-page "https://gitlab.freedesktop.org/bolt/bolt") > + (license license:gpl2+))) > + > (define-public jitterentropy-rngd > (package > (name "jitterentropy-rngd") > -- > 2.32.0 With those changes, or similar: * Package review checklist (WIP) Lack of a check is not proof of noncompliance. 1. [X] Package builds (guix build package) [X] x86_64 [ ] aarch64 [ ] armhf [ ] powerpc64le [ ] i686 [ ] i586 [ ] mips64le 2. [X] Build is reproducible (guix build --rounds=n package) 3. [X] Tests enabled (if available) or disabled with in-source comment 4. [X] No extraneous dependencies (guix size package) 5. [X] No unnecessary pre-built binaries/blobs 6. [X] Dependencies unvendored when available in Guix 7. [X] Cross-compile friendly (cc-for-target, patches with inputs) 8. [X] License matches source 9. [X] No problematic lints (guix lint package) 10. [X] Formatting follows guidelines - [X] Lines wrap at 80 characters - [X] Indentation passes etc/indent-code.el - [X] Two spaces used between sentences For new packages: 1. [X] Source url is robust * mirror:// used with url-fetch when possible * No auto-generated archives from source repo (prefer cloning) 2. [X] Synopsis is short, descriptive, and meaningful to a wide audience 3. [X] Description is objective, takes 5-10 lines, uses full sentences, and provides the information users need to decide whether the software fits their needs. There are lints for CVEs, but they are for the Bolt CMS, not this project. -- Sarah