unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Adu O'Hara <adu.ohara@posteo.net>
To: Xinglu Chen <public@yoctocell.xyz>
Cc: 49203@debbugs.gnu.org
Subject: [bug#49203] [PATCH 1/2] gnu: Add ocaml-uri-sexp.
Date: Thu, 24 Jun 2021 12:42:27 +0000	[thread overview]
Message-ID: <86lf6zxwec.fsf@posteo.net> (raw)
In-Reply-To: <0c74eedb3a07933206ed2127a2b26f433ab77b18.1624528372.git.public@yoctocell.xyz>


Thanks for the patches!

There is already an `ocaml-uri`. How about updating that to 4.2.0 
(currently at 4.1.0) and let `ocaml-uri-sexp` inherit from 
ocaml-uri with #:package set to "uri-sexp"?

Another alternatively: remove the #:package argument from 
`ocaml-uri` so that all packages are built (`uri`, `uri-sexp` and 
`uri-re`).

Xinglu Chen <public@yoctocell.xyz> writes:

> * gnu/packages/ocaml.scm (ocaml-uri-sexp): New variable.
> ---
>  gnu/packages/ocaml.scm | 28 ++++++++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
>
> diff --git a/gnu/packages/ocaml.scm b/gnu/packages/ocaml.scm
> index 1262c0e303..681d77dd81 100644
> --- a/gnu/packages/ocaml.scm
> +++ b/gnu/packages/ocaml.scm
> @@ -7071,6 +7071,34 @@ Graphics.open_graph is called.  This 
> library used to be distributed with OCaml
>  up to OCaml 4.08.")
>      (license license:lgpl2.1+)))
>  
> +(define-public ocaml-uri-sexp
> +  (package
> +    (name "ocaml-uri-sexp")
> +    (version "4.2.0")
> +    (source
> +      (origin
> +        (method git-fetch)
> +        (uri (git-reference
> +              (url "https://github.com/mirage/ocaml-uri")
> +              (commit (string-append "v" version))))
> +        (file-name (git-file-name name version))
> +        (sha256
> +          (base32
> + 
> "1bgkc66cq00mgnkz3i535srwzwc4cpdsv0mly5dzvvq33451xwf0"))))
> +    (build-system dune-build-system)
> +    (arguments
> +     '(#:package "uri-sexp"
> +       #:test-target "."))
> +    (propagated-inputs
> +      `(("ocaml-uri" ,ocaml-uri)
> +        ("ocaml-ppx-sexp-conv" ,ocaml-ppx-sexp-conv)
> +        ("ocaml-sexplib0" ,ocaml-sexplib0)))
> +    (native-inputs `(("ocaml-ounit" ,ocaml-ounit)))
> +    (home-page "https://github.com/mirage/ocaml-uri")
> +    (synopsis "RFC3986 URI/URL parsing library")
> +    (description "This package adds S-exp support to 
> @code{ocaml-uri}.")
> +    (license license:isc)))
> +
>  (define-public js-of-ocaml
>    (package
>      (name "js-of-ocaml")





  reply	other threads:[~2021-06-24 17:24 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-24  9:54 [bug#49203] [PATCH 0/2] Add ocaml-cohttp and dependencies Xinglu Chen
2021-06-24  9:57 ` [bug#49203] [PATCH 1/2] gnu: Add ocaml-uri-sexp Xinglu Chen
2021-06-24 12:42   ` Adu O'Hara [this message]
2021-06-24 18:39     ` Xinglu Chen
2021-06-24 19:32       ` Adu O'Hara
2021-06-25  9:18         ` Xinglu Chen
2021-06-25 10:04           ` Adu O'Hara
2021-06-25 10:58             ` Xinglu Chen
2021-06-25 11:06               ` Julien Lepiller
2021-06-25 12:39                 ` Xinglu Chen
2021-06-24  9:57 ` [bug#49203] [PATCH 2/2] gnu: Add ocaml-cohttp Xinglu Chen
2021-06-25 13:07 ` [bug#49203] [PATCH v2 0/2] Add ocaml-cohttp and dependencies Xinglu Chen
2021-06-25 13:07   ` [bug#49203] [PATCH v2 1/2] gnu: Add ocaml-uri-sexp Xinglu Chen
2021-06-25 13:07   ` [bug#49203] [PATCH v2 2/2] gnu: Add ocaml-cohttp Xinglu Chen
2021-06-27 13:17   ` bug#49203: [PATCH v2 0/2] Add ocaml-cohttp and dependencies Julien Lepiller
2021-06-27 13:38     ` [bug#49203] " Xinglu Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86lf6zxwec.fsf@posteo.net \
    --to=adu.ohara@posteo.net \
    --cc=49203@debbugs.gnu.org \
    --cc=public@yoctocell.xyz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).