From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 27bHOZvV+GCKsAAAgWs5BA (envelope-from ) for ; Thu, 22 Jul 2021 04:19:07 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id iOwANZvV+GBBXgAA1q6Kng (envelope-from ) for ; Thu, 22 Jul 2021 02:19:07 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A81EE9BBA for ; Thu, 22 Jul 2021 04:19:07 +0200 (CEST) Received: from localhost ([::1]:52738 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m6OIk-0002qZ-Gt for larch@yhetil.org; Wed, 21 Jul 2021 22:19:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43116) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m6OIg-0002qD-UB for guix-patches@gnu.org; Wed, 21 Jul 2021 22:19:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:55794) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m6OIg-0001Z5-Kk for guix-patches@gnu.org; Wed, 21 Jul 2021 22:19:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m6OIg-0008GV-Di for guix-patches@gnu.org; Wed, 21 Jul 2021 22:19:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49577] [PATCH] Add python-pmbootstrap Resent-From: Sarah Morgensen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 22 Jul 2021 02:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49577 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: phodina Cc: 49577@debbugs.gnu.org Received: via spool by 49577-submit@debbugs.gnu.org id=B49577.162692030331710 (code B ref 49577); Thu, 22 Jul 2021 02:19:02 +0000 Received: (at 49577) by debbugs.gnu.org; 22 Jul 2021 02:18:23 +0000 Received: from localhost ([127.0.0.1]:39106 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6OI0-0008FI-DT for submit@debbugs.gnu.org; Wed, 21 Jul 2021 22:18:23 -0400 Received: from out2.migadu.com ([188.165.223.204]:52325) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6OHx-0008F6-C0 for 49577@debbugs.gnu.org; Wed, 21 Jul 2021 22:18:18 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1626920296; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FB2JJuBzAKcHP+rvhNQ6loqsGCBXwu1Cw8vikYYSlwc=; b=X3NNIhXJqjkGfjY9OmxemCDZTOXynLkoToFI1aUI05EncgVZGqnVxnAWhL8bKCMGrUGlKW gxCB7EI9sB2y1STxNFhGP8Zc6fGaQ8tIB1xu96220jKQoQ66J1q2L02YQXDjYBMfpSIxai d2K+m/41tsWLH6ujUeMganfKVJc0uq4= From: Sarah Morgensen References: Date: Wed, 21 Jul 2021 19:18:13 -0700 In-Reply-To: (phodina@protonmail.com's message of "Sun, 18 Jul 2021 10:35:00 +0000") Message-ID: <86lf5zrt0a.fsf_-_@mgsn.dev> MIME-Version: 1.0 Content-Type: text/plain X-Migadu-Auth-User: iskarian@mgsn.dev X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1626920347; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=FB2JJuBzAKcHP+rvhNQ6loqsGCBXwu1Cw8vikYYSlwc=; b=r2S4QmKu19fjr5jtLIT2bxqukC4DIagy7a4HK8KOIpX4mPB/bmQTTl7LyQUaLctmDRM0it DagoP4R2YJ62SUjytc4QN31brNMedB6+ztcfBB25nRB2AzNZq28ODfDC0P1s073XBAr8LI 2ayen4ugU+FPR9iw1q9kOkRzVf0C0pv1c61SMWpf1BJkE9Ht0G67XNuZ2ndmdaTjHB+XYl YT95S8kwbdA9e2IqX2UQj8DMnXP2/6q0nXOf0S0fqDpC2kUNZo18Z33P2c4G5BsygYO+tP LqBlB+2hGpEP0yVGWO3g1TdII4GngigfYBCDCwxtqlLJCK+HTFSqfsRtzTMwuA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1626920347; a=rsa-sha256; cv=none; b=ndK1YK4WgEtiFZU4G8StZSCgosb2E86Onak+cl9kbPMb4AQce+BQZ3k7WyXX+MF+rzlLyh 2t3b9hBOXis2nQ4tGxL95+1Ze7yiUatR8YjAfUAe8wUto5vqUGNzFjv+vfvV4lT3Ws42hY knLyRwCkK5jc9P2bE5q27dhmV95Quu6eVp+LeA6qgcJRIadYiBZV+SjHU8uYHEX+Q1ITS6 l9lgJvfox6ZsLCDARj9bB6wuAah1m8BobGdtN/mo48+DFRc1lacty4e5D3VqSqaqpIjrL9 3Zdu6IX+05NBKVjaxMFCRVaaeNFkV2w62K6wvKSeRKYl+aVD/38hdp7Tg7EHUA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=mgsn.dev header.s=key1 header.b=X3NNIhXJ; dmarc=fail reason="SPF not aligned (relaxed)" header.from=mgsn.dev (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.31 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=mgsn.dev header.s=key1 header.b=X3NNIhXJ; dmarc=fail reason="SPF not aligned (relaxed)" header.from=mgsn.dev (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: A81EE9BBA X-Spam-Score: -1.31 X-Migadu-Scanner: scn0.migadu.com X-TUID: V5R5kBo5lH+Y Hi! Thanks for the patch. I have some suggestions for this one as well. phodina writes: > Here's updated patch with better package description: > > --- > index d8c3fbec07..a59d065efa 100644 > --- a/gnu/packages/python-xyz.scm > +++ b/gnu/packages/python-xyz.scm > @@ -985,6 +985,44 @@ and URL-safe UUIDs. UUIDs are generated using the built-in Python @code{uuid} > module and then similar looking characters are removed.") > (license license:bsd-3))) > > +(define-public python-pmbootstrap > + (package > + (name "python-pmbootstrap") > + (version "1.32.0") > + (source > + (origin > + (method url-fetch) > + (uri (pypi-uri "pmbootstrap" version)) > + (sha256 > + (base32 > + "1j796f4wrcdrjd7j9m3w3ziiyqq17kskil9bgy893j6sk73fc5q0")))) > + (build-system python-build-system) > + ;; TODO: Running tests fails > + (arguments > + '(#:tests? #f)) It is not a good idea to skip tests without knowing why they fail, as there could be subtle bugs in the program even if it seems to run. In this case, it seems like the reason they're failing is that the pypi release strips some directories that are required for testing. Perhaps try from the git repo? > + (inputs > + `(("python-pytest" ,python-pytest) ("python-pyopenssl" ,python-pyopenssl))) Typically test packages are put in native-inputs rather than inputs. > + (propagated-inputs `(("openssl" ,openssl))) Is this necessary? If pmbootstrap just uses openssl through pyopenssl, it shouldn't be necessary. > + (home-page "https://www.postmarketos.org") > + (synopsis > + "A sophisticated chroot / build / flash tool to develop and install > +postmarketOS") > + (description > + "Bootstrap program that abstracts everything in chroots and therefore > +basically runs on top of any Linux distribution. Features: > +@enumerate > +@item chroot setup (distro-independent QEMU user emulation > +@item clean chroot shutdown (umount) and zapping > +@item build software as packages > +@item cross-compile all armhf-packages > +@item effective caching out of the box (survives chroot zaps) > +@item installation targets > +@item flasher abstractions > +@item logging > +@item security > +@end enumerate") > + (license #f))) Please make sure not to skip the license field. It looks like this one is gpl3. > + > (define-public python-logwrap > (package > (name "python-logwrap") > -- > 2.31.1 -- Sarah