unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Jelle Licht <jlicht@fsfe.org>
To: Ryan Prior <rprior@protonmail.com>, 52155@debbugs.gnu.org
Subject: [bug#52155] [PATCH] gnu: esbuild: Update to 0.14.0.
Date: Sun, 28 Nov 2021 14:14:51 +0100	[thread overview]
Message-ID: <86lf18a0c4.fsf@fsfe.org> (raw)
In-Reply-To: <20211128054358.18213-1-rprior@protonmail.com>

Ryan Prior via Guix-patches via <guix-patches@gnu.org> writes:

> * gnu/packages/web.scm (esbuild): Update to 0.14.0.
> ---
>  gnu/packages/web.scm | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm
> index 0c5e191018..829ca0ac47 100644
> --- a/gnu/packages/web.scm
> +++ b/gnu/packages/web.scm
> @@ -1654,7 +1654,7 @@ (module "tidy")
>  (define-public esbuild
>    (package
>      (name "esbuild")
> -    (version "0.12.28")

Current master has esbuild 0.12.9, is this patch perhaps based on one of
your local branches?

> +    (version "0.14.0")
>      (source
>       (origin
>         (method git-fetch)
> @@ -1663,7 +1663,7 @@ (define-public esbuild
>               (commit (string-append "v" version))))
>         (file-name (git-file-name name version))
>         (sha256
> -        (base32 "1rjsbqshkx930cw07v63g4blzbd9zcm6jbb5yv9k86i59gprh8s8"))
> +        (base32 "09r1xy0kk6c9cpz6q0mxr4why373pwxbm439z2ihq3k1d5kk7x4w"))
>         (modules '((guix build utils)))
>         (snippet
>          '(begin
> --
> 2.33.1

LGTM otherwise, but didn't you recently post an (now outdated) update to
esbuild that also updated one of its dependencies[0]? Does that comment
no longer hold, or is this patch building on top of the other one?

- Jelle

[0]: https://issues.guix.gnu.org/50612




  reply	other threads:[~2021-11-28 13:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-28  5:44 [bug#52155] [PATCH] gnu: esbuild: Update to 0.14.0 Ryan Prior via Guix-patches via
2021-11-28 13:14 ` Jelle Licht [this message]
2021-11-28 15:57   ` Ryan Prior via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86lf18a0c4.fsf@fsfe.org \
    --to=jlicht@fsfe.org \
    --cc=52155@debbugs.gnu.org \
    --cc=rprior@protonmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).