unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: zimoun <zimon.toutoune@gmail.com>
To: 56426@debbugs.gnu.org
Cc: efraim@flashner.co.il
Subject: [bug#56426] [PATCH 0/6] Add Julia CSV
Date: Fri, 08 Jul 2022 09:51:59 +0200	[thread overview]
Message-ID: <86let4nisg.fsf@gmail.com> (raw)
In-Reply-To: <20220706180537.406140-1-zimon.toutoune@gmail.com> (zimoun's message of "Wed, 6 Jul 2022 20:05:37 +0200")

Hi,

On Wed, 06 Jul 2022 at 20:05, zimoun <zimon.toutoune@gmail.com> wrote:

> This series adds Julia CSV reader/writer.  Well, 'CSV.Chunks' fails so then
> the 2 related tests.  I have no clue what could be wrong.  Therefore, I have
> disabled these two ones.

Well, I have no clue why CVS.Chunks fails:

--8<---------------cut here---------------start------------->8---
 :col1  PosLenStringCSV.File basics: Error During Test at
/gnu/store/…-julia-csv-0.10.4/share/julia/loadpath/CSV/test/basics.jl:20
  Got exception outside of a @test
  ArgumentError: unable to iterate chunks from input file source
  Stacktrace:
    [1] CSV.Chunks(source::String; header::Int64, normalizenames::Bool, datarow::Int64, skipto::Int64,
footerskip::Int64, transpose::Bool, comment::Nothing, ignoreemptyrows::Bool, ignoreemptylines::Nothing,
select::Nothing, drop::Nothing, limit::Nothing, buffer_in_memory::Bool, ntasks::Nothing, tasks::Nothing,
rows_to_check::Int64, lines_to_check::Nothing, missingstrings::Vector{String}, missingstring::String,
delim::Nothing, ignorerepeated::Bool, quoted::Bool, quotechar::Char, openquotechar::Nothing,
closequotechar::Nothing, escapechar::Char, dateformat::Nothing, dateformats::Nothing, decimal::UInt8,
truestrings::Vector{String}, falsestrings::Vector{String}, stripwhitespace::Bool, type::Nothing, types::Nothing,
typemap::Dict{Type, Type}, pool::Tuple{Float64, Int64}, downcast::Bool, lazystrings::Bool,
stringtype::Type{PosLenString}, strict::Bool, silencewarnings::Bool, maxwarnings::Int64, debug::Bool,
parsingdebug::Bool, validate::Bool)
      @ CSV /gnu/store/…-julia-csv-0.10.4/share/julia/loadpath/CSV/src/chunks.jl:81
    [2] macro expansion
      @ /gnu/store/…-julia-csv-0.10.4/share/julia/loadpath/CSV/test/basics.jl:510 [inlined]
--8<---------------cut here---------------end--------------->8---

because it just reads:

--8<---------------cut here---------------start------------->8---
510: chunks = CSV.Chunks(joinpath(dir, "promotions.csv"); stringtype=PosLenString)
511: @test sum(length, chunks) == 10000
512: @test Tables.partitions(chunks) === chunks
--8<---------------cut here---------------end--------------->8---

Well, these 3 lines and 2 tests are thus bypassed over the thousands of
other tests. :-)


> I am currently checking some packages for i686-linux but the issues, if any,
> can be addressed later.  Having the feedback from the build will help.

Well, the current situation of i686 is bad [1,2] but unrelated to this
patch series.  Let merge this series which is perfectly fine for x86_64
and then fix the other arch as i686.

1: <https://ci.guix.gnu.org/build/1089455/details>
2: <https://ci.guix.gnu.org/build/1089455/log/raw>


Cheers,
simon




  parent reply	other threads:[~2022-07-08  7:53 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-06 18:05 [bug#56426] [PATCH 0/6] Add Julia CSV zimoun
2022-07-06 18:06 ` [bug#56426] [PATCH 1/6] gnu: julia-parsers: Update to 2.2.4 zimoun
2022-07-06 18:06   ` [bug#56426] [PATCH 2/6] gnu: Add julia-inlinestrings zimoun
2022-07-06 18:06   ` [bug#56426] [PATCH 3/6] gnu: julia-json: Update to 0.21.3 zimoun
2022-07-06 18:06   ` [bug#56426] [PATCH 4/6] gnu: julia-weakrefstrings: Update to 1.4.0 zimoun
2022-07-06 18:06   ` [bug#56426] [PATCH 5/6] gnu: Add julia-sentinelarrays zimoun
2022-07-06 18:06   ` [bug#56426] [PATCH 6/6] gnu: Add julia-csv zimoun
2022-07-08  7:51 ` zimoun [this message]
2022-07-11 10:08 ` bug#56426: [PATCH 0/6] Add Julia CSV Efraim Flashner
2022-07-11 11:42   ` [bug#56426] " zimoun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86let4nisg.fsf@gmail.com \
    --to=zimon.toutoune@gmail.com \
    --cc=56426@debbugs.gnu.org \
    --cc=efraim@flashner.co.il \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).