From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38913) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d6XY3-0003GO-CJ for guix-patches@gnu.org; Fri, 05 May 2017 03:21:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d6XXy-0008Cy-G4 for guix-patches@gnu.org; Fri, 05 May 2017 03:21:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:57112) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d6XXy-0008Cn-CS for guix-patches@gnu.org; Fri, 05 May 2017 03:21:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1d6XXy-0005NY-4z for guix-patches@gnu.org; Fri, 05 May 2017 03:21:02 -0400 Subject: bug#26339: [PATCH 17/18] scripts: system: Adapt "switch-generation" to new bootloader API. Resent-Message-ID: References: <20170402135242.2958-1-m.othacehe@gmail.com> <20170402135242.2958-17-m.othacehe@gmail.com> <20170415184756.10b178be@scratchpost.org> <8737d9inte.fsf@gmail.com> <20170505091306.17e5bdd9@scratchpost.org> From: Mathieu Othacehe In-reply-to: <20170505091306.17e5bdd9@scratchpost.org> Date: Fri, 05 May 2017 09:21:04 +0200 Message-ID: <86k25v4vmn.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Danny Milosavljevic Cc: 26339@debbugs.gnu.org Hey Danny ! > Ah, so this is trying to restore the correct bootloader to the correct device, should the user have switched bootloader of the guix system and then switched back. That's it. > What happens if the user switches to an old generation which doesn't have this new-style parameters file? Well, by default the bootloader is assumed to be grub (because grub is the only supported bootloader in pre-rework guix). For the boot-device, it is set to #f if not read in parameter file. During a switch-genereation if boot-device is #f, the configuration is updated, but the bootloader is not reinstalled. It was already what happended before my rework. The bootloader was not reinstalled because we cannot be certain to reinstall the same grub version as the one installed. Mathieu