From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id eHYvHqLh1GAdTQAAgWs5BA (envelope-from ) for ; Thu, 24 Jun 2021 21:48:50 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id P6TAGaLh1GBxYAAAbx9fmQ (envelope-from ) for ; Thu, 24 Jun 2021 19:48:50 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 92223121AF for ; Thu, 24 Jun 2021 21:48:49 +0200 (CEST) Received: from localhost ([::1]:37582 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lwVLE-0001Ju-Ko for larch@yhetil.org; Thu, 24 Jun 2021 15:48:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44372) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lwVKW-0000no-24 for guix-patches@gnu.org; Thu, 24 Jun 2021 15:48:05 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:60883) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lwVKU-0004ZN-Lf for guix-patches@gnu.org; Thu, 24 Jun 2021 15:48:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lwVKU-0002YJ-9O for guix-patches@gnu.org; Thu, 24 Jun 2021 15:48:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49203] [PATCH 1/2] gnu: Add ocaml-uri-sexp. Resent-From: Adu O'Hara Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 24 Jun 2021 19:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49203 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Xinglu Chen Cc: 49203@debbugs.gnu.org Received: via spool by 49203-submit@debbugs.gnu.org id=B49203.16245640749796 (code B ref 49203); Thu, 24 Jun 2021 19:48:02 +0000 Received: (at 49203) by debbugs.gnu.org; 24 Jun 2021 19:47:54 +0000 Received: from localhost ([127.0.0.1]:44196 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lwVKM-0002Xw-3o for submit@debbugs.gnu.org; Thu, 24 Jun 2021 15:47:54 -0400 Received: from mout01.posteo.de ([185.67.36.65]:42273) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lwVKI-0002Xh-Pr for 49203@debbugs.gnu.org; Thu, 24 Jun 2021 15:47:53 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 7A8FD24002D for <49203@debbugs.gnu.org>; Thu, 24 Jun 2021 21:47:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1624564064; bh=efF+zcSRnpJdhkEnSqmeVj5i6pBbi0Fy5hp8pcwL+6A=; h=From:To:Cc:Subject:Date:From; b=HgzE0lvH1NlMpQh5emoCnXWUMJpxbViWGAwkVZfPa15ILrXxRdq0bPfRH0NnAfnvk 4zowxKKRd85dT+PgODOwlMN7HYfGXohoTtInXTilIwuCdxdHAL0zWP+G0rP62rvGGy x88vIAWFm7LQuT/t9SfHuqKMBit+JeTXgep8zkTRp0cjrrRvdHdfYvXFY5ug23QXRR wuq21YqvC2CbJRnpvy9xDimMRXbj0EGl11BNQnkU2/dtNrqpowFtaEFpw/NnJ1VI5B QURb0MWrAHRgmxgAW1sGLGJjrrMEjcvBlhUCv5u56xNC1yV7ECXeeGvLqA++7TkyJo DiMZ7yB90Jr2w== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4G9rJb475Zz9rxQ; Thu, 24 Jun 2021 21:47:43 +0200 (CEST) References: <0c74eedb3a07933206ed2127a2b26f433ab77b18.1624528372.git.public@yoctocell.xyz> <86lf6zxwec.fsf@posteo.net> <87a6nf9kef.fsf@yoctocell.xyz> From: Adu O'Hara Date: Thu, 24 Jun 2021 19:32:30 +0000 In-reply-to: <87a6nf9kef.fsf@yoctocell.xyz> Message-ID: <86k0mjxcwx.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1624564130; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=QRWhJYMOzA9/X/JCwc6WfdhvzHkrmpvXOPW44eexxuU=; b=ej+JdYFDDGsn1YIyMiknLHnvtFQ9bo8NaGhNDZAweZNZnGyI32Lts4BX9DY/NUOecmz9tJ HojeRoF/wDl8P7KC0b0dyfI0IHB85OZ+k2MRxByNGWu+JqAyuLNausaXdt5dWSRbOHF0/K VZKOYTb5eDREBbieG4sghGTzA5MZsUR9IpFRCz2iI89Hou0xgo4n9Mip7G0ATBi6FKW55J vjmQbDUJhmy+LCWSfh3i9TgSLuqhOTJayW2UVN3GdfyY1YCiLCb6SWRy6DzQsZSorJ2R7q Sg94NyNb3FGd8dzwjovwOIZbB5ZdjozbLYoSrX7HDZyPeubNDDtfA6G7pM8CCg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1624564130; a=rsa-sha256; cv=none; b=lBBut13AjqwAXu3KOnXq3l0otCC3A2Ym2ZuY/x5Qtjj7ukRuO75TUVPm6NluFsOaE1mcRr ABCK6r67wkwfNje7AOD02HEF7afDJftd1r2n1anWhKdSXn+unxucyTHBkWDMzjsELEk18b iURmuSPzAGs11RfKLMDvcZ8ofyyazLUwPmwFicTkdEYNlEhslthQhJMu02aWuRxecwwIhl lev9sECS24r9f9KiwlwvloU8h2a8rr6l+rqePO+hJO7VEflEZzYhHghKOf4M5+rAVp77wm UhvVhSZqVQnQif5beKyFRHgF/EuvmhN3LwpNO3TLlvFM8JSUrmrRXUxgFgW+vg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=HgzE0lvH; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.33 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=HgzE0lvH; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 92223121AF X-Spam-Score: -1.33 X-Migadu-Scanner: scn0.migadu.com X-TUID: 7H0XmRO254d2 Xinglu Chen writes: > On Thu, Jun 24 2021, Adu O'Hara wrote: > >> Thanks for the patches! >> >> There is already an `ocaml-uri`. How about updating that to=20 >> 4.2.0=20 >> (currently at 4.1.0) and let `ocaml-uri-sexp` inherit from=20 >> ocaml-uri with #:package set to "uri-sexp"? > > That could probably be done in a separate patch series; this=20 > series is > about adding =E2=80=98ocaml-cohttp=E2=80=99. True, what I was suggesting would add another patch to the series=20 and mix up intentions of the series. Still, I'd suggest for=20 ocaml-uri-sexp to inherit from ocaml-uri. Otherwise we have them=20 at two different versions. wdyt? > >> Another alternatively: remove the #:package argument from=20 >> `ocaml-uri` so that all packages are built (`uri`, `uri-sexp`=20 >> and=20 >> `uri-re`). > > Those are three separate packages on Opam, so I don=E2=80=99t think it=20 > makes > sense for us to merge them into one. Not everyone who installs > =E2=80=98ocaml-uri=E2=80=99 is going to want =E2=80=98ocaml-uri-sexp=E2= =80=99 and=20 > =E2=80=98ocaml-uri-re=E2=80=99. > > WDYT? Yeah, that make sense. Keeping them separate sounds good.