From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id EGYnFzuaMmFMbQAAgWs5BA (envelope-from ) for ; Fri, 03 Sep 2021 23:57:15 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id MKByEjuaMmGwHwAA1q6Kng (envelope-from ) for ; Fri, 03 Sep 2021 21:57:15 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9456F9BBF for ; Fri, 3 Sep 2021 23:57:14 +0200 (CEST) Received: from localhost ([::1]:35864 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mMHBR-0001aR-FH for larch@yhetil.org; Fri, 03 Sep 2021 17:57:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36774) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mMHBI-0001Wh-9C for guix-patches@gnu.org; Fri, 03 Sep 2021 17:57:06 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:34436) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mMHBG-00069D-Fb for guix-patches@gnu.org; Fri, 03 Sep 2021 17:57:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mMHBG-00021p-66 for guix-patches@gnu.org; Fri, 03 Sep 2021 17:57:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50349] [PATCH] packages: Add 'define-package' syntax. References: <15d01b32313f5f2f291b120597719ae92bd26acd.1630639896.git.iskarian@mgsn.dev> Resent-From: Sarah Morgensen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 03 Sep 2021 21:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50349 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: zimoun Cc: 50349@debbugs.gnu.org Received: via spool by 50349-submit@debbugs.gnu.org id=B50349.16307062047774 (code B ref 50349); Fri, 03 Sep 2021 21:57:02 +0000 Received: (at 50349) by debbugs.gnu.org; 3 Sep 2021 21:56:44 +0000 Received: from localhost ([127.0.0.1]:45982 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mMHAx-00021K-VG for submit@debbugs.gnu.org; Fri, 03 Sep 2021 17:56:44 -0400 Received: from out0.migadu.com ([94.23.1.103]:15803) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mMHAu-00021A-Gm for 50349@debbugs.gnu.org; Fri, 03 Sep 2021 17:56:42 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1630706199; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to; bh=qEybClVhktQXsFa1aYpZcVf6+Vlq2l9FsyrgHZc+ZUE=; b=aY4rmFM6zRDi1lub90Selq63k+T/iIMV7kxldGtHRuR5SBkCh5U1fGUg5Wi67ehwMWdmdJ Pijhr6J9B4T812eGk3hqH4WjTzzCnmfMFNuANGwc9pvPIAopgVrJea6DQPr+usR8/oix2w HhuX1isK79exnZWDe609djIdOHtXg7U= From: Sarah Morgensen Date: Fri, 03 Sep 2021 14:56:36 -0700 In-Reply-To: zimoun's message of "Fri, 03 Sep 2021 07:41:18 +0200 (15 hours, 51 minutes, 17 seconds ago)" Message-ID: <86k0jxxqzv.fsf@mgsn.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Migadu-Auth-User: iskarian@mgsn.dev X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1630706235; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=qEybClVhktQXsFa1aYpZcVf6+Vlq2l9FsyrgHZc+ZUE=; b=UkGieP6MlvxTSOITuR2KjOhl0lcEvBydL+B6bFZ+TLDokaGpbZPUzryMwcKeSTp4tKQE2e rJY40dlWSofTUuCkHfIXNjp5a3f2XVGskcJuh53cB3e3ei7+sWkuMsqYvNJQmjEcnWx09A JCYIp+3h52P+SR41bUdAsfpeMMnD3AX52fTOisxh1WzMoY85d0jAxMfbvf/1H69ZnYkpDi aL9hXW/FKob9MaxDI7krrUNueIa3rfHBVIhdQ41L0TIflTNOFWuEW+GPSJLapLByc1+m2O acfPOuiuxt8KSlPIk+pNqIoC0OW2Oi9RWduOz3ZQmSc0eqSxTT1fCh9R8skXLg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1630706235; a=rsa-sha256; cv=none; b=gZo6uug2JOHUM3pyTP32rzlCoT8ZHUdhhck4dc+ZF/MP56TUvzwRiHniXoCJeraVjSHuGH s/XbGwzbyc+Q49KcqBkOOFI/W0JXmcKsU5JgRJvc/8l4NoAFi0r+1rh13O+baN6V3RxAMp z1hQXdzqWERxykx91I7cR4F4ZB54ZIUfX8jNZoqyrgkQWSGdYo/DQ1snshf+7NR5Y9B9Dx W2cgfcmldLWp+lBtj2gZQ9DZrrnNn0fWIK7/9ypD+ATkTRh219cNZ0FvxSeTdh/P4oA12x Zxl6X+zr5kHwQa3Up1EoxqGalo1OI5lCkapEsKs2cXbdldpxrOns4lyWxnvQpw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=mgsn.dev header.s=key1 header.b=aY4rmFM6; dmarc=fail reason="SPF not aligned (relaxed)" header.from=mgsn.dev (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.32 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=mgsn.dev header.s=key1 header.b=aY4rmFM6; dmarc=fail reason="SPF not aligned (relaxed)" header.from=mgsn.dev (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 9456F9BBF X-Spam-Score: -1.32 X-Migadu-Scanner: scn1.migadu.com X-TUID: 4W/cAiSbAukW Hi, zimoun writes: > Hi Sarah, > > On Thu, 02 Sep 2021 at 21:06, Sarah Morgensen wrote: > >> (define-package my-favorite-package >> (name "my-favorite-package") >> ...) >> >> The purpose is primarily to save the horizontal indent, but IMO it looks >> better, and is marginally more clear for newcomers. I think ideally we = could >> eventually transition to using this syntax as the primary syntax and onl= y use >> 'define-public' when necessary. > > On one hand, I think it is a good idea; especially for newcomers. On > the other hand, it will break =E2=80=99git-blame=E2=80=99, isn=E2=80=99t = it? Yes, there would be a one-time discontinuity. Reformats like this can be ignored with the `--ignore-ref' option, or with a file and a config option: .git-blame-ignore-revs: --8<---------------cut here---------------start------------->8--- # Convert 'define-public' forms to 'define-package' forms 15d01b32313f5f2f291b120597719ae92bd26acd --8<---------------cut here---------------end--------------->8--- .git/config: --8<---------------cut here---------------start------------->8--- [blame] ignoreRevsFile =3D .git-blame-ignore-revs --8<---------------cut here---------------end--------------->8--- We could include the latter in e.g. a `.gitconfig' file committed to the repo, but in order to use config settings from the file, users would have to first run git config --local include.path ../.gitconfig Thankfully, this only has to be done once per clone. If you really wanted to make sure it got run, I suppose you could add it to a 'make' target. -- Sarah