From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id uQoCL2+kEGCwUwAA0tVLHw (envelope-from ) for ; Tue, 26 Jan 2021 23:23:27 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id yLqOKm+kEGD3cQAAB5/wlQ (envelope-from ) for ; Tue, 26 Jan 2021 23:23:27 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 917B69402C2 for ; Tue, 26 Jan 2021 23:23:26 +0000 (UTC) Received: from localhost ([::1]:43544 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l4XgD-0006ed-E1 for larch@yhetil.org; Tue, 26 Jan 2021 18:23:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48340) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l4Xfq-0006cR-JZ for guix-patches@gnu.org; Tue, 26 Jan 2021 18:23:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:59641) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l4Xfq-0006iI-BL for guix-patches@gnu.org; Tue, 26 Jan 2021 18:23:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l4Xfq-0008P3-8d for guix-patches@gnu.org; Tue, 26 Jan 2021 18:23:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#45984] [PATCH 0/5] Fix recursive importers Resent-From: zimoun Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 26 Jan 2021 23:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45984 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 45984-submit@debbugs.gnu.org id=B45984.161170332832224 (code B ref 45984); Tue, 26 Jan 2021 23:23:02 +0000 Received: (at 45984) by debbugs.gnu.org; 26 Jan 2021 23:22:08 +0000 Received: from localhost ([127.0.0.1]:42954 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l4Xey-0008Ng-GF for submit@debbugs.gnu.org; Tue, 26 Jan 2021 18:22:08 -0500 Received: from mail-wm1-f49.google.com ([209.85.128.49]:53765) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l4Xew-0008NC-8M for 45984@debbugs.gnu.org; Tue, 26 Jan 2021 18:22:06 -0500 Received: by mail-wm1-f49.google.com with SMTP id j18so13225wmi.3 for <45984@debbugs.gnu.org>; Tue, 26 Jan 2021 15:22:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-transfer-encoding; bh=GjmobCRtpGifvNcluM2NUGs4F0FEkjM8fVBqxEYKCD4=; b=hZGE2ji67SnX41bYKr4dsHGeexHd4JDfuBEZvhdOTsntQPLcXaYtv9a828rbqJbreK npJE0KVVXdtJ6whlcf8Y7gWHVzHfVK+xCC0TQafTT7NrD9QXW+zizMkzDG7jZDTIeoqV k4Vsi6dl5/BWUdAl5/8fuT8udoDq9t4afV30ChKkSFP4zLrOqOS3K6fVH1WDCW9E7uwL L3EQGJcHuK2BdXRqGR6hOZOoF9TS+hl51Z8Kb6p0IatloyC1XAiUEwMWj2d22Idoha5C Jn0UIttj1grGmibc07PVSH1utdqczCl4jg/7k6otnC8ZpeidlrUauy2N0gUbVJded2KN 7FEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=GjmobCRtpGifvNcluM2NUGs4F0FEkjM8fVBqxEYKCD4=; b=MZazB7oOlLVTHm16S6ojQMB+1U1VQJArm41XuQxMe9IKUKNcjkeTKZvIVG33pP1hN/ EyLz627fbK7JtBQnhOVr5hRAKJ8wzPpWrQ2Ybl8RL5MslMWqunlPtlpNI6eWHfrqBGFx mpz4BmeR9BtCWLsW2uclCqGuQy5vcEaD9V3ZxCXrgsqvnaZqw70yjjzm4gHINCgUZGjt Kc7wzAGTiwSFAW9Mame2f64XYuLXuNGv3+LXN7pY6y3UNvOBxvBEbhFitKINKJCAjiXD rFZmHh8ixsK8HcquR5Eg+ZQcmhYB4HfVeaoq6zKfQdU/S6ETwFgn9Kv69Ul2LSo/afvd kLkw== X-Gm-Message-State: AOAM530zWFd4dUZvA+jhnEsZZN6cbtdugnmI0l6Ob00EgXVGhePVv3bD tkFe3WIJJNQpgC6skKbxuUxJ5lDdMHo= X-Google-Smtp-Source: ABdhPJwA1WgmD5k/+3TscFV95as3bfzLTV9BoQ1hcJhIYZevqV5E8T6BZq9GLJ2qKUU7ajTCMzmimw== X-Received: by 2002:a1c:2009:: with SMTP id g9mr1618963wmg.7.1611703320331; Tue, 26 Jan 2021 15:22:00 -0800 (PST) Received: from lili ([88.126.110.68]) by smtp.gmail.com with ESMTPSA id r15sm416514wrq.1.2021.01.26.15.21.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Jan 2021 15:21:59 -0800 (PST) From: zimoun In-Reply-To: <87ft2nwd3b.fsf@gnu.org> References: <20210119154525.11230-1-zimon.toutoune@gmail.com> <87ft2nwd3b.fsf@gnu.org> Date: Wed, 27 Jan 2021 00:16:35 +0100 Message-ID: <86im7ji90s.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 45984@debbugs.gnu.org Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -1.25 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=hZGE2ji6; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 917B69402C2 X-Spam-Score: -1.25 X-Migadu-Scanner: scn1.migadu.com X-TUID: Z9ieONOJQ5Pp Hi Ludo, Thanks for the review. On Tue, 26 Jan 2021 at 23:24, Ludovic Court=C3=A8s wrote: >> $ guix import gem do-not-exist -r >> #f >> >> $ ./pre-inst-env guix import gem do-not-exist -r >> guix import: error: failed to download meta-data for package 'do-not-exi= st' > > I think we do want this error message. Why should we ignore > non-existent packages when doing =E2=80=98-r=E2=80=99? It would think th= ey=E2=80=99re still a > problem, no? Do you mean instead of displaying an error about the query (what the patch does), displaying which dependent package has failed? Something along these lines: $ ./pre-inst-env guix import gem foo -r guix import: error: failed to download meta-data for package 'bar' If it is what you have in mind, it needs to really re-think how =E2=80=99recursive-import=E2=80=99 works. Not only fixing the corner case.= :-) >> If I understand correctly, then the way the errors are reported could be >> uniformized between all the importers, and maybe the snippet in the subc= ommands >> "guix import " could be refactorized a bit. > > Probably. =E2=80=98-r=E2=80=99 started as an option specific to one impo= rter, but now > that most of them (?) support it, it=E2=80=99d make sense to rethink the > interfaces. If we agree on the first part (the function argument =E2=80=9C#:key repo->guix-package=E2=80=9D provided to =E2=80=99recursive-import=E2=80=99 = should always return =E2=80=99values=E2=80=99), then let rethink the interface and how the error= s are handled. Cheers, simon