From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id +Hr3IWxe+mAamAAAgWs5BA (envelope-from ) for ; Fri, 23 Jul 2021 08:15:08 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id uEOWHWxe+mD8SgAAB5/wlQ (envelope-from ) for ; Fri, 23 Jul 2021 06:15:08 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id F397849AF for ; Fri, 23 Jul 2021 08:15:07 +0200 (CEST) Received: from localhost ([::1]:43418 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m6oSh-0002PO-3U for larch@yhetil.org; Fri, 23 Jul 2021 02:15:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44234) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m6oSc-0002PF-UN for guix-patches@gnu.org; Fri, 23 Jul 2021 02:15:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:58844) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m6oSc-0006JF-Lg for guix-patches@gnu.org; Fri, 23 Jul 2021 02:15:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m6oSc-0002KO-Hb for guix-patches@gnu.org; Fri, 23 Jul 2021 02:15:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49281] Add dynaconf Resent-From: Sarah Morgensen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 23 Jul 2021 06:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49281 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: paul Cc: 49281@debbugs.gnu.org Received: via spool by 49281-submit@debbugs.gnu.org id=B49281.16270208848908 (code B ref 49281); Fri, 23 Jul 2021 06:15:02 +0000 Received: (at 49281) by debbugs.gnu.org; 23 Jul 2021 06:14:44 +0000 Received: from localhost ([127.0.0.1]:42157 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6oSJ-0002Jb-MK for submit@debbugs.gnu.org; Fri, 23 Jul 2021 02:14:43 -0400 Received: from out2.migadu.com ([188.165.223.204]:52561) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6oSG-0002JR-Hy for 49281@debbugs.gnu.org; Fri, 23 Jul 2021 02:14:42 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1627020878; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EPHs5cNO2YUK5QryyW4RShVBkq0j01FWS7RLQG1haRg=; b=D0kqFsT0m+SEBtQ/VaEoHLM5HIt6SXoTHqyt1ArNpTXStPcklOBxX65L+/ODV1Gpn5Dc3E ZIyLWtO9hWQlUxk+7ue3bhxJINcSysibjth4BvuS7ewRuUF94kn3CqmMcn4FcJq3JRZo9/ oycPsjFwBy+w9a3ljbfoz1gIp2riJaM= From: Sarah Morgensen References: Date: Thu, 22 Jul 2021 23:14:36 -0700 In-Reply-To: (paul's message of "Wed, 30 Jun 2021 00:38:05 +0200") Message-ID: <86im11r1yr.fsf@mgsn.dev> MIME-Version: 1.0 Content-Type: text/plain X-Migadu-Auth-User: iskarian@mgsn.dev X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1627020908; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=EPHs5cNO2YUK5QryyW4RShVBkq0j01FWS7RLQG1haRg=; b=DfEHRT7HE6xWMzaGZEGDEC+OaGPP7/MV1Vffga1hUHhF9JyCkc9UkJI2OlPITqWqDuxChU cEwpvmpvRPpG9g7P0Rpyq5O/BffY8WSxCkDbSCxL4EYrCtUvOAUX67XHO93+rGdDLpp191 U6bTkWrZ6qLy8XrCqHWQhcz+srAQMFoVW8PHYEQuZYncaF9BtdAe/ADMN+NeDlqkigZoWp g4smDTUwIIWUu01MRhunkDe9hA22O148Kdgw3EzUkZe32dVARp281TGK1IlY9KAg3KZxZM ZCfskMZfYyAe9gPPa9yDoRIFgnWN0pWdlXzYVZy6+1mBzcFnKy2zNKGRfJUsTQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1627020908; a=rsa-sha256; cv=none; b=TTLrJIFZbc0I+V8QKunlMXT/T6MqnlfzETXw2Xf9WFiYB1ksuXggGnfAEQl+4pqJvJc/+G ULok+sAskn+2w5qTCBb4UKjrkO90t4mXVdEXPKXEmbyAREfD/rA8kDuLfCRIqEbEqAF7zi BlDL8qXuhF1fJE8+CQahciXQXjNl9mJ7kkiGDPoKXQzQ19NQsnsjXfuFMLeBFg89tOIYQv 82qg5LnaUrh54DBLdiEBEoZTRshgHVYJRs4vMO05pUmGF8AaEAEA4i7lFWw4mN+cM05s6j chlvIBzzZNvpx5c8+0idOXEKEVFzEi9MQDK5VTEMTpGlN62fL0tdtkNa6OVgeA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=mgsn.dev header.s=key1 header.b=D0kqFsT0; dmarc=fail reason="SPF not aligned (relaxed)" header.from=mgsn.dev (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.32 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=mgsn.dev header.s=key1 header.b=D0kqFsT0; dmarc=fail reason="SPF not aligned (relaxed)" header.from=mgsn.dev (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: F397849AF X-Spam-Score: -1.32 X-Migadu-Scanner: scn0.migadu.com X-TUID: WF5scAJM5m1+ Hello, Thanks for the patches :) The fight against vendoring is eternal. I have a few suggestions: * Unvendoring or otherwise removing files from sources is typically done with a snippet in the origin rather than a patch, as it's much smaller and doesn't break when updating. It might look like (untested): (origin ... (modules '((guix build utils))) (snippet '(begin ;; Remove vendored dependencies (let ((unvendor '("click" "dotenv" "ruamel" "toml"))) (with-directory-excursion "dynaconf/vendor" (for-each delete-file-recursively unvendor)) (with-directory-excursion "dynaconf/vendor_src" (for-each delete-file-recursively unvendor)))))) You'll still have to have the edits to dynaconf as a patch, of course. * You've still included a python-box package despite none of the packages in your patch using it. * pep8-naming has released 12.0.0, and tests pass :) * Some of your patches no longer apply on master, and you should rebase them before sending a revised patchset. Consider using the `--base` option with format-patch, which helps git know what commit the patch is based on when applying. paul writes: > Hi Guixers :), > > I'm sending a patch series to add dynaconf. > > Thank you for your time, > > Giacomo Best, Sarah