From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 3dqXHHHEQGHTgQEAgWs5BA (envelope-from ) for ; Tue, 14 Sep 2021 17:49:05 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id KL2AF3HEQGH/PAAAbx9fmQ (envelope-from ) for ; Tue, 14 Sep 2021 15:49:05 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4D02ADA6C for ; Tue, 14 Sep 2021 17:49:04 +0200 (CEST) Received: from localhost ([::1]:48756 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mQAgB-0003sZ-B3 for larch@yhetil.org; Tue, 14 Sep 2021 11:49:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47832) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQ9l4-0000Sk-AU for guix-patches@gnu.org; Tue, 14 Sep 2021 10:50:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:38314) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mQ9l4-00009a-3h for guix-patches@gnu.org; Tue, 14 Sep 2021 10:50:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mQ9l3-0007tT-Vt for guix-patches@gnu.org; Tue, 14 Sep 2021 10:50:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50333] [PATCH] Fixed missing files in org-roam 2.1.0 Resent-From: zimoun Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 14 Sep 2021 14:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50333 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Adolfo De =?UTF-8?Q?Un=C3=A1nue?= Cc: 50333@debbugs.gnu.org Received: via spool by 50333-submit@debbugs.gnu.org id=B50333.163163094230249 (code B ref 50333); Tue, 14 Sep 2021 14:50:01 +0000 Received: (at 50333) by debbugs.gnu.org; 14 Sep 2021 14:49:02 +0000 Received: from localhost ([127.0.0.1]:49855 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mQ9k2-0007rU-8u for submit@debbugs.gnu.org; Tue, 14 Sep 2021 10:49:01 -0400 Received: from mail-wr1-f46.google.com ([209.85.221.46]:33535) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mQ9k0-0007r1-1I for 50333@debbugs.gnu.org; Tue, 14 Sep 2021 10:48:56 -0400 Received: by mail-wr1-f46.google.com with SMTP id t18so20721026wrb.0 for <50333@debbugs.gnu.org>; Tue, 14 Sep 2021 07:48:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=+1Aool0xJxy/IScvl37eT8YJ690ORf3c/Jl6INKQ3Ns=; b=oEVpkf7DJIIRX2Z6XEFQFcf6Tcd8QDJ/ZqAnoHZuG0EjUae9In/mmKyK52wnpc+Ct9 6yowLRz1KeVi1XfrfQzWUDIOhwFRCxQD0KT9Ntkvfv5jkXF883LdXMQUd4oMaWUHpoKt KFrtdOqNhLVt0J85Q1L7IWhX+IMujFeSnsRS/VLXRdBMehKJ1rUQNEVHEwpkfoEClyWe /e6HSVdGN9CWsgfukUAxfWj9YJPJ+biBh+imwG/TLkJVhSbonQWkd4ZaZjJ4GbMLpByO LW6A9+z+ciU6FFBF8/VQSH4/JuxxFOmheHJfQIW26LxYN4xz88t22or53NpdaCTwgvUl oaxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=+1Aool0xJxy/IScvl37eT8YJ690ORf3c/Jl6INKQ3Ns=; b=0v9wmWN8mVTlkVIFDUqIG2+Mi6cVqA1ByxeDAkWGh7epgxJNAg+T/QeNnVcJILzDFm +xWt/b646kO7SL3LES5kMZjr5YKb4BPj2YO6/SPWWu96nUJDKS+GVx8zViPthRImNeKO ok7gyKZh08biHQgclhRt/CO+Dv4tmOTKkbGLtRioOpHSgoIrnrVl4ykb4mYWZ021THMy l0rodLnhoZEXG8G/VmzwqYuzH4rbagc8nR7YIQIFI/H//u9e/jTE6o+TG3+by5yOfeH8 njYu6l4lEeSTjnZkrW7Drm78Levp7thbiV/Y+I8vQrhXMsY57xzt9CmsWBzwrPGuIvbQ CmEQ== X-Gm-Message-State: AOAM532aRWdI9SMYliDdZ/U+sCUnHtmPfnIGHu8/s6b2bznXsFq/GkRg 7KYkWfzmtHzEHApvF60iZyK3BRZpErlrEA== X-Google-Smtp-Source: ABdhPJyEn3KheBNVpA9M+AZN7g22GFgtHXSwRbChMl/GLMGZXvgkc96USavEYlh9G/sAa3qgeH+WLw== X-Received: by 2002:adf:e404:: with SMTP id g4mr19306518wrm.143.1631630929755; Tue, 14 Sep 2021 07:48:49 -0700 (PDT) Received: from lili (roam-nat-fw-prg-194-254-61-42.net.univ-paris-diderot.fr. [194.254.61.42]) by smtp.gmail.com with ESMTPSA id f5sm1333841wmb.47.2021.09.14.07.48.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Sep 2021 07:48:49 -0700 (PDT) From: zimoun References: <877dfzebfd.fsf@unanue.mx> <87v93icnst.fsf@unanue.mx> Date: Tue, 14 Sep 2021 14:26:45 +0200 In-Reply-To: <87v93icnst.fsf@unanue.mx> ("Adolfo De =?UTF-8?Q?Un=C3=A1nue?="'s message of "Thu, 02 Sep 2021 22:57:19 -0500") Message-ID: <86ilz3tkai.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1631634545; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=+1Aool0xJxy/IScvl37eT8YJ690ORf3c/Jl6INKQ3Ns=; b=gMERT2RfwXzvX7JLuqEB7YZhoJNm2YWY3vSszU2wryrwtUWMlVEYvTHEAtuRJAEzHarSKU aIXm9HQVjlTXaYEDs5OMOsJhTOsId7P75ICs0ZlZtJYNF511IsLMsqUpk31uv05pqw+s7b pCEnGTFRLtXKGQ3Wss4FpyeRc9QZNGjOaRaSCpKMxJFJKxSgt1ZVuN2MOjeVZWS/q41Dky HoBO/hiIpnt1WGKvOCtwUC/FHH+n0ynaFS/Pk5+134oRCj5dRI62Wd3AfAa2+KooO7n5NI MhWHJzGktHWt7Ut1vuCzMi58nu5gVB798eB4MPQPsd3a1RNz3cxEb6W5GPoIgA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1631634545; a=rsa-sha256; cv=none; b=E5zJnBF3t4v8LpHcRxD6/8un0RyUskYbo0QG5nfFZYXGr6v5quAC815aCRCS3n83VnBWYp W5RytJTeBod1G8OaBYRZrd9GDmGQ5LK4yXHrcyESEBaQU1YRnD9wO1oKm1zg5raKiG4HU+ tbvrHqo0DZEPUZQXncS1hhoYEfiaEr4U4GVpSnfih2q7oU83X3WSxpJ2kesUIPBy8Pr9HF 4xPx0BsOQnfWDm5UlOjQkI4xE4E+g/HYS5NoNDFPG0ptKr2pXVT71jBxSeQfgZZ7H49Rdd I8FrvPP+Yi791gHqMmsjUxKEDvGe/LrvK6iKu8sEAkGIwnvNM1RTKMEWTuxECg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=oEVpkf7D; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: 3.50 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=oEVpkf7D; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 4D02ADA6C X-Spam-Score: 3.50 X-Migadu-Scanner: scn1.migadu.com X-TUID: XWt9ZWD1QXVj Hi, You are asking in about this one. Well, I am not an expert and I am not an Emacs Roam user. On Thu, 02 Sep 2021 at 22:57, Adolfo De Un=C3=A1nue wrot= e: >>>From a99fa75c0f5d3025827d99c3ef6a2c71c85e0be5 Mon Sep 17 00:00:00 2001 > From: =3D?UTF-8?q?Adolfo=3D20De=3D20Un=3DC3=3DA1nue?=3D > Date: Thu, 2 Sep 2021 22:23:58 -0500 > Subject: [PATCH] Fixed missing files in org-roam v2.1.0 The commit message should be: --8<---------------cut here---------------start------------->8--- gnu: emacs-org-roam: Adding extensions. * guix/emacs-xyz.scm (emacs-org-roam)[arguments]: Add phases to install extensions. --8<---------------cut here---------------end--------------->8--- Or something along these lines. > --- > gnu/packages/emacs-xyz.scm | 94 +++++++++++++++++++++----------------- > 1 file changed, 53 insertions(+), 41 deletions(-) > > diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm > index 030809f5ac..431444c255 100644 > --- a/gnu/packages/emacs-xyz.scm > +++ b/gnu/packages/emacs-xyz.scm > @@ -103,6 +103,7 @@ > ;;; Copyright =C2=A9 2021 Matthew James Kraai > ;;; Copyright =C2=A9 2021 Noisytoot > ;;; Copyright =C2=A9 2021 Simon South > +;;; Copyright =C2=A9 2021 Nanounanue Since you submit with this name =E2=80=9CAdolfo De Un=C3=A1nue=E2=80=9C, th= e Copyright should be the same instead of a nick name. From my point of view, nickname as copyright holder should be avoided; if possible, obviously. :-) > + (let ((commit "f819720c510185af713522c592833ec9f2934251") Usually, the package uses tagged version instead of random commit. When it is not possible because upstream do not tag, it seems good to provide an explanation why the lasted tagged version cannot be used; explanations as a comment or in the cover letter. Another reason is because for instance it changes all the indentation and makes =E2=80=98git log/blame=E2=80=99 harder to investigate. > + (add-after 'install 'install-extensions > + (lambda* (#:key outputs #:allow-other-keys) > + (copy-recursively > + "extensions" > + (string-append (assoc-ref outputs "out") > + (string-append > + "/share/emacs/site-lisp/org-roam-" > + ,version))) > + #t)) Patch#50333 will install the extensions with =E2=80=9Cguix install emacs-org-roam=E2=80=9D. Instead the attempt of patch#50374 is to install = with =E2=80=9Cguix install emacs-org-roam-extensions=E2=80=9D. Well, I do not k= now if patch#50374 is correct, though. Because I am not an Org-Roam user, I do not have an opinion about this extensions. Maybe it is better to distribute them along the package emacs-org-roam or in a separate package, I do not know. WDYT? All the best, simon