From: Zhu Zihao <all_but_last@163.com>
To: 45307@debbugs.gnu.org
Subject: [bug#45307] [PATCH]: build-system/cargo: Use argument "--no-track" in "cargo install"
Date: Fri, 18 Dec 2020 10:27:39 +0800 [thread overview]
Message-ID: <86h7oj4zms.fsf@163.com> (raw)
[-- Attachment #1.1: Type: text/plain, Size: 335 bytes --]
After we update rust to rust-1.45, cargo install now create
.crates2.json instead of .crates.toml. So the hack we use in
c1cc0c4865a8bfff43c5c9bd6ae8dcadb061c8a0 doesn't work.
I checked the ArchLinux Rust packaging guideline and found that we
should use --no-track in "cargo install" to prevent cargo install these
files to prefix.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 255 bytes --]
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-build-system-cargo-Use-argument-no-track-in-cargo-in.patch --]
[-- Type: text/x-patch, Size: 1278 bytes --]
From fadf6149f998758c1d663d3dbe1c6fe8a85e5700 Mon Sep 17 00:00:00 2001
From: Zhu Zihao <all_but_last@163.com>
Date: Fri, 18 Dec 2020 10:13:48 +0800
Subject: [PATCH] build-system/cargo: Use argument "--no-track" in "cargo
install"
Prevent cargo install .crates.toml or .crates2.json to prefix.
* guix/build/cargo-build-system(install):
Add argument "--no-track" in "cargo install".
Remove stale hack.
---
guix/build/cargo-build-system.scm | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/guix/build/cargo-build-system.scm b/guix/build/cargo-build-system.scm
index c7beffc6e4..1d21b33895 100644
--- a/guix/build/cargo-build-system.scm
+++ b/guix/build/cargo-build-system.scm
@@ -183,13 +183,9 @@ directory = '" port)
;; otherwise cargo will raise an error.
(or skip-build?
(not (has-executable-target?))
- (invoke "cargo" "install" "--path" "." "--root" out
+ (invoke "cargo" "install" "--no-track" "--path" "." "--root" out
"--features" (string-join features)))
- ;; This is a file which we definitely don't need installed.
- (when (file-exists? (string-append out "/.crates.toml"))
- (delete-file (string-append out "/.crates.toml")))
-
#t))
(define %standard-phases
--
2.29.2
[-- Attachment #3: Type: text/plain, Size: 100 bytes --]
--
Retrieve my PGP public key:
gpg --recv-keys D47A9C8B2AE3905B563D9135BE42B352A9F6821F
Zihao
next reply other threads:[~2020-12-18 2:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-18 2:27 Zhu Zihao [this message]
[not found] ` <handler.45307.B.160825848714001.ack@debbugs.gnu.org>
2020-12-18 2:30 ` [bug#45307] Acknowledgement ([PATCH]: build-system/cargo: Use argument "--no-track" in "cargo install") Zhu Zihao
2020-12-31 9:50 ` Zhu Zihao
2020-12-31 12:41 ` bug#45307: [PATCH]: build-system/cargo: Use argument "--no-track" in "cargo install" Efraim Flashner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86h7oj4zms.fsf@163.com \
--to=all_but_last@163.com \
--cc=45307@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).