From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id wBhrOckRGWD6bAAA0tVLHw (envelope-from ) for ; Tue, 02 Feb 2021 08:48:09 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id gA8sNckRGWAXUgAAbx9fmQ (envelope-from ) for ; Tue, 02 Feb 2021 08:48:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8EC2F94042F for ; Tue, 2 Feb 2021 08:48:09 +0000 (UTC) Received: from localhost ([::1]:47200 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l6rM0-0005yW-IN for larch@yhetil.org; Tue, 02 Feb 2021 03:48:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58446) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l6rLu-0005yJ-9F for guix-patches@gnu.org; Tue, 02 Feb 2021 03:48:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:50694) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l6rLu-0008Em-1r for guix-patches@gnu.org; Tue, 02 Feb 2021 03:48:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l6rLu-0007lL-0H for guix-patches@gnu.org; Tue, 02 Feb 2021 03:48:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#45948] [PATCH 0/5] Improvements to the Automake SRFI 64 test driver. Resent-From: zimoun Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 02 Feb 2021 08:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45948 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer , Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 45948-done@debbugs.gnu.org id=D45948.161225562929766 (code D ref 45948); Tue, 02 Feb 2021 08:48:01 +0000 Received: (at 45948-done) by debbugs.gnu.org; 2 Feb 2021 08:47:09 +0000 Received: from localhost ([127.0.0.1]:34007 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l6rL2-0007k0-Rz for submit@debbugs.gnu.org; Tue, 02 Feb 2021 03:47:09 -0500 Received: from mail-wm1-f53.google.com ([209.85.128.53]:53720) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l6rL0-0007jC-Dk for 45948-done@debbugs.gnu.org; Tue, 02 Feb 2021 03:47:07 -0500 Received: by mail-wm1-f53.google.com with SMTP id j11so765072wmi.3 for <45948-done@debbugs.gnu.org>; Tue, 02 Feb 2021 00:47:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-transfer-encoding; bh=swxB/+mOKi0eGMldzxHBkvpGCKsBG2SSSuoSOVGbhqg=; b=dwKqTUEGpfSKvvrXxRbwjRqw7MQTwWwaiQcH7RMkgKlGBh0jd14lUOzJ/A1dDHHWhQ BwRxSDbmKsmuen9ow7Pq1es7ammys2aSLcHAxayXJqZwaMf9FJXMopHFcpo9vH2KI9uR GasPeIJqZLosO5F63YCfzYmcJHEpDqbiExnpfbk9nRSR3GVn9WdA3OuvnRwR1ZA4Q43q vKXKWJgV9iEkX2XCHTw9yPgn1etcXcgzUqD/jWQfWUAdGbCBjXHw1xemdF6nSR4hmwp8 NIzK6C0+NYSOv1vKOnExOkDoLz+M5kAdNZFYq+oVoUF7a2MFluUgXv+AtTPKtnZRxlLj sqKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=swxB/+mOKi0eGMldzxHBkvpGCKsBG2SSSuoSOVGbhqg=; b=ANq9fCbIDzYn1QrL32Bzmb5v3Kmqz7V0P3umj3EN18BcZ4LatqgD6acbC3DwBJ2ICw NfBe2u6hLnPULAYe61EFX15DyXwE8HH2sIhJTv7b8ocqijZNUupFmEvvDzjJZD6stBIU B/npIHHsQxLiIDnfN61sLdNwmPkij25ueCdb1TexYDD+iTmeK/6FePQ4uFOH87G4VoO0 POacHxsRgokTd+3UOU5iG3xkX74wNmb+ZmHF92CKCHa4oX1bnZqbK0h/3XeR0gwYue9d c1Es4r2MU2btQ0lUTjgEmUIgSRN/SJeeDLJwiq6PEpDB64N0qaU82hVoPhP6yLp2wpS4 Xh/w== X-Gm-Message-State: AOAM532TUh98g+aBVvUoxkw9tFscj7iC79WOFwAbKAvwE5/OO/w/rW2T Ar+NboI7Om18gcmQYoB1xPIZlrrSyr8= X-Google-Smtp-Source: ABdhPJzkIpFexEVYorS18RXPX7Z/UEL3TRS2BnYsTu4xFGUJ43C75dD2jHO0uBWvEBTbqsi1QOPeZg== X-Received: by 2002:a7b:cb86:: with SMTP id m6mr347357wmi.45.1612255620256; Tue, 02 Feb 2021 00:47:00 -0800 (PST) Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id r16sm9160935wrt.68.2021.02.02.00.46.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Feb 2021 00:46:59 -0800 (PST) From: zimoun In-Reply-To: <87h7mvqaw0.fsf@gmail.com> References: <20210118062501.27022-1-maxim.cournoyer@gmail.com> <20210118062501.27022-5-maxim.cournoyer@gmail.com> <87eei2p0qu.fsf_-_@gnu.org> <87lfc8sb8w.fsf@gmail.com> <87czxjh1os.fsf@inria.fr> <87h7mvqaw0.fsf@gmail.com> Date: Tue, 02 Feb 2021 09:36:11 +0100 Message-ID: <86h7mudfyc.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 45948-done@debbugs.gnu.org Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -1.26 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=dwKqTUEG; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 8EC2F94042F X-Spam-Score: -1.26 X-Migadu-Scanner: scn0.migadu.com X-TUID: ueSUtn1Q0f3e Hi, On Tue, 02 Feb 2021 at 00:47, Maxim Cournoyer w= rote: > $ export SCM_LOG_DRIVER_FLAGS=3D"--brief=3Dno --show-duration=3Dyes" > $ make check TESTS=3Dtests/packages.scm > > --8<---------------cut here---------------start------------->8--- > [...] > PASS: tests/packages.scm - fold-available-packages with/without cache [17= .121s] > PASS: tests/packages.scm - find-packages-by-name [0.000s] > PASS: tests/packages.scm - find-packages-by-name with version [0.000s] > PASS: tests/packages.scm - find-packages-by-name with cache [9.492s] > PASS: tests/packages.scm - find-packages-by-name + version, with cache [7= .412s] > [...] > PASS: tests/packages.scm - find-package-locations with cache [7.484s] > PASS: tests/packages.scm - specification->location [0.000s] > --8<---------------cut here---------------end--------------->8--- Cool! Thanks Maxim. I find it really better. :-) >>> We can also check the time the suspected slow test took: >>> >>> $ time make check TESTS=3Dtests/packages.scm >>> SCM_LOG_DRIVER_FLAGS=3D"--select=3D'fold-available-packages with/without >>> cache'" >>> [...] >>> PASS: tests/packages.scm - fold-available-packages with/without cache >> >> Ah ha! Turns out a large part of the time was due to the O(n=C2=B2) beh= avior >> of the various list operations (the list of packages is big enough!). >> Fixed in 73744725dd0a65cddaa9251f104f17ca27756479. Neat! Cool! Cheers, simon