From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id AaSQAkMaZ2BBGwAAgWs5BA (envelope-from ) for ; Fri, 02 Apr 2021 15:21:07 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id +ODlNkIaZ2BbEQAAbx9fmQ (envelope-from ) for ; Fri, 02 Apr 2021 13:21:06 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6DD3012BBD for ; Fri, 2 Apr 2021 15:21:06 +0200 (CEST) Received: from localhost ([::1]:45416 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lSJjV-0001pG-2Z for larch@yhetil.org; Fri, 02 Apr 2021 09:21:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47158) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lSJjS-0001p7-2b for guix-patches@gnu.org; Fri, 02 Apr 2021 09:21:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:47884) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lSJjR-0007ko-Rh for guix-patches@gnu.org; Fri, 02 Apr 2021 09:21:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lSJjR-0002bf-O0 for guix-patches@gnu.org; Fri, 02 Apr 2021 09:21:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47282] [PATCH v2 13/13] gnu: Add node-lts. Resent-From: Jelle Licht Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 02 Apr 2021 13:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47282 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Efraim Flashner , Timothy Sample Cc: 47282@debbugs.gnu.org Received: via spool by 47282-submit@debbugs.gnu.org id=B47282.16173696289956 (code B ref 47282); Fri, 02 Apr 2021 13:21:01 +0000 Received: (at 47282) by debbugs.gnu.org; 2 Apr 2021 13:20:28 +0000 Received: from localhost ([127.0.0.1]:59430 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lSJiu-0002aW-1g for submit@debbugs.gnu.org; Fri, 02 Apr 2021 09:20:28 -0400 Received: from mail1.fsfe.org ([217.69.89.151]:55390) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lSJir-0002aN-U0 for 47282@debbugs.gnu.org; Fri, 02 Apr 2021 09:20:26 -0400 From: Jelle Licht In-Reply-To: References: <87k0pprz6n.fsf@ngyro.com> <20210330052743.575-13-samplet@ngyro.com> Date: Fri, 02 Apr 2021 15:20:24 +0200 Message-ID: <86h7ko3js7.fsf@fsfe.org> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1617369666; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=+hk1lgM2NdJY+T1IE9Ln/BBnukJcugo/Dl9XXYZUrfY=; b=XQvaWNDBp0czfXv/hzYk/eXLjvBSZDgAPuRZik8lwBNCOmOAvodtxyNXygJhjmlFaZ7qBn Kl5GD/iCqjKVXc1aRA0rB9rVQA+fylhQCqA0OO3Lu2cWdazY/i7vQOnu3tY4sNpGsH/aRO fXmuNiWxUImu5ELn0GsPQKrszwavlweCW07z6OJAOTwr/7OkMZmc0p6WV5BA2C71Wbim2F xafK6gf3FMOPR02GzPFxIq2LcThXUqrW9ss6hzCVdjTgPDnw4TuZv4F+cQ924nibpycN+5 oJdKTjH2fv6tPVP/KOYtuQiNW8srAZUQwGsbFYK2SN/SclDK+/u+tcMV0GAB9Q== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1617369666; a=rsa-sha256; cv=none; b=Wd0Hq04HPxs+2z03kHbTJEh0CZiA40HErplDvLl0ycgnF7hvPQAsEWE+KHaKzDLGbn4dVV WZTaPgtfUhVLmjTYe4gKca7o83KxaxARa8q8PHpvUWUwpLRdIQMSUcZ3MsYy8WxWSdq60U Sr3ttPV189Od1Vj4gI4sMc2RA9lAQwBu+m3VfDf6ltUFypI1WFSyqGWJEkBFiRjjWS9DYi FNlD3QlQ5csDvGIEDB6afgU8CQfBVPAR0TlDqLMWMvltSAHoBry7C5hmQh1LPu+8wuwMsB 9lbCf6Cl6JVLZPOdlrFOx5r0GVmfo+/hn1E5TLO5HDGsT8oQqWVW09IMsHCjdQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=fsfe.org (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -0.83 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=fsfe.org (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 6DD3012BBD X-Spam-Score: -0.83 X-Migadu-Scanner: scn0.migadu.com X-TUID: fuwpck2F8Ox0 Efraim Flashner writes: > On Tue, Mar 30, 2021 at 01:27:43AM -0400, Timothy Sample wrote: >> + (arguments >> + (substitute-keyword-arguments (package-arguments node) >> + ((#:configure-flags configure-flags) >> + ''("--shared-cares" >> + "--shared-libuv" >> + "--shared-nghttp2" >> + "--shared-openssl" >> + "--shared-zlib" >> + "--shared-brotli" >> + "--with-intl=system-icu")) >> + ((#:phases phases) >> + `(modify-phases ,phases >> + (replace 'configure >> + ;; Node's configure script is actually a python script, so we can't >> + ;; run it with bash. >> + (lambda* (#:key outputs (configure-flags '()) inputs >> + #:allow-other-keys) >> + (let* ((prefix (assoc-ref outputs "out")) >> + (flags (cons (string-append "--prefix=" prefix) >> + configure-flags))) >> + (format #t "build directory: ~s~%" (getcwd)) >> + (format #t "configure flags: ~s~%" flags) >> + ;; Node's configure script expects the CC environment variable to >> + ;; be set. >> + (setenv "CC" (string-append (assoc-ref inputs "gcc") "/bin/gcc")) > > again cc-for-target Ack. >> [snip] >> + ;; FIXME: These tests fail on armhf-linux: >> + ;; https://github.com/nodejs/node/issues/31970 >> + ,@(if (string-prefix? "arm" (%current-system)) > > This could probably be changed to ,@(when (target-arm32?) I changed it to ,@(if (target-arm32?), as otherwise the #f-branch spliced #unspecified into the list.