From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 6MUJB+651WFpXwAAgWs5BA (envelope-from ) for ; Wed, 05 Jan 2022 16:31:58 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id mAZxO+251WHVYgEAG6o9tA (envelope-from ) for ; Wed, 05 Jan 2022 16:31:57 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 94C1C37F8D for ; Wed, 5 Jan 2022 16:31:57 +0100 (CET) Received: from localhost ([::1]:52234 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n58Ga-0002TM-Of for larch@yhetil.org; Wed, 05 Jan 2022 10:31:56 -0500 Received: from eggs.gnu.org ([209.51.188.92]:42170) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n57yN-00033w-R9 for guix-patches@gnu.org; Wed, 05 Jan 2022 10:13:07 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:58122) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n57yI-0004Yw-6f for guix-patches@gnu.org; Wed, 05 Jan 2022 10:13:07 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n57yH-0006ex-Q0 for guix-patches@gnu.org; Wed, 05 Jan 2022 10:13:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#50072] [PATCH WIP 0/4] Add upstream updater for git-fetch origins. Resent-From: zimoun Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 05 Jan 2022 15:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50072 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: Sarah Morgensen , 50072@debbugs.gnu.org Received: via spool by 50072-submit@debbugs.gnu.org id=B50072.164139555825569 (code B ref 50072); Wed, 05 Jan 2022 15:13:01 +0000 Received: (at 50072) by debbugs.gnu.org; 5 Jan 2022 15:12:38 +0000 Received: from localhost ([127.0.0.1]:41435 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n57xu-0006eK-JI for submit@debbugs.gnu.org; Wed, 05 Jan 2022 10:12:38 -0500 Received: from mail-wm1-f51.google.com ([209.85.128.51]:54121) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n57xs-0006e5-OM for 50072@debbugs.gnu.org; Wed, 05 Jan 2022 10:12:37 -0500 Received: by mail-wm1-f51.google.com with SMTP id l4so25722271wmq.3 for <50072@debbugs.gnu.org>; Wed, 05 Jan 2022 07:12:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-transfer-encoding; bh=zvbL2elneLSMM9V7umWDRwsdoO+uopfw4yZr+oLVZ9s=; b=SE5sncoxvLfm/R3WUl3u7UIEPw1o1XdWdEd7V/bbw3t2tmKGq044kcsNx3XnmLxDrZ +NRsn4kCk2BbIXw3ZTXTFRmS5WM2rsDUftzfMgwR54Idjunq7WNmtFrDYVWz3zj6V4oK fJDpEgL23XPCA7MkLc576B4nz8Ck1EVJd921Yl252ushTKMoiKaMv+8lJ8akGyFTl8n1 8agKCpKGlJBvadIp5zVc7ihJrn3PIAi119k4mEtGKdEVSiGFjTtvyLydY9uDJ8qchWM8 PGIUveV9BBXUFqYF2S8Xm+NFa4AEjMnFPsy+LV/E9IYuexy7q/7dwpkR8bDtYQocK1cK pxQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=zvbL2elneLSMM9V7umWDRwsdoO+uopfw4yZr+oLVZ9s=; b=dvpeq0e1T1FQ1EOsDmQyLUgk592wmalaAYjbqE+nK0Tx9yYDbIcfhfB5RMFZh1Ooaa aVKVCiBnryWzMavEX/Qk+xgX/cRx0yD3BVRgasQKGi1I/o5Ybwcn/5IQd/aahlhG++m+ StV7+mm3brUlrTturgVib4A+VGPNXrk5Mo4PU8EFC6SAQ0hj8nqIjTRVrgcu0AEX6Xhw ldCxoY12RH2FJeaelzNWPLTQRsPLq0YH4NkQhlvW+RtPHLDQXjdgjfkg4fw0oPdfNxUf rQrTDmuLAtdQ1osl9Xkzwn++kNXwATss4+UHMyJwNDE9Nv2PMvqtITEUh1M7AsPx8dW1 Yv3Q== X-Gm-Message-State: AOAM5308kuFGMv4VJV3MFrGRYSW5B2v2btjrmvI8Ur95Lk+wRRMEtoOE WwrOoMAMKUJ9OGEnRVNaoxU= X-Google-Smtp-Source: ABdhPJwg/GRWQjAwdfzqYDTkFgoW2qtUOEs8VEK0bpxR6ZLin6yIaTZtS1jp3Ed3liy+p4O0wjOwvQ== X-Received: by 2002:a05:600c:a47:: with SMTP id c7mr3284727wmq.23.1641395550735; Wed, 05 Jan 2022 07:12:30 -0800 (PST) Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id l16sm46653881wrx.117.2022.01.05.07.12.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jan 2022 07:12:30 -0800 (PST) From: zimoun In-Reply-To: <6fcbe52781b0678ea44db9beea2e1bd3f404b840.camel@telenet.be> References: <20220104200643.43374-1-maximedevos@telenet.be> <20220104200643.43374-2-maximedevos@telenet.be> <867dbfcf9n.fsf_-_@gmail.com> <52e7be94d926aa06c2a0132090e8c212381e7900.camel@telenet.be> <86y23u768v.fsf@gmail.com> <86pmp6730h.fsf@gmail.com> <6fcbe52781b0678ea44db9beea2e1bd3f404b840.camel@telenet.be> Date: Wed, 05 Jan 2022 16:08:54 +0100 Message-ID: <86h7ai6wzd.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1641396717; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=zvbL2elneLSMM9V7umWDRwsdoO+uopfw4yZr+oLVZ9s=; b=hQaPfBhdWGNK1dX6ws0csgJpFEkCQD8TcJ2gSgCm/aF5gmXwo2Lp7e1alrxZ09GVzLWIsB sLSA4Szj9TclP91B+NutfuYbY0gS3KgK6xW67ZNDVlC4q3HrZEYOLlHjmaOIQy0QW59t1a 4tb25x9B2bFJZRyZV1c3s/cchpyI9nDw9B52Eu3lV3aBD3zlAVap99y8EqMMS5IjEhYTSL fn6uLrORV7u4a7G8wyvsTOuwu4S+6rkUt4ynwOb/Tnqwoayv225Wy4puNrqlxWx0PeZDE1 6agNcTj0XysKkOuYXavq38FmsQyrflxPzyr9kzu77olrMTI+lYv9XfSmeezcBQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1641396717; a=rsa-sha256; cv=none; b=lpY6PMrCuQPylpvg00rJOEfQFw1+GfMcCqe7R6rUmhMhk2VLEWpv5Bof6+E9pyUFl4FO9U MbfjdZWA7NX+HY3Tr9EWj18CJh68XHBcpcOo+QbTbXaZoHllMiZQc+QnFsgQwiUzVQqChD QJnZQCWhWNm9xvhVF5gBMXqD0E9ecljdg3enQYTlukRCwl/xXhWoz8nbe8+n/BUKEFV3x2 l7mYxXB6FanYkTTq3aFh2IGxG4fVZYWX7qHJFSv4pTHnBIeB3ssZ5MhCPDZRmjVOMoByuv FDLkVtrqgGJkOK7dH8O65NQg2Uq16dcHr2PHVl9RmVfc6ILXaIeJE9CiCfFKmQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=SE5sncox; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.10 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=SE5sncox; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 94C1C37F8D X-Spam-Score: -4.10 X-Migadu-Scanner: scn0.migadu.com X-TUID: hy7A7jWJZRHV Hi Maxime, On Wed, 05 Jan 2022 at 14:06, Maxime Devos wrote: > A low-level argument like #:nar-hash? #true/#false would make file- > hash* much more complicated: this patch series uses file-hash* to > compute the hash for 'origin' records, and the documentation of > 'origin' doesn't mention 'nar' anywhere and if I search for 'nar hash' > in the manual, I find zero results. I agree, it was my point #1. :-) > Instead, file-hash* talks about directories, regular files, recursion > and claims that the default value of #:recursive? usually does the > right thing, so I don't have to look up any complicated terminology > to figure out how to use file-hash* to compute hashes for 'origin' > records. I also agree, it was my point #3. :-) > And in the rare situation where file-hash* doesn't do the right thing, > the documentation tells me I can set #:recursive? #true/#false. Yes. >> Just, to be sure, I am proposing: >>=20 >> =C2=A01) It is v4 and ready, I guess. About =E2=80=99auto=E2=80=99, I c= ould have waken up >> =C2=A0earlier. :-) And it can be still improved later as you are saying = in >> =C2=A0the other answer. So, we are done, right? > > I think so, yes, except for a docstring change I'll send as a v5. > I'm also out of bikeshed paint. > Anway, keep in mind that I'm not a committer. I am not either. If I had this power, I would have already pushed your v4 with the docstring reword. :-) >> =C2=A02) From my point of view, =E2=80=99#:recursive?=E2=80=99 needs to = be adapted in >> =C2=A0agreement with the discussion [1], quoting Ludo: [...] >> =C2=A0=C2=A0=C2=A0And I do not have a strong opinion. Just a naive rema= rk. [...] > Possibly some name like > #:treat-it-as-a-directory-or-an-executable-file-or-a-symlink-and- > compute-the-alternative-hash-even-if-it-is-regular? > would be clearer and technically more accurate than #:recursive?, but > that's a bit of a mouthful. I trust you, I do not have a strong opinion. I was just a naive remark. >> =C2=A03) Whatever the keyword for the current v4 =E2=80=99#:recursive?= =E2=80=99 is picked, I >> =C2=A0=C2=A0still find the current docstring wording unclear. In fact, = reading >> =C2=A0=C2=A0the code is more helpful. :-) I am just proposing a reword w= hich >> =C2=A0=C2=A0appears to me clearer than the current v4 one. Maybe, I am = missing >> =C2=A0=C2=A0the obvious. Or maybe this proposed rewording is not cleare= r. :-) > > I've reworded it a bit; it falsely claimed that the nar hash was always > computed when recursive? is 'auto' (even if FILE is a regular file). It > also mentions executable files and SELECT? now. Thank you for your patient work. Cheers, simon