unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: zimoun <zimon.toutoune@gmail.com>
To: aecepoglu <aecepoglu@fastmail.fm>, 45762@debbugs.gnu.org
Subject: [bug#45762] [PATCH] ocaml: Add ocaml-down and ocaml-ocp-index
Date: Mon, 11 Jan 2021 15:57:45 +0100	[thread overview]
Message-ID: <86ft37seqe.fsf@gmail.com> (raw)
In-Reply-To: <20210110104915.2t6u4atuikypepfw@minitower>

Hi,

Thanks for the patch.

On Sun, 10 Jan 2021 at 13:49, aecepoglu <aecepoglu@fastmail.fm> wrote:

> +(define-public ocaml-down
> +  (package

[...]

> +(define-public ocaml-ocp-indent
> +  (package

[...]

> +(define-public ocaml-ocp-index
> +  (package

Usually, it is one commit per package.  Could you spit this patch into 3
patches?


All the best,
simon




  reply	other threads:[~2021-01-11 15:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-10 10:49 [bug#45762] [PATCH] ocaml: Add ocaml-down and ocaml-ocp-index aecepoglu
2021-01-11 14:57 ` zimoun [this message]
2021-01-11 15:15 ` Julien Lepiller
2021-01-11 20:55 ` [bug#45762] [PATCH 1/3] ocaml: Add ocaml-ocp-indent * gnu/packages/ocaml.scm (ocaml-ocp-indent): New variable aecepoglu
2021-01-11 20:55 ` [bug#45762] [PATCH 2/3] ocaml: Add ocaml-ocp-index * gnu/packages/ocaml.scm (ocaml-ocp-index): " aecepoglu
2021-01-11 20:56 ` [bug#45762] [PATCH 3/3] ocaml: Add ocaml-down * gnu/packages/ocaml.scm (ocaml-down): " aecepoglu
2021-01-12 14:10 ` bug#45762: [PATCH] ocaml: Add ocaml-down and ocaml-ocp-index Julien Lepiller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86ft37seqe.fsf@gmail.com \
    --to=zimon.toutoune@gmail.com \
    --cc=45762@debbugs.gnu.org \
    --cc=aecepoglu@fastmail.fm \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).