From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id EI0vH7QEdmBKgAAAgWs5BA (envelope-from ) for ; Tue, 13 Apr 2021 22:53:08 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id yE0hGbQEdmATdwAA1q6Kng (envelope-from ) for ; Tue, 13 Apr 2021 20:53:08 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DA7181B209 for ; Tue, 13 Apr 2021 22:53:06 +0200 (CEST) Received: from localhost ([::1]:39522 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lWQ1x-0006Ts-Uy for larch@yhetil.org; Tue, 13 Apr 2021 16:53:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47440) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lWQ1t-0006Ti-W1 for guix-patches@gnu.org; Tue, 13 Apr 2021 16:53:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:49408) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lWQ1t-0003vb-O3 for guix-patches@gnu.org; Tue, 13 Apr 2021 16:53:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lWQ1t-0002uC-J4 for guix-patches@gnu.org; Tue, 13 Apr 2021 16:53:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47593] [PATCH 3/6] gnu: python-xyz: Add python-uqbar. Resent-From: Bonface Munyoki K. Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 13 Apr 2021 20:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47593 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Efraim Flashner Cc: 47593@debbugs.gnu.org, jgart@dismail.de Received: via spool by 47593-submit@debbugs.gnu.org id=B47593.161834715511132 (code B ref 47593); Tue, 13 Apr 2021 20:53:01 +0000 Received: (at 47593) by debbugs.gnu.org; 13 Apr 2021 20:52:35 +0000 Received: from localhost ([127.0.0.1]:60954 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lWQ1Q-0002tR-0E for submit@debbugs.gnu.org; Tue, 13 Apr 2021 16:52:35 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:58185) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lWQ1N-0002tC-K4 for 47593@debbugs.gnu.org; Tue, 13 Apr 2021 16:52:30 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 342CF5C018B; Tue, 13 Apr 2021 16:52:24 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Tue, 13 Apr 2021 16:52:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= bonfacemunyoki.com; h=from:to:cc:subject:references:date :in-reply-to:message-id:mime-version:content-type; s=fm1; bh=t7a Xg08lIY4Wg07+BY9Lq+d1oLSVf8lfaetjize+IGw=; b=hUXB0doL2ozbJeK+ZsM RVVhXkaz7l2HvmRzQMQ/0nVLljGIE3Znt9scLYeO695/znAua+Wk589BS41SecZ2 OVod0Z6aQK5tyToga6LtPeI9oQmK2ajL7o8qqqWErYN3fDZgbxxPerVLaNGvEU0p gyMX4QJyekCisPtTMs9ekoxYz3MhddU8L3+8tcwKOCIk7bI/dn/TcAbZLP1oYfjx PjNnZCZ/B0ZTpgX+yhLjFlLvkeS0+/hp+w66qq1FaoXk8d+dkCoHRDpMRQwl7MPM xshO+CQwI2SZOESsSXwDs0YOJVCMF5FbS+0UXG9+Sv8ytwg1JEucmhSWSDRZDQjb ICA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=t7aXg0 8lIY4Wg07+BY9Lq+d1oLSVf8lfaetjize+IGw=; b=Whg6k2/qsGX9FedoE+3YCj GLmv4VEaBvLUVLkZ+TsZFMuXtp7auhraLXV/pypiVXdUsocL8Y1qfKy1U8T38VJ5 u3RcqwbQ+Pn3ZaRjfYkA/RARJkU+E7rigKBx2yYXl90UCEYeVGHJMOrNK5DR1dv6 3mfRYlLibclypzt7mAD36Uw6bjGiJUDKTmKHvJNfF53aFnZuoiHW7uSor5GNRJ9N yD07mXKM79k62s0lnCioqWB/8H06uS/puikbw2CGT7t9VIUra72FJciXhG8HZTp6 gv04/FybAZMUOOp6UnYRne+fSDX+AYc6MU1CQIA6/DfASPxhd/xd2A/rfJgJOBPw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudekledgudehhecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufhffjgfkfgggtgesghdtreertdertdenucfhrhhomhepuehonhhf rggtvgcuofhunhihohhkihcumfdruceomhgvsegsohhnfhgrtggvmhhunhihohhkihdrtg homheqnecuggftrfgrthhtvghrnhepteffheefvdelgfefvefgvdehjeegudegtdegjedt hfdthfefgedvtdfghfekvddvnecuffhomhgrihhnpehgihhthhhusgdrtghomhdpuhhpsg hoohhktghluhgsrdgtohhmnecukfhppeeguddrkedtrdejvddrheefnecuvehluhhsthgv rhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgvsegsohhnfhgrtggvmh hunhihohhkihdrtghomh X-ME-Proxy: Received: from susa (unknown [41.80.72.53]) by mail.messagingengine.com (Postfix) with ESMTPA id 6FC9A108005F; Tue, 13 Apr 2021 16:52:21 -0400 (EDT) From: Bonface Munyoki K. References: <20210404122005.33127-1-me@bonfacemunyoki.com> <20210404122005.33127-4-me@bonfacemunyoki.com> Date: Tue, 13 Apr 2021 23:52:15 +0300 In-Reply-To: (Efraim Flashner's message of "Tue, 13 Apr 2021 16:14:28 +0300") Message-ID: <86fsztoqkg.fsf@bonfacemunyoki.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1618347188; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=t7aXg08lIY4Wg07+BY9Lq+d1oLSVf8lfaetjize+IGw=; b=rvVSIr8NiT0zcUZROVwwHh79N+JQxr6IuuJeFpobZ60qKScYlHLJEuJGy69hur22xx4GZ7 kt0V71pkIB9EILh/aLOK3fUhK7hIhOoRtvOQOPsm7t3u69c4fX6+gJCsBkAnyYaUb0GpRH 2S8tCC7CIFYWoRaoIlg704Surd7QVanDGPLD4E5JFNQ11wwP8MLuIMrfutShNPECKKihTk 0vVW8fMvXnTVP+LlEvm68Kbj0Sycqlkv9J40R6o2Ag4e8ZGonroMjTRd3UKxaRuYBgNnnK cTAfbdMZ/rVhKw0OLdyE96naH/k4STIqghb/rsZ7qF07Y0ayvYSNM/giEJkY7g== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1618347188; a=rsa-sha256; cv=none; b=aNC1ywPGiCZBW9+d1jfovB9lzN1KwTVW8XcyIyQHlzXrQo2QA9lr5GG1klCK5oIVBeZhyi 8jxkaK6mEgDuegpfyg7SZDrzzyS6+lT6b0IgkRYFLrM0M8RzJ+kxF7VhWHK0sXMs6JcIMW U5gDITjdp0HUERl1MPXwu8OiJTb7qk99VuzmmGkXlaL8P277VhxOUNjDNG8ysy+sWyOCA6 d4vqUCWdpqe1vzuJNOpQTgUzB+yNChYKQY03faSWDYSnE5KlDFbBy7Vy9jaWR9FtQ3nrbj 7qTqGVgsetiqofHOP7yftyKU+hHf51nhfQiBy+YspD7673mDBKqzAFzYtjjmVA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=bonfacemunyoki.com header.s=fm1 header.b=hUXB0doL; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm2 header.b="Whg6k2/q"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: 0.46 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=bonfacemunyoki.com header.s=fm1 header.b=hUXB0doL; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm2 header.b="Whg6k2/q"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: DA7181B209 X-Spam-Score: 0.46 X-Migadu-Scanner: scn0.migadu.com X-TUID: rS8YsNG2YTqi --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Efraim Flashner writes: > I haven't tried building this package yet. The sphinx packages are in > sphinx.scm and the graphviz packages are in graphviz.scm. I think I > would put it in graphviz. > Now that you've pointed it out, I see it! That makes sense. [...] > guix lint should've caught this. I seem to have skipped doing this. I need to find a way to integrating "guix lint" to my Emacs workflow since I seem to always somehow forget to do this. > If the pypi version from 'guix import > ppyi uqbar' doesn't work for building then you should use git-fetch to > download the source. The github archive URLs tend to get regenerated > from time to time. I went with the GitHub version since the pypi version doesn't have tests. So in such cases, is it still preferable to use the pypi version? >> + (sha256 >> + (base32 >> + "02kfvwh94ca0y3hsfrc071ga3g3vqflhyv4w4hif34dyj2skvpa8")))) >> + (build-system python-build-system) >> + (arguments >> + `(#:phases >> + (modify-phases %standard-phases >> + (add-after 'unpack 'patch >> + (lambda _ >> + (substitute* "setup.py" >> + ;; Latest versions of sphink-rtd-theme require npm to bu= ild. >> + (("sphinx-rtd-theme >=3D 0.4.0") "sphinx-rtd-theme >=3D = 0.2.4") >> + (("black =3D=3D 19.10b0") "black >=3D 19.10b0")) >> + #t)) >> + (replace 'check >> + (lambda _ >> + (invoke "python" "-m" "pytest" "tests") > > We want the ability to skip the tests, so this should be > (lambda* (#:key tests? #:allow-other-keys) > (when tests? > (invoke ... > Never knew this! Learnt something new. Thanks! >> + #t))))) >> + (propagated-inputs >> + `(("graphviz" ,graphviz) > > Is it possible to substitute the actual calls to the graphviz binaries > in the package? Not really. However... > We don't want to have to propagate non-python packages. > ... We could add the graphviz to native inputs since it's only required at build-time when running one of the tests. >> + ("python-black" ,python-black) >> + ("python-sphinx" ,python-sphinx) >> + ("python-sphinx-rtd-theme" >> + ,python-sphinx-rtd-theme) >> + ("python-unidecode" ,python-unidecode))) >> + (native-inputs >> + `(("python-flake8" ,python-flake8) >> + ("python-isort" ,python-isort) >> + ("python-mypy" ,python-mypy) >> + ("python-pytest" ,python-pytest) >> + ("python-pytest-cov" ,python-pytest-cov))) >> + (home-page >> + "https://github.com/josiah-wolf-oberholtzer/uqbar") >> + (synopsis >> + "Tools for building documentation with Sphinx, Graphviz and LaTeX") >> + (description >> + "Tools for building documentation with Sphinx, Graphviz and LaTeX") > > This should be a full sentence. > Noted :) >> + (license license:expat))) >> --=20 >> 2.31.0 >>=20 >>=20 >>=20 >>=20 =2D-=20 Bonface M. K. D4F09EB110177E03C28E2FE1F5BBAE1E0392253F Humble GNU Emacs User / Bearer of scheme-y parens Curator: / Twitter: @BonfaceKilz --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJKBAEBCAA0FiEE1PCesRAXfgPCji/h9buuHgOSJT8FAmB2BIIWHG1lQGJvbmZh Y2VtdW55b2tpLmNvbQAKCRD1u64eA5IlP8X6EACNjfdonLqPSZdzDsBT5Yh/bUUG PJ+QH/7OZm5NjpkVCGfBiUkgBK8OwFyErdnkGmrA2wnAvscqTtBmd5yYb2Vqcpzn 7u+bHTiJyV6xuowYhZInUDPAeXVaI0pGP/lyD0GqCObh/YeA7j9i+/rg10pxGpHN Azee1CNucODmpLw6hKKkXR531+XSBI+lTWBnefLHOx9gdZsxPeBWn28d+oukult5 lC4ZxoGzNfJyyxYPUGLuQwMLOWapJtsJugeLkQybloDtS0NNn1xFa12TTzX+sDlU XJCoLuYyU5OTg1HFiI2E/g7yfsVdphfACmRQitH7Tk9iAuaFTbfqiN5cCfsHIxV3 QigZYkI9pX3Dansyg833h6yAv9eRkQfSVFWa1vX+QtyyxljYDbUMN8aGxs1JvTnP PCsaScwqO7sdeM/TQH5x67+59idoPFA3CTvKoanQVRo9bq9u2yFjW0M7zX0gM9MJ +sQBBIS2cYRkFqOR/Ff6hIUe8iZ18VN6B8pxYGQ6Qn6SNjVwLW88B2E930q/ILrg B107cTASGGNmHP+S0cSQ4m024xliBWAO9/h6mI4JU3XM20YkgtN9FYrRNJs/mTnI KXmnRg3nYoyh/rYtpYFsUlMxv8CC0fnBih9bZtRE7WKdQBYZ4AVw7Rvl+TKLNRcV pSwIoZ8UrPd1Um9qeg== =9OTc -----END PGP SIGNATURE----- --=-=-=--