From: zimoun <zimon.toutoune@gmail.com>
To: "Jean-Baptiste Volatier" <jbv@pm.me>,
"Nicolò Balzarotti" <anothersms@gmail.com>
Cc: 48325@debbugs.gnu.org
Subject: [bug#48325] julia-1.6 guix
Date: Wed, 12 May 2021 10:43:39 +0200 [thread overview]
Message-ID: <86fsysibpg.fsf@gmail.com> (raw)
In-Reply-To: <H2qZARtXUCbGTx5BAAi-uxz73f7m7nwkovZHcIRc6pqFZJwkT74htl1X73teqI0DKbCwCakB5r7ZkP_grXVx2w==@pm.me>
Hi,
On Tue, 11 May 2021 at 11:38, Jean-Baptiste Volatier <jbv@pm.me> wrote:
> I splitted the patch in 5. If it is not possible to update pcre2, we only
> need to disable a couple of tests.
Well, 1 tests are failing, if I am correct. However, I am not sure it
is an option to remove this dependency. The package utf8proc leads also
to a big rebuild, for instance ’subversion’ which implies a lot. :-)
I have not finished yet to test and I should send a patch set today or
tomorrow…
> zimoun <zimon.toutoune@gmail.com> writes:
>> I am not convinced by this move of patches from ’source’ to ’phases’.
>> My understanding about the usual way is to let the patch in the source
>> field. Is this move motivated by something special?
>
> Yes. Some of the patches need to be applied with the "-p1" flag some with
> "-p2". In the source field it is not possible to do so. So I would
> need to modify beforehand the "p2" patches for example, and I could not
> think of a nice way to do that without including the patches directly
> in gnu/packages/patches which does not seem like a nice option.
> And since all these patches are in julia source, I thought it was
> nicer this way.
…because I am not clear with this, yet.
>>> + (link "zlib" "usr/lib/julia/" "libz\\.so")
>
>> Does this fix
>>
>> <http://issues.guix.gnu.org/48238>
>
>> ? If yes, cool and thank you! :-) So it should be mentioned in the
>> commit message, something like:
>
> No it does not. Reason for this is that the install target of the
> makefile copies a bunch of libraries from the build directory
> to the install directory. I guess "normally" you rely on the makefile
> to also build these libraries for you. In our case many libraries are
> missing in this folder at the end of the build target
> so I create the symlinks so the install target works
> and also julia can later on find the libraries.
> For some reason utf8proc and libLLVM-11 need to be symlinked directly
> in the install directory, this is done in the next phase.
Thanks for the explanations. Let discuss that in the aforementioned
bug#48238. :-)
>>> + ("nss-certs" ,nss-certs) ; required to precompile
>
>> Hum? Is it really necessary?
>
> I think it is necessary for some of the tests. So I moved it to
> native-inputs is that correct ?
Yes, that’s my understanding.
Cheers,
simon
next prev parent reply other threads:[~2021-05-12 8:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Vkhua8Jivnfp9XkjO-1XFnilmUhHzpbQgvDq90cIwAEuQrlJWk2z3RXMrvh8_6jf5qMeNKyKIizXjeoLZomFBg==@pm.me>
[not found] ` <87bl9xqx5c.fsf@guixSD.i-did-not-set--mail-host-address--so-tickle-me>
[not found] ` <hk3Y4V9gjJY5o0stStMA9pP3H3OEcNP9-Sr1cAj6aEpTlsqK-wjNq6qIsu4939joF7uCxaTt_mp0ZZGATif8WQ==@pm.me>
[not found] ` <bHwSuC9WPaejmL-KWmk5RJk7IR9pQdqrFnvLkGE8ClBZF420yLdR0bymVXhAJHumFlBNcHmwn7AjjAofIbDh2A==@pm.me>
[not found] ` <FOr3K1_g6fyPlpTTzTRaYRLxXE6iqm-CsT0GqISHU5wmcXuj8wtB-md5hsLGGCgLUOPxLnjLmmkaYlk4BWGUGw==@pm.me>
[not found] ` <87pmxzfth8.fsf@guixSD.i-did-not-set--mail-host-address--so-tickle-me>
2021-05-10 7:07 ` [bug#48325] julia-1.6 guix Nicolò Balzarotti
2021-05-10 11:29 ` Jean-Baptiste Volatier via Guix-patches via
2021-05-11 0:07 ` zimoun
2021-05-11 9:18 ` Nicolò Balzarotti
2021-05-11 9:53 ` Nicolò Balzarotti
2021-05-11 9:55 ` zimoun
2021-05-11 10:18 ` Nicolò Balzarotti
2021-05-11 11:38 ` Jean-Baptiste Volatier via Guix-patches via
2021-05-12 8:43 ` zimoun [this message]
2021-05-11 13:13 ` [bug#48325] update of julia to 1.6.1 zimoun
2021-05-11 13:46 ` Jean-Baptiste Volatier via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86fsysibpg.fsf@gmail.com \
--to=zimon.toutoune@gmail.com \
--cc=48325@debbugs.gnu.org \
--cc=anothersms@gmail.com \
--cc=jbv@pm.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).