unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Dariqq <dariqq@posteo.net>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: "Ludovic Courtès" <ludo@gnu.org>,
	73028@debbugs.gnu.org,
	"Florian Pelz" <pelzflorian@pelzflorian.de>
Subject: [bug#73028] [PATCH] doc: Document usage of #:out-of-source? for meson-build-system.
Date: Thu, 19 Sep 2024 14:07:10 +0000	[thread overview]
Message-ID: <86f53b3e-976c-4757-9dcb-d41dce7263b9@posteo.net> (raw)
In-Reply-To: <87plp6s683.fsf@gmail.com>



On 14.09.24 15:41, Maxim Cournoyer wrote:
> Hi Dariqq,
> 
> Dariqq <dariqq@posteo.net> writes:
> 
>>
>> This does not work. I tried adding that to the arguments in the bag
>> (and reverting the previous patch) but get an error:
>>
>> Unrecognized keyword: #:out-of-source?
>>
>> I guess this is because meson-(cross-)build now get a keyword they
>> don't know.
> 
> Hm.  Thanks for trying it out.
> 
Not an expert on how this works but it looks like when a phase has a 
keyword that is not being passed in by the build-system it is treated as 
#f even if there is no default parameter specified in 
install-license-files function itself.

If there is no easy other way what about leaving the parameter 
undocumented as is? Maybe Ludo can elaborate on what the original 
concern was?

>> Maybe we could replace the install-license-files function with a
>> version that has #:out-of-source? set to #t?. Not sure if there is an
>> elegant way to do this?
> 
> Is this really the only reused phase from gnu-build-system that makes
> use of #:out-of-source?  I'd expect the 'configure' to be one, also.
> And in general it'd be a bit more risky; new gnu-build-system phases
> that would make use of #:out-of-source could start breaking in the
> future until thye are specially handled.
> 

As far as I can see only the configure phase and the 
install-license-phase in gnu-build-system use that parameter. As meson 
overwrites configure with its own it only the install-license-files 
phase uses it.




  reply	other threads:[~2024-09-19 14:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-04 16:26 [bug#73028] [PATCH] doc: Document usage of #:out-of-source? for meson-build-system Dariqq
2024-09-11  6:09 ` Maxim Cournoyer
2024-09-11 15:18   ` Dariqq
2024-09-12  0:56     ` Maxim Cournoyer
2024-09-12  7:12       ` Dariqq
2024-09-12 12:02         ` Maxim Cournoyer
2024-09-12 19:19           ` Dariqq
2024-09-14 13:41             ` Maxim Cournoyer
2024-09-19 14:07               ` Dariqq [this message]
2024-09-22  5:57                 ` Maxim Cournoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86f53b3e-976c-4757-9dcb-d41dce7263b9@posteo.net \
    --to=dariqq@posteo.net \
    --cc=73028@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    --cc=maxim.cournoyer@gmail.com \
    --cc=pelzflorian@pelzflorian.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).