From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id AJxiFSQIy19nZAAA0tVLHw (envelope-from ) for ; Sat, 05 Dec 2020 04:10:12 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id yF9OESQIy191BwAAB5/wlQ (envelope-from ) for ; Sat, 05 Dec 2020 04:10:12 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B89CF94038E for ; Sat, 5 Dec 2020 04:10:11 +0000 (UTC) Received: from localhost ([::1]:50784 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1klOte-0002Fa-D3 for larch@yhetil.org; Fri, 04 Dec 2020 23:10:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:52938) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1klOtX-0002FO-23 for guix-patches@gnu.org; Fri, 04 Dec 2020 23:10:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:34806) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1klOtW-0003QC-Q8 for guix-patches@gnu.org; Fri, 04 Dec 2020 23:10:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1klOtW-0006Z3-EW for guix-patches@gnu.org; Fri, 04 Dec 2020 23:10:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#44920] [PATCH]: Add fcitx5. Resent-From: Zhu Zihao Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 05 Dec 2020 04:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44920 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Peng Mei Yu Cc: 44920@debbugs.gnu.org Received: via spool by 44920-submit@debbugs.gnu.org id=B44920.160714138725207 (code B ref 44920); Sat, 05 Dec 2020 04:10:02 +0000 Received: (at 44920) by debbugs.gnu.org; 5 Dec 2020 04:09:47 +0000 Received: from localhost ([127.0.0.1]:46352 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1klOtG-0006YU-QB for submit@debbugs.gnu.org; Fri, 04 Dec 2020 23:09:47 -0500 Received: from mail-m973.mail.163.com ([123.126.97.3]:40810) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1klOtC-0006YF-Rn for 44920@debbugs.gnu.org; Fri, 04 Dec 2020 23:09:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-ID:MIME-Version; bh=Zi18D OTkqBN7tUuY9s82j8xkwr9QHJXWm+My/LjuGy0=; b=KnNuukbK23jwjmxm1L5jy gQnCpbhJ/i2B6VGxVjijY9bnJ/JAlJZ2LzX13Jxe19bfTrb/fWrn4QLvRC+YkWXJ /FFIGQof5ffm21ALgWtYFjeL5SGQgN0tlcoSUsPGutRghzooGaKJIxqGkTAl0eqb mG7zM8zGXs59uwXJqkXzFg= Received: from asus-laptop (unknown [27.39.88.82]) by smtp3 (Coremail) with SMTP id G9xpCgCn5NX9B8tf6+VOOA--.57096S2; Sat, 05 Dec 2020 12:09:35 +0800 (CST) References: <86360uujbf.fsf@163.com> <87zh2v5y40.fsf@riseup.net> User-agent: mu4e 1.4.13; emacs 27.1 From: Zhu Zihao In-reply-to: <87zh2v5y40.fsf@riseup.net> Date: Sat, 05 Dec 2020 12:09:25 +0800 Message-ID: <86eek499my.fsf@163.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-CM-TRANSID: G9xpCgCn5NX9B8tf6+VOOA--.57096S2 X-Coremail-Antispam: 1Uf129KBjvJXoW7Ar4UAr1DAr1DKF1ktF1kZrb_yoW8WFykpr WSgw4Utw48Kry8GFyUuFs3ur4FkwsIvF45G3ZxtFyvv3W5WF10vFZxKF45AFy7Wrn2gw43 Xa12k3Z3Ja4rXFJanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07UF-ewUUUUU= X-Originating-IP: [27.39.88.82] X-CM-SenderInfo: pdoosuxxwbztlvw6il2tof0z/1tbiTwDxr1sGWzeVVQAAsg X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -0.79 Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=163.com header.s=s110527 header.b=KnNuukbK; dmarc=fail reason="SPF not aligned (relaxed)" header.from=163.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: B89CF94038E X-Spam-Score: -0.79 X-Migadu-Scanner: ns3122888.ip-94-23-21.eu X-TUID: Dh6qw7RhCHF7 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Thank you, Peng. your review are helpful, but I still have some objection on following points. Peng Mei Yu writes: > Hi Zhu Zihao, > > Great work. This patch series provides a long waited alternative to > ibus. I prefer to use ibus as my input method editor, but still thank > you for this work. > > Please see comments bellow. > > > Zhu Zihao writes: > >> This is a series of patches, add fcitx5 and its build dependecies. >> a qt5 and gtk2/3 plugin, chinese inputmethod addon and a material theme >> >> From cbe128e488078b3af8f7d1bdb4bf9dc9f12a2f0b Mon Sep 17 00:00:00 2001 >> From: Zhu Zihao >> Date: Sat, 28 Nov 2020 13:16:50 +0800 >> Subject: [PATCH 1/9] gnu: Add xcb-imdkit. >> >> * gnu/packages/fcitx5.scm: New file. >> (xcb-imdkit): New variable. > > These packages should be put into gnu/packages/fcitx.scm. Why? It currently only used by fcitx5. > > I don't think we should emphasize that Fcitx 5 is the successor to > Fcitx. It's obvious. The old Fcitx 4 has already been deprecated by > the author. Do you think there is a good reason to keep the current > Fcitx package while adding a Fcitx 5 package? Why not replace the old > one? Because Fcitx4 and Fcitx5 is totally different, like python2 & python3. Fcitx5 turns to C++ and Qt technology stack. > > "Lua support for Fcitx" > >> + (description "Fcitx5-lua allow user to write Fcitx5 extension in Lu= a.") > > "Fcitx5-lua allows writing Fcitx extentions in Lua." > > I think we can drop all the emphases on "5". > ditto, because fcitx and fcitx5 are totally different, it's needed to make a clarification. =2D-=20 Retrieve my PGP public key: https://meta.sr.ht/~citreu.pgp Zihao --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQFJBAEBCAAzFiEE7NCVzXX6efyusptG1SOVn+xGFqYFAl/LB/UVHGFsbF9idXRf bGFzdEAxNjMuY29tAAoJENUjlZ/sRhamvDoH/34E+6WljSsYqNj9yAs4NIm1WeqK ZInP63/s3lw/emW0F0pFpleoouaWw9spIz3+xndS1q5gYJcpedBvM/teQ9sDztY8 +pk4J5KoR344gM8QFw3CxYKEFxNCLNhSRZe1aVHV72YZu3prHeoda2t0wHUJfH/h pAc6KtIL5nK88ylk60JuTyKLdr5n2iEaCnSlQLyZEDaenn8Sf1RtpBwf6qADrm5/ 2grG52CklSm+7sOiWLUQrEwUaLEyypC8T0DvfLKRj+O5KID5DlmsHDO5+71C/Whk V1lj4YD3brGiJkyEDzsqwcbsEPLOVul9a1mfsgIRM3RppkcHARTViskbyWM= =tdP2 -----END PGP SIGNATURE----- --=-=-=--