From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id GDGZJ40uZWGckQAAgWs5BA (envelope-from ) for ; Tue, 12 Oct 2021 08:43:25 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id IBkiIo0uZWHffAAAbx9fmQ (envelope-from ) for ; Tue, 12 Oct 2021 06:43:25 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DA85F2C1B4 for ; Tue, 12 Oct 2021 08:43:24 +0200 (CEST) Received: from localhost ([::1]:58952 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1maBVT-00017y-67 for larch@yhetil.org; Tue, 12 Oct 2021 02:43:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35480) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1maBV8-00016w-Ty for guix-patches@gnu.org; Tue, 12 Oct 2021 02:43:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:49957) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1maBV7-00022y-Sf for guix-patches@gnu.org; Tue, 12 Oct 2021 02:43:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1maBV7-0002PX-OD for guix-patches@gnu.org; Tue, 12 Oct 2021 02:43:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50960] [PATCH v2 01/11] packages: Add 'package-development-inputs'. Resent-From: zimoun Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 12 Oct 2021 06:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50960 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= , 50960@debbugs.gnu.org Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 50960-submit@debbugs.gnu.org id=B50960.16340209799259 (code B ref 50960); Tue, 12 Oct 2021 06:43:01 +0000 Received: (at 50960) by debbugs.gnu.org; 12 Oct 2021 06:42:59 +0000 Received: from localhost ([127.0.0.1]:33270 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1maBV5-0002PG-47 for submit@debbugs.gnu.org; Tue, 12 Oct 2021 02:42:59 -0400 Received: from mail-wr1-f44.google.com ([209.85.221.44]:45030) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1maBV3-0002P3-OT for 50960@debbugs.gnu.org; Tue, 12 Oct 2021 02:42:58 -0400 Received: by mail-wr1-f44.google.com with SMTP id e3so29898429wrc.11 for <50960@debbugs.gnu.org>; Mon, 11 Oct 2021 23:42:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-transfer-encoding; bh=ZWfrs3dWwpcc73r3QLbyyTu99pVGua3vsqE4smT92lI=; b=KtA2K3yA4CWXudPfvTvag3v+UK/1GgAjEIgIEcOVJ8NJWPOD89P2V+HCXv5JpI1YXs a9aXX8ARaOjennUI3PCDn8Va7F/zC5d0mn0zJLxZyfMk2uIaUAdEynxkjfkRouZGSgyq SDYUqF517bb81fPnHRlszMYryZx92ZPGnJnN2XC2TrKaIwZuFBnM16KtnG6G7fBUSl8A AzLirE8HUeqEDV7FRk1F6Nplcb5StJhcvhUXchAxkMR9zQOjUNar+JDfghLXmCdjRXvI w0a6gCUbltcM0QMWfAaDdDcvC3zAB92A5OrUow1Z6FF/1ME4gOFZ7LBLpewquxPG7H2w PlHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=ZWfrs3dWwpcc73r3QLbyyTu99pVGua3vsqE4smT92lI=; b=3fUcuhFXhg8nia37opCvkh7qDZfktvQbmLQHrTPmFaxAPYPAEk+tS+wrOXKzz3NSoX e2wWaYAsaaIBJ16gUB2XOJ1heck/o7FbQo/AoHcg88tuP4XU90ygX42qqs0USmODmGD9 fNeliZBNDNTlO4qEQqQ6sEynyRkYn+aqye2yTcywgWyJB8fyHFlMy9EClchGUQ6pbmvI JbUCuVNuqaby11qMDMVBCmoVyXHVB4T52TKK7hvpeH99yI7Ud4fcCQ4f6dupb4fnVy1n yU/rmvifbmCLbiRTwyQB6r23g5SaIWdUXasQQq1//7Pg3cwprQQRYnZI/gsqoUePFoYl ps0Q== X-Gm-Message-State: AOAM5306PYtqxpZaM9GcnzkyVA6v9M5p46GO7SI/sNki59z1fZgtjQcr qqGmsdVHry7UwZzKPc5Z81M= X-Google-Smtp-Source: ABdhPJxCL5wQH1t5DvGZ03qFtWdB8/qUnXYzh0M0alto3HFc37JaTjJkQQMPpKAY8w3wm76ZMkJF/Q== X-Received: by 2002:adf:bb81:: with SMTP id q1mr29955342wrg.119.1634020971679; Mon, 11 Oct 2021 23:42:51 -0700 (PDT) Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id d9sm7570930wrm.96.2021.10.11.23.42.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Oct 2021 23:42:51 -0700 (PDT) From: zimoun In-Reply-To: <20211011213809.17482-2-ludo@gnu.org> References: <20211002102116.27726-1-ludo@gnu.org> <20211011213809.17482-1-ludo@gnu.org> <20211011213809.17482-2-ludo@gnu.org> Date: Tue, 12 Oct 2021 08:39:03 +0200 Message-ID: <86czoaoigo.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1634021004; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=ZWfrs3dWwpcc73r3QLbyyTu99pVGua3vsqE4smT92lI=; b=jH+HATsfXpC8J904R1mXe8iC1adPuEsCgBUEbBkUvHBny8Pcg0R6JkVDY895roSebfhjK4 wrT+0joHk/q6STc5lpUD9pLDaLF1RsaYeP72SSEbt4/CNfA+gi7b6gwleKgYMFiRAT+O4b smr0AmXi69QeaH8u1enJX/7omWwGhpxVejbx+Ks8mJKWLcMZHxoHzvC1IzdcVNFcM5sR7d hmM/BGgaSgAn3Vuwt+3RPA3WmNdMDD1v6MDpu7X4PeOBxlvhDFZUYs23NJlUp1gS4NFYTK gODRix2N4LIwpbqnpRM4d1IADtvJr3EYfYMsNLt4azgjEs4eRScJZy7OOhnizQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1634021004; a=rsa-sha256; cv=none; b=CqCZtbmgCtIbw4dbh9EuQL97RlGJydZtJoCDhv201QVhDVbUIsvu7J7ZgabrS4iBnoa4UI a6UjLFHM+T7oSfcYUaZuuvfFNZviO2ziOaufyr1YOpkg74rjFTqiwDJfEMPZv01vqmy97k 4WAn6agyZB/+jgmMqvmiZ9xXsqB7IbPSFNgjWgQsfNV8uqY8VwBwnZ1TOHG5ymxIoUYAhH C4n7TO1G5y2cYEecSnryIT3n/BADQgqnnfgoSg4dC1Lh3sQThoWY3fak9g5itgahrphXPV PTND6wb2hkWm8iWhkpJxdzW49+ky85m6ysO2ojT2nSq42SsNhHiwMiyYhsuDJA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=KtA2K3yA; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.31 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=KtA2K3yA; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: DA85F2C1B4 X-Spam-Score: -1.31 X-Migadu-Scanner: scn0.migadu.com X-TUID: parR1D4+HIEG Hi Ludo, On Mon, 11 Oct 2021 at 23:37, Ludovic Court=C3=A8s wrote: > * guix/packages.scm (package-development-inputs): New procedure. > * guix/scripts/environment.scm (package-environment-inputs): Use it. > * tests/packages.scm ("package-development-inputs") > ("package-development-inputs, cross-compilation"): New tests. > * doc/guix.texi (package Reference): Document it. LGTM, except=E2=80=A6 > guix/packages.scm | 10 +++++++++ > guix/scripts/environment.scm | 2 +- [...] > +(define* (package-development-inputs package > + #:optional (system (%current-system= )) > + #:key target) > + "Return the list of inputs required by PACKAGE for development purpose= s on > +SYSTEM. When TARGET is true, return the inputs needed to cross-compile > +PACKAGE from SYSTEM to TRIPLET, where TRIPLET is a triplet such as > +\"aarch64-linux-gnu\"." > + (bag-transitive-inputs (package->bag package system target))) [...] > ;; Remove non-package inputs such as origin records. > (filter-map input->manifest-entry > - (bag-transitive-inputs (package->bag package)))) > + (package-development-inputs package system))) Why =E2=80=99system=E2=80=99 is used here? Why is not simply? + (package-development-inputs package))) because =E2=80=99system=E2=80=99 should be not defined, or I do not know wh= ere IIUC. Cheers, simon