From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36780) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cviDS-0007zr-4c for guix-patches@gnu.org; Wed, 05 Apr 2017 06:31:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cviDO-0005S0-KJ for guix-patches@gnu.org; Wed, 05 Apr 2017 06:31:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:34998) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cviDO-0005Rw-HE for guix-patches@gnu.org; Wed, 05 Apr 2017 06:31:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cviDO-0007cY-95 for guix-patches@gnu.org; Wed, 05 Apr 2017 06:31:02 -0400 Subject: bug#26341: [PATCH] build: vm: Add missing module. Resent-Message-ID: References: <20170402150157.7149-1-m.othacehe@gmail.com> <8760iks5u4.fsf@gnu.org> From: Mathieu Othacehe In-reply-to: <8760iks5u4.fsf@gnu.org> Date: Wed, 05 Apr 2017 12:30:35 +0200 Message-ID: <86bmsbrvsk.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 26341@debbugs.gnu.org Hi Ludo, > That said, we should improve this. Perhaps something along the lines of > the attached patch would work. > > Could you try and send an updated patch? Well, I tried a "guix system vm ..." with just my patch and it worked. I agree with you it shouldn't work because it is not possible to use FFI in static Guile. I don't exactly what happend but it might be something like that : (gnu build vm) -- uses module ----> (guix build syscalls) (with my patch) | | | | | -------- provides | | | | v v | mount umount (FFI versions) | -------------> (gnu build linux-boot) | | uses (gnu build file-systems) | | overrides mount and unount with libguile versions if you're using static Guile. So we end-up using libguile mount and umount in (gnu build vm) and not FFI versions of (guix build syscalls). However, it is still a good idea to allow modules to use (guix build syscalls) independently of the fact that they are running inside static Guile or not. So the attached patch (your previous patch, sligtly modified) could be ok ? Thank you, Mathieu