From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id qMr7MVOM92DIKgEAgWs5BA (envelope-from ) for ; Wed, 21 Jul 2021 04:54:11 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id CP52LVOM92C2WwAA1q6Kng (envelope-from ) for ; Wed, 21 Jul 2021 02:54:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 179EA162F9 for ; Wed, 21 Jul 2021 04:54:11 +0200 (CEST) Received: from localhost ([::1]:50618 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m62N8-0007fo-2N for larch@yhetil.org; Tue, 20 Jul 2021 22:54:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47816) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m62N0-0007fc-09 for guix-patches@gnu.org; Tue, 20 Jul 2021 22:54:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:52553) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m62Mz-00007C-Nl for guix-patches@gnu.org; Tue, 20 Jul 2021 22:54:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m62Mz-000518-M1 for guix-patches@gnu.org; Tue, 20 Jul 2021 22:54:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49619] [PATCH 1/2] Add pirate-get Resent-From: Sarah Morgensen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 21 Jul 2021 02:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49619 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: phodina Cc: 49619@debbugs.gnu.org, control@debbugs.gnu.org Received: via spool by 49619-submit@debbugs.gnu.org id=B49619.162683602619255 (code B ref 49619); Wed, 21 Jul 2021 02:54:01 +0000 Received: (at 49619) by debbugs.gnu.org; 21 Jul 2021 02:53:46 +0000 Received: from localhost ([127.0.0.1]:35864 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m62Mj-00050T-NZ for submit@debbugs.gnu.org; Tue, 20 Jul 2021 22:53:46 -0400 Received: from out0.migadu.com ([94.23.1.103]:33887) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m62Mg-00050E-Eg; Tue, 20 Jul 2021 22:53:43 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1626836020; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=P6p1rMNlUc3Bpbdbr2Hp+cJdLEMYUyKiYB1flDMDsQ0=; b=d835on4oexQqeUkYnXmVy3D9tGq4VjF+uMA2aEBFmO3EblG1upjtwQZIbYqFytyY4cW+5q pkB+he4Tuixx/oFRPgw25uDh5scaDAdmmDThbvxS5ZXWD6L9oGXR5nezUk6bd8ZeLddkqT vKtb+ttnZ2M4dV6A7T6oBVVj0CU+O7s= From: Sarah Morgensen References: Date: Tue, 20 Jul 2021 19:53:37 -0700 In-Reply-To: (phodina@protonmail.com's message of "Sun, 18 Jul 2021 11:36:02 +0000") Message-ID: <86bl6wtm1a.fsf@mgsn.dev> MIME-Version: 1.0 Content-Type: text/plain X-Migadu-Auth-User: iskarian@mgsn.dev X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1626836051; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=P6p1rMNlUc3Bpbdbr2Hp+cJdLEMYUyKiYB1flDMDsQ0=; b=UPN1AxPps44wJReL2Ch70cbjOh7fMwtYcIHR2978PN1S5iJPV5j8TLHH08NuF+OLvjsH6R blQsOaBU+N5uYpKBOcHvWC3PD5JkOUiF5G+mgXFdb75c/hj7R/yh8Wp8axXrahrCj1x3KT LPelsSWu/RIxdeRXik29ECK5Z/E40LgmOmKHBAtstbVouSkIRi+NP8IPdZ93GHvA7JQgrT /+FVR40Q4M7xKc58zhm2YxNEnjrLyhSx8fnWsqPY8/NzbnRSO7SGvWYzrkUDM0EcXdF9QZ nFBL6eQosgJ9kGKPKI45+JjwwUWcor+1CMc/JxtNuOgvFPhJpjoKZkVSCO9Xrw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1626836051; a=rsa-sha256; cv=none; b=MJHdHn2w8JrDiEC/qSwL1KDB2oEoBuQBOElkI1o2KwBR7nBkdoukpsWAA5nH8bfZ3Vj8Qr 1f7OaYPngZV+pqCxbVN1jILKjjArpjYSAg5wpJ/h603u/rt8qtERQuxxJ6R1hm1Us/Fowm qJGaObfyC0E4hj/L5kkUE+BxyhP8LSp8rMbkrz7l5Z6bZkdU2tpeDDRwXn0HeIiakC/tJM ZJxWSgpeDkpjtLwwkCi5FS7pBPIroq9khSsQ3RvZKNUfkx9v7Fc4gRO7HYKm1/nH+448ep vqycH3cvicvEk8OewXWuLYkpQyNDulhIIK/e+BBCft2AqSGHrs7C7VVs0ERRag== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=mgsn.dev header.s=key1 header.b=d835on4o; dmarc=fail reason="SPF not aligned (relaxed)" header.from=mgsn.dev (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.32 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=mgsn.dev header.s=key1 header.b=d835on4o; dmarc=fail reason="SPF not aligned (relaxed)" header.from=mgsn.dev (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 179EA162F9 X-Spam-Score: -1.32 X-Migadu-Scanner: scn0.migadu.com X-TUID: YHwAdYLqPpuC merge 49619 49620 thanks Hello, Thanks for the patch. Please note that when submitting patchsets, only the first patch should be sent to guix-patches@gnu.org; the rest should be sent to the generated bug number, in this case 49619@debbugs.gnu.org, in reply to the first email. You can find information about contributing at: https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html I also have a few suggestions so your patch can be accepted. phodina writes: > Add pkg veryprettytable as a dependency for pkg pirate-get > > --- Commit messages should follow the ChangeLog format; see the commit history for examples. For example, this commit message would look like: --8<---------------cut here---------------start------------->8--- gnu: Add python-veryprettytable. * gnu/packages/python-xyz.scm (python-veryprettytable): New variable. --8<---------------cut here---------------end--------------->8--- > diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm > index d8c3fbec07..40b93c4b30 100644 > --- a/gnu/packages/python-xyz.scm > +++ b/gnu/packages/python-xyz.scm > @@ -1754,6 +1754,30 @@ helpers.") > (properties `((python2-variant . ,(delay python2-humanfriendly)))) > (license license:expat))) > > +(define-public python-veryprettytable > + (package > + (name "python-veryprettytable") > + (version "0.8.1") > + (source > + (origin > + (method url-fetch) > + (uri (pypi-uri "veryprettytable" version)) > + (sha256 > + (base32 > + "1k1rifz8x6qcicmx2is9vgxcj0qb2f5pvzrp7zhmvbmci3yack3f")))) > + (build-system python-build-system) > + (propagated-inputs > + `(("python-colorama" ,python-colorama) > + ("python-termcolor" ,python-termcolor))) > + (home-page > + "https://github.com/smeggingsmegger/VeryPrettyTable") > + (synopsis > + "A visually appealing ASCII table output format") Avoid starting synopses and descriptions with articles. "Visually appealing..." would be fine. > + (description > + "A simple Python library for easily displaying tabular data in a visually > +appealing ASCII table format") Descriptions typically start: "VeryPrettyTable is a simple..." The description for pirate-get should probably start "Pirate-get is a..." or "@code{pirate-get} is a..." > + (license license:bsd3))) This should be license:bsd-3. > + > (define-public python2-humanfriendly > (let ((base (package-with-python2 > (strip-python2-variant python-humanfriendly)))) > -- > 2.31.1 You should also add your copyright at the top of the file, below all the others. Please use `--reroll-count=` when generating revised patchsets and `--to=49169@debbugs.gnu.org --in-reply-to=` when sending. -- Sarah