From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id EGRzOxyIN2XbXwAA9RJhRA:P1 (envelope-from ) for ; Tue, 24 Oct 2023 11:02:21 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id EGRzOxyIN2XbXwAA9RJhRA (envelope-from ) for ; Tue, 24 Oct 2023 11:02:21 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C7E0541609 for ; Tue, 24 Oct 2023 11:02:20 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=G0BwryMv; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1698138140; a=rsa-sha256; cv=none; b=qjinC9Nps6y9Z6FjEP5OseVtT0GYVXtVBW9rWfuMAYKdjJlC5/Gvx/mQwsmWPhsAUJ7TRG ujORlnpIMSmscVgkKFtnF6ZjvfGbEH0YsK3IrGEBBd0fbFCZxooJKzcz2EqP7wSc9ir5Wj bqhO/XN9AHeV0VTSiO4ZAwPcRAny1Yfsfen/9KqXyv5oQl5h7MAlgGZAvmIKK498QGLc6b 2QVN6/inrXQSaKnfuC0y8HAWIOb1BG8OqKvEZ4QD7upivNvZdCxVkgwQBnYxiGnCF3hsUQ 6YqdA6lHf2qdRDIfpFe+DZ34UfRmKwwJ3nsu/Rm/bAPyeuUCaZieCGsAUVfovw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=G0BwryMv; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1698138140; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=QN6r7vasWJbMM/qei2Kvz0q7SMxVXIE1ynIYFPt6kCc=; b=G70kgOwPMesk3Qj5/gqSO9R/BawkPHXmHglFE0HZ6cAIhVHiZdb9eYAaLYBqal4UZ4iLPB P7WGHy4d5g0dVHYNEAYhiAoiHtZJ1vvqzqaStQNKEAvq5IRfnK1lPb66+YDW6MArwkOHqy YIzYE2DTLXXvPIGPB4AXNeG5AXGHbuOLznP5U65lplLAgL2EbMGmN4wy7Yw0QhvrGd4ogU GLfkX3dzkCfLZDLpFSDvDqCba2upI0mI9uoogAOlp+tI4bv/GD57To+miQED5d1Al57zkV TevdbQ2ueRBwF2z3JSosF6MWhfArYhecj4m31xzV4sjH/PuB89bQ5pDkUuOtVQ== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qvDI9-0007Xc-9l; Tue, 24 Oct 2023 05:01:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qvDI6-0007Ut-UP for guix-patches@gnu.org; Tue, 24 Oct 2023 05:01:34 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qvDI6-000054-K4 for guix-patches@gnu.org; Tue, 24 Oct 2023 05:01:34 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qvDIa-00073Y-1L for guix-patches@gnu.org; Tue, 24 Oct 2023 05:02:04 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#66436] [PATCH v2] doc: Add some guidelines for reviewing. Resent-From: Simon Tournier Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 24 Oct 2023 09:02:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66436 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer , =?UTF-8?Q?Cl=C3=A9ment?= Lassieur Cc: 66436@debbugs.gnu.org, Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 66436-submit@debbugs.gnu.org id=B66436.169813810927069 (code B ref 66436); Tue, 24 Oct 2023 09:02:04 +0000 Received: (at 66436) by debbugs.gnu.org; 24 Oct 2023 09:01:49 +0000 Received: from localhost ([127.0.0.1]:53090 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qvDIL-00072R-DF for submit@debbugs.gnu.org; Tue, 24 Oct 2023 05:01:49 -0400 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]:40303) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qvDIA-00071D-4A for 66436@debbugs.gnu.org; Tue, 24 Oct 2023 05:01:39 -0400 Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-408cd9660b8so6811855e9.1 for <66436@debbugs.gnu.org>; Tue, 24 Oct 2023 02:01:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698138063; x=1698742863; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=QN6r7vasWJbMM/qei2Kvz0q7SMxVXIE1ynIYFPt6kCc=; b=G0BwryMvFKa0m6cVoMlHloK1yfrIPJ0HV7zMhiNHC6N2MQfs5w5CwQ6RiR+kJZazrv /D1Yu5z4jY9B2UJNAiYKpMx2dURPs962TcIUdKJ0EixnrYW2toD0XXefQwG8w+U/xp8o fVul1Uwf0+o957SuRwUOpL48avffiMiERWUb9gEyYyc4qasCGnKL3clqzcfkkraa93tu a7xs84tXQZo0VDPa/UhJnQ2vDdUgb1AeeAcSedu1CL+lYOj+yfcQQS1bIvZA2+w/CDoo +2vVQrjpjWutswDGzz0ql2cdoLQp7wUmWwKh38sQFosYG2x9R7XTnvx8vQPFo7FJbvQx CCXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698138063; x=1698742863; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QN6r7vasWJbMM/qei2Kvz0q7SMxVXIE1ynIYFPt6kCc=; b=edfq1Xck2DndovkDP2mct6Wl6SfVodmE+uj2fEIc/hyPcSZcSK+JxRv3WKQAl2wS2u sKhBcuCWb9F+tZNmmrKBmTherYcQF3O2+PZ8Bv5qlmlwOBXLCoFCyfHQzODXky1CaJ7D ixWtpjufJo91lu9pjdygbKmNM9NZZRQW2tBuCJJL8uUnS8zaancP4CrIF1iAVCYYoWxR nsw6718r+N8TX4AMc7D7ukA/xkFpln9482+qGKccJJtaULGv0e+UaC99h1jyvj2phw/k 4mFKJq8TUcKBgUwMNTSzm1ujEE14Ve6hP+1jLSlf1lIKq3dGvWWrChJ3b/OJY/GWeDoF /kGA== X-Gm-Message-State: AOJu0YxI9fwIGMPybuZcuORMdTyAZVL+Yvx6jlyBF+jYykzj/86Z3Yrn oWoyaziQ9nmgNs8pZHcMAL0iq+KnGMU= X-Google-Smtp-Source: AGHT+IHx7JYD0GhoGu6XrQXmDaa8jQGVE8tp001iTGDSdJq9G3OH1wxTMxHAYumyJPRqJrCfNn/NVw== X-Received: by 2002:a05:600c:4c17:b0:405:358c:ba75 with SMTP id d23-20020a05600c4c1700b00405358cba75mr8906080wmp.0.1698138062524; Tue, 24 Oct 2023 02:01:02 -0700 (PDT) Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id ay10-20020a05600c1e0a00b00405442edc69sm13698616wmb.14.2023.10.24.02.01.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Oct 2023 02:01:02 -0700 (PDT) From: Simon Tournier In-Reply-To: <86il6wv200.fsf@gmail.com> References: <19f82d9bbef649c750ad067d23ebbaee6f9ae494.1696942467.git.maxim.cournoyer@gmail.com> <0a5e027af3c0b61f9ab9f3c66e73b7a769eef7fd.1696983695.git.maxim.cournoyer@gmail.com> <87h6mlzp9g.fsf@lassieur.org> <87r0logap6.fsf@gmail.com> <86il6wv200.fsf@gmail.com> Date: Tue, 24 Oct 2023 10:59:45 +0200 Message-ID: <86bkcov1j2.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx1.migadu.com X-Migadu-Spam-Score: 4.54 X-Spam-Score: 4.54 X-Migadu-Queue-Id: C7E0541609 X-TUID: us3jsNjHFtxG Re, On Tue, 24 Oct 2023 at 10:49, Simon Tournier wro= te: >> --8<---------------cut here---------------start------------->8--- >> +Perhaps the biggest action you can do to help GNU Guix grow as a project >> +is to review the work contributed by others. You do not need to be a >> +committer to do so; applying, reading the source, building, linting and >> +running other people's series and sharing your comments about your >> +experience will give some confidence to committers, and should result in >> +the proposed change being merged faster. >> --8<---------------cut here---------------end--------------->8--- [...] > IMHO, it is worth to clearly state: > > 1. what helps the review process: > > =C2=AB applying, reading the source, building, linting and running ot= her > people's series and sharing your comments about your experience will > give some confidence to committers, and should result in the > proposed change being merged faster. =C2=BB Although I do not know if it is the right place, I would mention that =E2=80=9Cbuilding=E2=80=9D also means that the dependants still build or cl= early indicate if something breaks. Cheers, simon