From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id IMzZArdJ6l8RVAAA0tVLHw (envelope-from ) for ; Mon, 28 Dec 2020 21:10:15 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 4CEyOrZJ6l+SDgAAbx9fmQ (envelope-from ) for ; Mon, 28 Dec 2020 21:10:14 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 90B1F94011C for ; Mon, 28 Dec 2020 21:10:14 +0000 (UTC) Received: from localhost ([::1]:55042 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ktzmP-00072R-FS for larch@yhetil.org; Mon, 28 Dec 2020 16:10:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:33826) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ktzmE-00071l-Tl for guix-patches@gnu.org; Mon, 28 Dec 2020 16:10:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:53687) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ktzmE-00065Q-5c for guix-patches@gnu.org; Mon, 28 Dec 2020 16:10:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ktzmD-0006fl-Vz for guix-patches@gnu.org; Mon, 28 Dec 2020 16:10:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#45498] [PATCH 00/12] Add ocaml-merlin. Resent-From: pukkamustard Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 28 Dec 2020 21:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45498 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Julien Lepiller Received: via spool by 45498-submit@debbugs.gnu.org id=B45498.160918978225617 (code B ref 45498); Mon, 28 Dec 2020 21:10:01 +0000 Received: (at 45498) by debbugs.gnu.org; 28 Dec 2020 21:09:42 +0000 Received: from localhost ([127.0.0.1]:36998 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ktzlu-0006f6-4W for submit@debbugs.gnu.org; Mon, 28 Dec 2020 16:09:42 -0500 Received: from mout01.posteo.de ([185.67.36.65]:36636) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ktzlo-0006ep-Uz for 45498@debbugs.gnu.org; Mon, 28 Dec 2020 16:09:40 -0500 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 7ABA216005C for <45498@debbugs.gnu.org>; Mon, 28 Dec 2020 22:09:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1609189770; bh=OX5vbqliwKb8Aq1dk2gHF45jhrllBB8AapA6eO38iDk=; h=From:To:Cc:Subject:Date:From; b=Q2L4c7uujEocqg+xsoIdN1DQVHoSzlsPIpUFEDqhN++VJeQ1GMik6T5IGaUU5Vycr lCWf4YJY/22boNfPnMMEH6fylIiKEZSPnPLLeNWiHMd6yxVLckwaSv9WR31WZcDgf8 bWvWDiVMkaAdIeNMdTscP6T8BZP/OMI3ned2Xea3QlNtp8wdZPCr5D2wJNskeNyHys 45DHjM/zzVX0ErEjEh4MB5X9cdacVB28rcb4RqzMpLeyGGor0XvLN7EEQO0mgZd/cB NbWNNd18iosKuN+tQ7DLjHe+BIdktyrdQg4FdbfxgnaE+s1T6ZAyvnIGCe5PsXFG47 LjLR5/MuhlgiQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4D4VY555Fcz9rxK; Mon, 28 Dec 2020 22:09:29 +0100 (CET) References: <20201228124017.24295-1-pukkamustard@posteo.net> <20201228150655.101e4704@tachikoma.lepiller.eu> <86pn2tn6mv.fsf@posteo.net> <20201228210037.0af6cf8a@tachikoma.lepiller.eu> User-agent: mu4e 1.4.13; emacs 27.1 From: pukkamustard In-reply-to: <20201228210037.0af6cf8a@tachikoma.lepiller.eu> Date: Mon, 28 Dec 2020 22:09:24 +0100 Message-ID: <86a6txfxiz.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 45498@debbugs.gnu.org Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -1.22 Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=posteo.net header.s=2017 header.b=Q2L4c7uu; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 90B1F94011C X-Spam-Score: -1.22 X-Migadu-Scanner: scn0.migadu.com X-TUID: WLtyO8E/sklp >> > Have you tried updating dune to the latest version that >> > builds >> > with >> > ocaml 4.07? >> >> Not yet. For ocaml-markup 1.0.0 the problem is that the dune >> file >> version is set to 2.7. Any dune below 2.7.x will probably not >> work. > > Is this a hard requirement? I think we used to be able to use > older > dune versions despite this. Not sure. Will keep this for future investigation. >> >> - Some OCaml libraries have dependencies in `inputs` that >> >> seem >> >> to be >> >> required from packages using the libraries. E.g. >> >> `ocaml-yojson` >> >> depends on `ocaml-biniou`. Packages depending on >> >> `ocaml-yojson` >> >> need >> >> to manually add `ocaml-biniou` to their inputs. Would it >> >> work/make >> >> sense to add `ocaml-biniou` to `propagated-inputs` of >> >> `ocaml-yojson`? >> > >> > Yeah, could you provide an additional patch for that? >> >> Done. Patch 13 in v2. > > Could you instead put this as patch 12, and add merlin as patch > 13? > That way you don't have to add the dependencies in merlin and > remove > them in the following patch. > > Also, patch 12 adds ocaml-dot-merlin-reader and ocaml-merlin. > could you > separate it in two separate patches? Done. v3 coming shortly... > I'm also wondering if we should > call this package "merlin" instead of ocaml-merlin, since it > provides a > binary of that name? Hm, both seems fine to me. I've stuck to "ocaml-merlin" for now. Feel free to change if you think "merlin" is more suitable. -pukkamustard