From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id CMxUO8imN2GsSwAAgWs5BA (envelope-from ) for ; Tue, 07 Sep 2021 19:52:08 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id AGcHN8imN2HJaQAA1q6Kng (envelope-from ) for ; Tue, 07 Sep 2021 17:52:08 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CE098FFD8 for ; Tue, 7 Sep 2021 19:52:07 +0200 (CEST) Received: from localhost ([::1]:56520 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mNfGQ-00073v-Sk for larch@yhetil.org; Tue, 07 Sep 2021 13:52:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49436) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mNfGM-00073F-MV for guix-patches@gnu.org; Tue, 07 Sep 2021 13:52:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:46076) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mNfGM-00007Q-FM for guix-patches@gnu.org; Tue, 07 Sep 2021 13:52:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mNfGM-00053i-CW for guix-patches@gnu.org; Tue, 07 Sep 2021 13:52:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50072] [PATCH WIP 4/4] upstream: Support updating git-fetch origins. Resent-From: Sarah Morgensen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 07 Sep 2021 17:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50072 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: 50072@debbugs.gnu.org Received: via spool by 50072-submit@debbugs.gnu.org id=B50072.163103707419363 (code B ref 50072); Tue, 07 Sep 2021 17:52:02 +0000 Received: (at 50072) by debbugs.gnu.org; 7 Sep 2021 17:51:14 +0000 Received: from localhost ([127.0.0.1]:57619 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mNfFa-00052F-4g for submit@debbugs.gnu.org; Tue, 07 Sep 2021 13:51:14 -0400 Received: from out2.migadu.com ([188.165.223.204]:49079) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mNfFX-000523-HF for 50072@debbugs.gnu.org; Tue, 07 Sep 2021 13:51:13 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1631037069; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QIdr60V2P+5C2KDeHFspc05pxRDAl/xo9dSTP4pIkJA=; b=Dk0ztGNlblTrUvutaRpoZazPQI9Zb2tT31YpPSuinuX/A63PpaDHfnHdQnMUJWlUxm3/KE 3+69/4TS2DUCRVj3d5GgtWagUO3sHYTNGiMm4/MCJjulRFGCsZ1d3CQiTmbOnuxD+zRtRg s1kiqVBjuK/dkypJ1W6lI7EA882jt/g= From: Sarah Morgensen References: <8d1ae518b23fac5b15812a30b11df1c360ab3fbf.1629068119.git.iskarian@mgsn.dev> <86mtopi3s7.fsf@mgsn.dev> <470a95f159120d14384c3096cff91e3ce8d3c6c8.camel@telenet.be> Date: Tue, 07 Sep 2021 10:51:07 -0700 In-Reply-To: <470a95f159120d14384c3096cff91e3ce8d3c6c8.camel@telenet.be> (Maxime Devos's message of "Tue, 07 Sep 2021 12:00:42 +0200 (7 hours, 45 minutes, 41 seconds ago)") Message-ID: <86a6koi8ac.fsf@mgsn.dev> MIME-Version: 1.0 Content-Type: text/plain X-Migadu-Auth-User: iskarian@mgsn.dev X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1631037128; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=QIdr60V2P+5C2KDeHFspc05pxRDAl/xo9dSTP4pIkJA=; b=V1Op8w6jlaG0PrL19HnyQnyEIMhhuA1NtkdMqGzQ8jPRGZXeOZYhjPScW/gak8oBKs1YmC dR+j6NLRIIOqzFj4y2bx/Sddd871S+G6ql/loZ3py4JXnIXo3rJWB9FktEGPJ75yzurOh6 ZxqfbXCS4dZw2PQOmIuaGFlZiqjTBV9kvTKqrvweSzkO9kz1gqTWCYwchmubvHWLXBNowl z3lTq+bfsy8X/vH/H4olr9oY7UdHIpvvJmI0BX+/ok9MmuUsY6/c56ErUkpzKAq7I3SS2X MdACnZf0mRyGURFzV/mXAh6TWh9++dxUZs/S8KZB5LXDoRu5pXRFA/kick3R/w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1631037128; a=rsa-sha256; cv=none; b=E4fCX9uJ4d2QsniO5P/U8CzEGZuR1xloys2BOmp3Lo2QW+uyP7CbWh7t85hB4Wc11RX/2V +HrxcZpWaViex57KVfs3MISHE6p4TUusWei5PTih0a5f/vpjzwKwO9/PSfKWyrCuD++PBc 5nn5MPqP5E5RsnLx9/c/dLwIKOxG2YLwP/c+rEQ8x9GuTQPsrTB31wT6OK38zCvtrU8/CR TtdAGzY0ixmSe+F4cGTULkM4H8ypm2GuRrbtT9HsM6wWt9VUaLtM2UkJE9CbgirbE72+8t roCx6J5yUFW4YgbNogrXuNcPLFn602hXVi7WA9enigOlVpRlnqFYXc98tgZmRQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=mgsn.dev header.s=key1 header.b=Dk0ztGNl; dmarc=fail reason="SPF not aligned (relaxed)" header.from=mgsn.dev (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: 0.19 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=mgsn.dev header.s=key1 header.b=Dk0ztGNl; dmarc=fail reason="SPF not aligned (relaxed)" header.from=mgsn.dev (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: CE098FFD8 X-Spam-Score: 0.19 X-Migadu-Scanner: scn0.migadu.com X-TUID: LXYgCdodbrTw Hi, Maxime Devos writes: > Sarah Morgensen schreef op ma 06-09-2021 om 18:16 [-0700]: >> Hi Maxime, >> >> Maxime Devos writes: >> >> > Sarah Morgensen schreef op zo 15-08-2021 om 16:25 [-0700]: >> > > * guix/git-download.scm (checkout-to-store): New procedure. >> > > * guix/upstream.scm (guess-version-transform) >> > > (package-update/git-fetch): New procedures. >> > > (%method-updates): Add GIT-FETCH mapping. >> > >> > Does it support packages defined like (a) >> > >> > (define-public gnash >> > (let ((commit "583ccbc1275c7701dc4843ec12142ff86bb305b4") >> > (revision "0")) >> > (package >> > (name "gnash") >> > (version (git-version "0.8.11" revision commit)) >> > (source (git-reference >> > (url "https://example.org") >> > (commit commit))) >> > [...]))) >> >> Thinking about this again, since updaters typically returns actual >> versions (tags) instead of commits, how much would such a >> feature be used? > > The minetest updater returns version numbers. > It also returns a git-reference object, which includes the commit. > Just returning a version number often isn't sufficient, > because many repositories of minetest mods do not keep version tags. Thanks for the explanation. So there is a version number indicated elsewhere than in the tags for some minetest packages? (Is this data in the package's git repo or in e.g. minetest repo metadata?) That is, the minetest updater always uses "blessed versions" (not just random commits), such that "revision" will always be "0"? Are current minetest packages like this formatted like 'gnash' above? > See . That's the message I quoted ;) -- Sarah