unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: zimoun <zimon.toutoune@gmail.com>
To: "pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de>
Cc: Julien Lepiller <julien@lepiller.eu>,
	Tobias Geerinckx-Rice <me@tobias.gr>,
	52596@debbugs.gnu.org, Leo Famulari <leo@famulari.name>
Subject: [bug#52596] [guix-artwork PATCH] website: Relabel stable/latest to release/current.
Date: Wed, 29 Dec 2021 17:40:45 +0100	[thread overview]
Message-ID: <86a6gjjrea.fsf@gmail.com> (raw)
In-Reply-To: <20211224173448.saiun645pxymukbl@pelzflorian.localdomain>

Hi Florian,

On Fri, 24 Dec 2021 at 18:34, "pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de> wrote:

> Sorry for not having pushed yet.  (Actually I had somehow assumed you
> had commit access ...).

Sorry for the delay.  Indeed, I do not have commit access. :-)

> On Sun, Dec 19, 2021 at 10:21:29AM +0100, zimoun wrote:
>> Well, maybe ’standard / latest’?  Or something else than latest as
>> development, current, or whatever else.
>
> Actually yes.

Thanks for the follow up.


> I would like to push the attached patch
> "website: Relabel stable/latest to standard/latest."

LGTM, thanks for the various fixes.


> - The sum of your changes grants copyright IMHO, so I added copyright
>   headers for you for all changed files.
>   Note that Luis Felipe opted for
>   ;;; Public domain 2021 Luis Felipe López Acevedo
>   instead of
>   ;;; Copyright © 2021 Simon Tournier <zimon.toutoune@gmail.com>
>   so I better ask first which you prefer.

All is fine.  Since I considered it was trivial changes, I appeared to
me not necessary for the Copyright line. :-)  Thanks for taking care of
all that.


> - Also changing Help/GNU Guix Manual (stable)
>   to Help/GNU Guix Manual 1.3.0 as you proposed.

With fresh eyes, maybe “Guix Manual” is enough here.


> From: zimoun <zimon.toutoune@gmail.com>
> Date: Sat, 18 Dec 2021 11:40:38 +0100
> Subject: [PATCH] website: Relabel stable/latest to standard/latest.
>
> * website/apps/base/templates/components.scm (navbar): Relabel.
> * website/apps/base/templates/help.scm (help-t): Relabel.
> * website/apps/download/templates/download-latest.scm (download-latest-t):
> Relabel.
>
> Signed-off-by: Florian Pelz <pelzflorian@pelzflorian.de>
> ---
>  website/apps/base/templates/components.scm          | 12 +++++++-----
>  website/apps/base/templates/help.scm                |  7 ++++---
>  website/apps/download/templates/download-latest.scm | 10 ++++++----
>  3 files changed, 17 insertions(+), 12 deletions(-)

LGTM.


Cheers,
simon




  reply	other threads:[~2021-12-29 16:48 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-18 10:40 [bug#52596] [guix-artwork PATCH] website: Relabel stable/latest to release/current zimoun
2021-12-18 15:22 ` pelzflorian (Florian Pelz)
2021-12-18 15:43   ` zimoun
2021-12-18 19:36     ` pelzflorian (Florian Pelz)
2021-12-19  9:21       ` zimoun
2021-12-19 10:40         ` pelzflorian (Florian Pelz)
2021-12-23  1:21           ` pelzflorian (Florian Pelz)
2021-12-24 17:34         ` pelzflorian (Florian Pelz)
2021-12-29 16:40           ` zimoun [this message]
2021-12-29 19:42             ` pelzflorian (Florian Pelz)
2021-12-29 20:07               ` Leo Famulari
2021-12-29 22:53                 ` pelzflorian (Florian Pelz)
2021-12-30 15:49                   ` zimoun
2021-12-30 17:03                     ` pelzflorian (Florian Pelz)
2021-12-29 20:07               ` zimoun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86a6gjjrea.fsf@gmail.com \
    --to=zimon.toutoune@gmail.com \
    --cc=52596@debbugs.gnu.org \
    --cc=julien@lepiller.eu \
    --cc=leo@famulari.name \
    --cc=me@tobias.gr \
    --cc=pelzflorian@pelzflorian.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).