* [bug#57017] [PATCH]: gnu: tdlib: Update to 1.8.4.
@ 2022-08-06 15:30 Zhu Zihao
[not found] ` <handler.57017.B.165979999622202.ack@debbugs.gnu.org>
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Zhu Zihao @ 2022-08-06 15:30 UTC (permalink / raw)
To: 57017
[-- Attachment #1.1: Type: text/plain, Size: 0 bytes --]
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 255 bytes --]
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-tdlib-Use-G-expressions.patch --]
[-- Type: text/x-patch, Size: 2199 bytes --]
From 0037a0f2847fe39846c5a03139ef1be5b0a45155 Mon Sep 17 00:00:00 2001
From: Zhu Zihao <all_but_last@163.com>
Date: Sat, 6 Aug 2022 23:10:56 +0800
Subject: [PATCH 1/2] gnu: tdlib: Use G-expressions.
* gnu/packages/messaging.scm (tdlib)[arguments]: Use G-expressions.
---
gnu/packages/messaging.scm | 27 ++++++++++++++-------------
1 file changed, 14 insertions(+), 13 deletions(-)
diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index 2f61a8f783..aa15bf5b53 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -2665,19 +2665,20 @@ (define-public tdlib
(file-name (git-file-name name version))))
(build-system cmake-build-system)
(arguments
- `(#:configure-flags
- (list "-DCMAKE_BUILD_TYPE=Release"
- "-DTD_ENABLE_LTO=OFF") ; FIXME: Get LTO to work.
- #:phases
- (modify-phases %standard-phases
- (add-after 'unpack 'remove-failing-tests
- (lambda _
- (substitute* "test/CMakeLists.txt"
- ;; The test cases are compiled into a distinct binary
- ;; which uses mtproto.cpp to attempt to connect to
- ;; a remote server. Removing this file from the sources
- ;; list disables those specific test cases.
- (("\\$\\{CMAKE_CURRENT_SOURCE_DIR\\}/mtproto.cpp") "")))))))
+ (list
+ #:configure-flags
+ #~(list "-DCMAKE_BUILD_TYPE=Release"
+ "-DTD_ENABLE_LTO=OFF") ; FIXME: Get LTO to work.
+ #:phases
+ #~(modify-phases %standard-phases
+ (add-after 'unpack 'remove-failing-tests
+ (lambda _
+ (substitute* "test/CMakeLists.txt"
+ ;; The test cases are compiled into a distinct binary
+ ;; which uses mtproto.cpp to attempt to connect to
+ ;; a remote server. Removing this file from the sources
+ ;; list disables those specific test cases.
+ (("\\$\\{CMAKE_CURRENT_SOURCE_DIR\\}/mtproto.cpp") "")))))))
(native-inputs
(list gperf openssl zlib php doxygen))
(synopsis "Cross-platform library for building Telegram clients")
--
2.37.1
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #3: 0002-gnu-tdlib-Update-to-1.8.4.patch --]
[-- Type: text/x-patch, Size: 1623 bytes --]
From 45ff40bc27f6cacba976814841c90e8572118302 Mon Sep 17 00:00:00 2001
From: Zhu Zihao <all_but_last@163.com>
Date: Sat, 6 Aug 2022 23:12:17 +0800
Subject: [PATCH 2/2] gnu: tdlib: Update to 1.8.4.
* gnu/packages/messaging.scm (tdlib): Update to 1.8.4.
<#:configure-flags>: Enable LTO. Move build type settings to #:build-type
arguments.
<#:build-type>: Use "Release build".
---
gnu/packages/messaging.scm | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index aa15bf5b53..89ba419f18 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -2653,22 +2653,20 @@ (define-public telegram-purple
(define-public tdlib
(package
(name "tdlib")
- (version "1.8.0")
+ (version "1.8.4")
(source
(origin
(method git-fetch)
(uri (git-reference
(url "https://github.com/tdlib/td")
- (commit (string-append "v" version))))
+ (commit "7eabd8ca60de025e45e99d4e5edd39f4ebd9467e")))
(sha256
- (base32 "19psqpyh9a2kzfdhgqkirpif4x8pzy89phvi59dq155y30a3661q"))
+ (base32 "1chs0ibghjj275v9arsn3k68ppblpm7ysqk0za9kya5vdnldlld5"))
(file-name (git-file-name name version))))
(build-system cmake-build-system)
(arguments
(list
- #:configure-flags
- #~(list "-DCMAKE_BUILD_TYPE=Release"
- "-DTD_ENABLE_LTO=OFF") ; FIXME: Get LTO to work.
+ #:build-type "Release"
#:phases
#~(modify-phases %standard-phases
(add-after 'unpack 'remove-failing-tests
--
2.37.1
[-- Attachment #4: Type: text/plain, Size: 100 bytes --]
--
Retrieve my PGP public key:
gpg --recv-keys 481F5EEEBA425ADC13247C76A6E672D981B8E744
Zihao
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [bug#57017] Acknowledgement ([PATCH]: gnu: tdlib: Update to 1.8.4. )
[not found] ` <handler.57017.B.165979999622202.ack@debbugs.gnu.org>
@ 2022-08-13 14:04 ` Zhu Zihao
0 siblings, 0 replies; 4+ messages in thread
From: Zhu Zihao @ 2022-08-13 14:04 UTC (permalink / raw)
To: 57017
ping.
--
Retrieve my PGP public key:
gpg --recv-keys 481F5EEEBA425ADC13247C76A6E672D981B8E744
Zihao
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#57017: [PATCH]: gnu: tdlib: Update to 1.8.4.
2022-08-06 15:30 [bug#57017] [PATCH]: gnu: tdlib: Update to 1.8.4 Zhu Zihao
[not found] ` <handler.57017.B.165979999622202.ack@debbugs.gnu.org>
@ 2022-08-31 22:57 ` Ludovic Courtès
2022-09-09 13:57 ` [bug#57017] " Giovanni Biscuolo
2 siblings, 0 replies; 4+ messages in thread
From: Ludovic Courtès @ 2022-08-31 22:57 UTC (permalink / raw)
To: Zhu Zihao; +Cc: 57017-done
Hi,
Zhu Zihao <all_but_last@163.com> skribis:
>>From 0037a0f2847fe39846c5a03139ef1be5b0a45155 Mon Sep 17 00:00:00 2001
> From: Zhu Zihao <all_but_last@163.com>
> Date: Sat, 6 Aug 2022 23:10:56 +0800
> Subject: [PATCH 1/2] gnu: tdlib: Use G-expressions.
>
> * gnu/packages/messaging.scm (tdlib)[arguments]: Use G-expressions.
[...]
>>From 45ff40bc27f6cacba976814841c90e8572118302 Mon Sep 17 00:00:00 2001
> From: Zhu Zihao <all_but_last@163.com>
> Date: Sat, 6 Aug 2022 23:12:17 +0800
> Subject: [PATCH 2/2] gnu: tdlib: Update to 1.8.4.
>
> * gnu/packages/messaging.scm (tdlib): Update to 1.8.4.
> <#:configure-flags>: Enable LTO. Move build type settings to #:build-type
> arguments.
> <#:build-type>: Use "Release build".
Applied, thanks!
Ludo’.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [bug#57017] [PATCH]: gnu: tdlib: Update to 1.8.4.
2022-08-06 15:30 [bug#57017] [PATCH]: gnu: tdlib: Update to 1.8.4 Zhu Zihao
[not found] ` <handler.57017.B.165979999622202.ack@debbugs.gnu.org>
2022-08-31 22:57 ` bug#57017: [PATCH]: gnu: tdlib: Update to 1.8.4 Ludovic Courtès
@ 2022-09-09 13:57 ` Giovanni Biscuolo
2 siblings, 0 replies; 4+ messages in thread
From: Giovanni Biscuolo @ 2022-09-09 13:57 UTC (permalink / raw)
To: Zhu Zihao, 57017; +Cc: Ludovic Courtès
[-- Attachment #1: Type: text/plain, Size: 2057 bytes --]
Hello,
sorry I was not able to spot this issue before this patch was committed
Zhu Zihao <all_but_last@163.com> writes:
[...]
> From 45ff40bc27f6cacba976814841c90e8572118302 Mon Sep 17 00:00:00 2001
> From: Zhu Zihao <all_but_last@163.com>
> Date: Sat, 6 Aug 2022 23:12:17 +0800
> Subject: [PATCH 2/2] gnu: tdlib: Update to 1.8.4.
>
> * gnu/packages/messaging.scm (tdlib): Update to 1.8.4.
> <#:configure-flags>: Enable LTO. Move build type settings to #:build-type
> arguments.
> <#:build-type>: Use "Release build".
> ---
> gnu/packages/messaging.scm | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
> index aa15bf5b53..89ba419f18 100644
> --- a/gnu/packages/messaging.scm
> +++ b/gnu/packages/messaging.scm
> @@ -2653,22 +2653,20 @@ (define-public telegram-purple
> (define-public tdlib
> (package
> (name "tdlib")
> - (version "1.8.0")
> + (version "1.8.4")
> (source
> (origin
> (method git-fetch)
> (uri (git-reference
> (url "https://github.com/tdlib/td")
> - (commit (string-append "v" version))))
> + (commit "7eabd8ca60de025e45e99d4e5edd39f4ebd9467e")))
with the change above this patch is not using an official release of the
library but a specific commit from master, still not stable
the last stable release of tdlib is still 1.8.0 [1] and there is no
1.8.4 release yet
unfortunately people (like me) who upgraded tdlib are now having
problems with emacs-telega (see bug#57543)
please revert this patch ASAP
furthermore, it is likely that reverting this patch is not enough to
restore emacs-telega functionality since the tdlib upgrade triggered a
tdblib database upgrade that is non more compatible with the previous
tdlib version (see bug #57543) for details
[...]
Happy hacking! Gio'
[1] https://github.com/tdlib/td/blob/master/CHANGELOG.md
--
Giovanni Biscuolo
Xelera IT Infrastructures
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 849 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-09-09 14:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-06 15:30 [bug#57017] [PATCH]: gnu: tdlib: Update to 1.8.4 Zhu Zihao
[not found] ` <handler.57017.B.165979999622202.ack@debbugs.gnu.org>
2022-08-13 14:04 ` [bug#57017] Acknowledgement ([PATCH]: gnu: tdlib: Update to 1.8.4. ) Zhu Zihao
2022-08-31 22:57 ` bug#57017: [PATCH]: gnu: tdlib: Update to 1.8.4 Ludovic Courtès
2022-09-09 13:57 ` [bug#57017] " Giovanni Biscuolo
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).