From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id GGLFBt8SUGG0KwEAgWs5BA (envelope-from ) for ; Sun, 26 Sep 2021 08:27:43 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 4EdYAt8SUGHPWgAAB5/wlQ (envelope-from ) for ; Sun, 26 Sep 2021 06:27:43 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9A4CA2D1DD for ; Sun, 26 Sep 2021 08:27:42 +0200 (CEST) Received: from localhost ([::1]:50366 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mUNdV-0007iR-Ni for larch@yhetil.org; Sun, 26 Sep 2021 02:27:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35722) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mUNaw-0005Ya-7T for guix-patches@gnu.org; Sun, 26 Sep 2021 02:25:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:52222) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mUNav-0002sc-Vx for guix-patches@gnu.org; Sun, 26 Sep 2021 02:25:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mUNav-0000Z2-Qa for guix-patches@gnu.org; Sun, 26 Sep 2021 02:25:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50274] [PATCH] guix: git: Adds feature to download git repository to the store. Resent-From: Sarah Morgensen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 26 Sep 2021 06:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50274 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: Julien Lepiller , jgart , 50274@debbugs.gnu.org Received: via spool by 50274-submit@debbugs.gnu.org id=B50274.16326374912136 (code B ref 50274); Sun, 26 Sep 2021 06:25:01 +0000 Received: (at 50274) by debbugs.gnu.org; 26 Sep 2021 06:24:51 +0000 Received: from localhost ([127.0.0.1]:35530 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mUNal-0000YO-LO for submit@debbugs.gnu.org; Sun, 26 Sep 2021 02:24:51 -0400 Received: from out0.migadu.com ([94.23.1.103]:22350) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mUNaj-0000YD-0w for 50274@debbugs.gnu.org; Sun, 26 Sep 2021 02:24:50 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1632637487; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LAoGjr52flL0L0svUFv7Ut0VNisrUdIJF8InwiTiOv4=; b=HvTKzZz7K8K3L+ahyxxuEL74GU5Y7Kq97zs/Xcm0CrB/niUPwGfIU7oYw3+aE8okxujZ12 8w1xr/eVQSErg3m9jR/q5vdmqNNgEgMBnouMbRNf+/0N4EW2rDjqr2xQybB4YbE5wZszJz ZQLdYR5JpMBU5wb7mDmA6S5P/EINXVg= From: Sarah Morgensen References: <20210830163918.19419-1-jgart@dismail.de> <87y27mma7m.fsf@gnu.org> Date: Sat, 25 Sep 2021 23:24:45 -0700 In-Reply-To: <87y27mma7m.fsf@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Fri, 24 Sep 2021 14:25:49 +0200 (1 day, 17 hours, 53 minutes ago)") Message-ID: <868rzjvope.fsf@mgsn.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1632637662; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=LAoGjr52flL0L0svUFv7Ut0VNisrUdIJF8InwiTiOv4=; b=Umfz4NP+yCppOMA+X6egpenla40gFPJny+QtKVTMuUDzQbfhK8BX146lhh5Vl4NMgsum3T UQ5/RoGvMak5MNERck/3qkzqIBL0E2migCx9GTE0C1OOJ9nFon5hQSidtP8UN5/z6Imyyn n3Rx9BOW7wcfIAg8s+IMBoV0j+7UJD+0yywQTmFnKVDHYxLkMqkCN1yPxuHA9S/x7uoLWE fkQohSuAgKK+jshq7DUJgmJpJCvw6v0zg5bvVeSPJkZm1TuxLCHmPHOUfjgHKc43/VCOC4 C3AymrRzH16vDBEjlfcsiAx5uFP4Jkgmox2jTYaMkbWur4ppZQsC7kCbInBeZg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1632637662; a=rsa-sha256; cv=none; b=QX+zb9s6YvQXBIJsrda3ddZglWmddEaRlS1ujh0bJSFxqVAr6LQgoskeBt3fruISqFgKnF wCp/n5TaykUD/4YSCCstnwEg96DnIZBEcF+kXmD1o+XswEn26YZ9sQUZcfy+OsaBFClSTq rh7/wRsTz/ZuJGvSV/QTimcEIfSYIYY5tsducniBUnXYzFyFOPoCr/sozrMs/4+ua9ARmJ sZASoOVmkZ6MwDiZT2VKVzam7+wl/JlOOOHswnOrlfHCxp7v4nMaWL/SvC9B91mBfHqwY+ XCwt4X5eIzp0CYdQOTifGZCkslYX68uU8wSlppk+VTsTp4shI0h5p24xRtYYFQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=mgsn.dev header.s=key1 header.b=HvTKzZz7; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -0.29 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=mgsn.dev header.s=key1 header.b=HvTKzZz7; dmarc=fail reason="SPF not aligned (relaxed)" header.from=mgsn.dev (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 9A4CA2D1DD X-Spam-Score: -0.29 X-Migadu-Scanner: scn1.migadu.com X-TUID: AVVDC4ZCZ5sp Hi, Ludovic Court=C3=A8s writes: >> +(define* (download-git-to-store store url commit >> + #:optional (name (basename url)) >> + #:key (log (current-error-port)) recurs= ive?) >> + "Download Git repository from URL at COMMIT to STORE, either under NA= ME or >> +URL's basename if omitted. Write progress reports to LOG. RECURSIVE? = has the >> +same effect as the same-named parameter of 'git-fetch'." > > Can we use =E2=80=98latest-repository-commit=E2=80=99 instead? The diffe= rence is that > it=E2=80=99ll populate ~/.cache/guix/checkouts, but I think that=E2=80=99= s fine. > > OTOH, if we want to make it easier to support other VCSes, we can choose > to not use (guix git) at all and instead use =E2=80=98git-fetch=E2=80=99 = in (guix > git-download), =E2=80=98hg-fetch=E2=80=99 in (guix hg-download), etc. Th= is code would > go to (guix scripts hash). > > WDYT? Would using 'git-fetch' mean that it's already in the store (and therefore won't be redownloaded) when it's subsequently used in a source? That would be even better than latest-repository-commit! (Presumably --with-commit and friends also use 'git-fetch'?) -- Sarah