From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id kPoYJYG/vWEL9AAAgWs5BA (envelope-from ) for ; Sat, 18 Dec 2021 12:01:21 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id MH/fIIG/vWECDwAA1q6Kng (envelope-from ) for ; Sat, 18 Dec 2021 11:01:21 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5D86E37D33 for ; Sat, 18 Dec 2021 12:01:21 +0100 (CET) Received: from localhost ([::1]:53960 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1myXSp-0006Z0-SH for larch@yhetil.org; Sat, 18 Dec 2021 06:01:19 -0500 Received: from eggs.gnu.org ([209.51.188.92]:59732) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1myXSY-0006Yo-D0 for guix-patches@gnu.org; Sat, 18 Dec 2021 06:01:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:58034) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1myXSY-0003mv-2A for guix-patches@gnu.org; Sat, 18 Dec 2021 06:01:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1myXSX-0005SA-Vo for guix-patches@gnu.org; Sat, 18 Dec 2021 06:01:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#52578] [PATCH] updating openldap and adding service definition Resent-From: zimoun Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 18 Dec 2021 11:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52578 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos , 52578@debbugs.gnu.org Received: via spool by 52578-submit@debbugs.gnu.org id=B52578.163982520920891 (code B ref 52578); Sat, 18 Dec 2021 11:01:01 +0000 Received: (at 52578) by debbugs.gnu.org; 18 Dec 2021 11:00:09 +0000 Received: from localhost ([127.0.0.1]:41347 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1myXRg-0005Qs-T1 for submit@debbugs.gnu.org; Sat, 18 Dec 2021 06:00:09 -0500 Received: from mail-wm1-f43.google.com ([209.85.128.43]:36817) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1myXRe-0005Os-9a for 52578@debbugs.gnu.org; Sat, 18 Dec 2021 06:00:06 -0500 Received: by mail-wm1-f43.google.com with SMTP id y83-20020a1c7d56000000b003456dfe7c5cso4841776wmc.1 for <52578@debbugs.gnu.org>; Sat, 18 Dec 2021 03:00:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:subject:in-reply-to:references:date:message-id:mime-version :content-transfer-encoding; bh=tddXBLRpfLolditLwLdDdt4I+Ir3en3EwEcc2OcEdgM=; b=RiaR2bRa/wCMBsHoQSqjuYDHeAzsfEUy3lOVQzxJiqza6VaLqntpHWsHvbv0eaMI2B HaIOzm+fVmEeZ0EVI5wTJcLWfRJSQpfk5tULarhq8LVqV9vhdYmiFYolhqD0Xv6zx0ms 0ZA+agux9F9740+0srtdM9/r2Xs0zdGCgnVchDuKYYWKHRV9W7NtYAauIQNi+Dkuvi4i +P1xUaN69rDoXn+Is8byJIyx37RW1ZJJTMj2Lt4VMHCyUy6c3WW0NygZcm6gYe5KN1uc qa2Yj+HoWyTHMKuFf21cGH3Ep3tuv425OgQwPv2z1EdkLEbrZj2dgsrAiCaWdemr1Aqm DKKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=tddXBLRpfLolditLwLdDdt4I+Ir3en3EwEcc2OcEdgM=; b=CwBwobO9PeltxbWgwsJu6+0eEojMH4p7bT2WgIR/k0siak+B9xtZyqmT8d7SktqrBl 79OBofUofYxybRyarnNXc57Bzp5rrXyf+OxLUTwnAi18qCIzSJwrMcRHJ0lrbO+G1cSl fcX1SnL9ewBJEzo5bkbk35R4sDO/ZXssPDOxVYJpSS1nDz7WGv7WUp/z6CHTvzj2afZQ pCyUKKcEWMk946InAEBPxYkvf381We6ylARDHKAkw1A5OHKbu6nMdytVyxDnuxZuisgG vxF4YLgtIzc6pCJIXZPqMLCRtYMaoubydnEoQcuh25uPQbCP0M3V8OcA/+L9aaIWOQqv rSQA== X-Gm-Message-State: AOAM533f9EyYOk1cprjC0+CaA2k0EYdmdAEQ77X15kwtFWJoWepROc1v rRFKMeG8YYu0KLylvI1nEsaNIfhOdXk= X-Google-Smtp-Source: ABdhPJwezkWQxwSNIAckt90d94pAZ15NYx3R/eXDFpcds3rD3xi2YEXUBg6UjxyLCLk36io8315Drw== X-Received: by 2002:a05:600c:3489:: with SMTP id a9mr13311737wmq.53.1639825200488; Sat, 18 Dec 2021 03:00:00 -0800 (PST) Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id y3sm7609317wrq.12.2021.12.18.02.59.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Dec 2021 03:00:00 -0800 (PST) From: zimoun In-Reply-To: <48af7ae3214ca223d7b57c0fd5a72c13a9fcbd85.camel@telenet.be> References: <48af7ae3214ca223d7b57c0fd5a72c13a9fcbd85.camel@telenet.be> Date: Sat, 18 Dec 2021 11:53:43 +0100 Message-ID: <868rwiqj48.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1639825281; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=tddXBLRpfLolditLwLdDdt4I+Ir3en3EwEcc2OcEdgM=; b=KI0xVnNI4iB9jdQs9NYs23bhMtGMFEV5UfVhWexdnezwXiS5/cZCX87adM3u+Wt/0aphUW sLRrOJI5qtQt7W+pxFzqiPLzoBcdjWbB8sMT/AQUEmDl9Lb6UB59trA2+HadrS8ju6iYwE /sE1OAAkYu15goVwZGJgQInp1/7UoDWf0b0GVaVcZ8zGjzeF2OtZr4jtxJZYhSiCpjoV6Y TmIGg5FJtm0KylcDCwXfI64VzSTbpwrxkZCOA7KGQbCN8Hyr+T6HWOzDAJQGGhoOjXf2FD mUdf6MZZOmpxwDYc9/Gy6Funb6udXn1cV1eWTzDrULCgaDVXALZM3/F1xI3MjQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1639825281; a=rsa-sha256; cv=none; b=iK9q8KMufwvJMh5PdO2FvmMeM6PtjnQHhZEwuO8n7NiPhOwFGtyZAAhDjSxerPuz+Q4EYu XXH6bN0QqrwpIcgMJW7NocBtwufmiYFG3ZgApgSQPAlDMDzf9dm/NsO0+h+rgfJ3w33D9S dLUkeaxIuthzyJoyoTAv79eT1VWfc7D3Pbm14QxQp5aMew8WRLrahrC1mOQ7YhdjpgQaZo z0Vq5vVCU3uTTEnfeq/zg1e4gkbNMmx+B+faSBOomEKSaVOf1P4aPGEBkHL010F0DbE2pZ B+Bjixkkh2w6CTscWTcEAdRAWoMPEB+iN6prIHJ8N1KqtYsj59k0I6565uZhuw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=RiaR2bRa; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.90 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=RiaR2bRa; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 5D86E37D33 X-Spam-Score: -2.90 X-Migadu-Scanner: scn0.migadu.com X-TUID: pJbuFAdXGH5b Hi Maxime, The package =E2=80=99openldap=E2=80=99 already exists and some of your comm= ents ask about the existing recipe. :-) I think Jean-Fran=C3=A7ois just copy/pasted the current recipe and expand it for their own requirements: having the service they need, IIUC. On Fri, 17 Dec 2021 at 22:39, Maxime Devos wrote: >> + ,@(if (%current-target-system) >> + '("--with-yielding_select=3Dyes" > "ac_cv_func_memcmp_working=3Dyes") >> + '() >> + ) > > is this speculation on what's necessary for cross-compilation, or has > it been determined these flags are necessary? This bits had been added by Mathieu 1c8b1870a60de12f6c19d809522f5d836221513= 1. >>+ #:make-flags '("STRIP=3D") > > Why? This one too. >> + ,@(if (%current-target-system) >> + '( >> + (add-before 'make-depend 'fix-cross-gcc >> + (lambda* (#:key target #:allow-other-keys) >> + (setenv "CC" (string-append target "-gcc")) >> + #t >> + ) >> + ) >> + ) >> + '() > > You can use ,(cc-for-target) here. Also, CC can be set in #:make-flags. Again this one. >> + (synopsis "Implementation of the Lightweight Directory Access > Protocol") >> + (description "OpenLDAP is a free implementation of the > Lightweight Directory Access Protocol.") > > That's a very terse description --- is it a server, a client > application, programming APIs for communicating with a server, or all > of these? Also, no need to mention it's free, everything in Guix is > free. This description is from 2013, 2a75d4e664e802d3a3e2ed6455c63f32541559c8. ;-) Your comments about the package itself make sense but I am not convinced that they are related to the first Jean-Fran=C3=A7ois submission. :-) Cheers, simon