From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id OLhFKdwGdmDniAAAgWs5BA (envelope-from ) for ; Tue, 13 Apr 2021 23:02:20 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id eEwYI9wGdmDpLwAAbx9fmQ (envelope-from ) for ; Tue, 13 Apr 2021 21:02:20 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D16C41B445 for ; Tue, 13 Apr 2021 23:02:19 +0200 (CEST) Received: from localhost ([::1]:46458 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lWQAj-0001Yp-DI for larch@yhetil.org; Tue, 13 Apr 2021 17:02:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49848) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lWQAc-0001YO-MB for guix-patches@gnu.org; Tue, 13 Apr 2021 17:02:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:49440) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lWQAc-00016k-Ec for guix-patches@gnu.org; Tue, 13 Apr 2021 17:02:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lWQAc-0003Af-BW for guix-patches@gnu.org; Tue, 13 Apr 2021 17:02:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47593] [PATCH 6/6] gnu: python-xyz: Add python-abjad. Resent-From: Bonface Munyoki K. Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 13 Apr 2021 21:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47593 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Efraim Flashner Cc: 47593@debbugs.gnu.org, jgart@dismail.de Received: via spool by 47593-submit@debbugs.gnu.org id=B47593.161834766912127 (code B ref 47593); Tue, 13 Apr 2021 21:02:02 +0000 Received: (at 47593) by debbugs.gnu.org; 13 Apr 2021 21:01:09 +0000 Received: from localhost ([127.0.0.1]:60986 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lWQ9f-00039Q-O6 for submit@debbugs.gnu.org; Tue, 13 Apr 2021 17:01:09 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:52253) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lWQ9d-00038R-Hz for 47593@debbugs.gnu.org; Tue, 13 Apr 2021 17:01:02 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 632AB5C012F; Tue, 13 Apr 2021 17:00:56 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Tue, 13 Apr 2021 17:00:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= bonfacemunyoki.com; h=from:to:cc:subject:references:date :in-reply-to:message-id:mime-version:content-type; s=fm1; bh=ETX gJEOME6bnSUGmdc29b86KnjiSGRhX0WVcHEpBp/Q=; b=kIQ5uIzPOuZ5KPeQZme arP3nwe8VzjwKp1i/D78kjJOVhlJgGzY0n1Psb0uwN3K7fmV/b4ZcABVEkbQ8ED7 GghDeXzLbAIFXWKv7/kQqeE98VcoJUggTeNjAeGXlKPYhxgu0iIFqAhPEOl2CqQh u8I17Vq4O6eoXzmm5CTl9lQU6FFfcan8IlKWlon7sIhpQA6U3M8OtUmaMdzHJA8F pRiMKLPfxO+g3Jae/LE0zYuSrDMJR1x+zsZYYBbI97vAwiCMChMnbpeFjvTuEp3o tbg7U14qPQMx+NCKIpF4kjGKtFzg8akeMvEXiZonD7TOJxL1SRnZuCPIBl7QlfWe Ckg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=ETXgJE OME6bnSUGmdc29b86KnjiSGRhX0WVcHEpBp/Q=; b=XbPCM9RWc+qS7T6d69WQJ/ cMy7IS7vqccrvdW342XhH+Q48kl79wN0+24nIBlmxfBKGV20Ft+VEwAOSbPZv5hl cTijEpYhZ+5XjWgMmzIh4IW/1GFvfqAUIZcbjiqN6/YNFMOgCn19RrDqmUQEtcQR O/p8RkImZ20wjhOxiUCfpU6UBMc57TknzuhDzcL581xAaU+xb3UnxcmUOBd1bKdI 81bZ8wTKlRWQvvKhaLFROcDOF8zaWlyIfPjDn1XSxZHAwBYx/UvD3U+bW/Y4TF2a qkp+n6hOxD+RAdTsMRksj3hBlizzbeu3X2SQjWWnpM15fZD7jxlKXjc67pWL/p1w == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudekledgudehjecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enogfuuhhsphgvtghtffhomhgrihhnucdlgeelmdenucfjughrpefhvffufhffjgfkfggg tgesghdtreertdertdenucfhrhhomhepuehonhhfrggtvgcuofhunhihohhkihcumfdruc eomhgvsegsohhnfhgrtggvmhhunhihohhkihdrtghomheqnecuggftrfgrthhtvghrnhep kefgtefhheeuhfeltefgtefhfeehtddvgedvudevkeelffejteelgfelhfffffeinecuff homhgrihhnpehgihhthhhusgdrtghomhdpshhtrggtkhhovhgvrhhflhhofidrtghomhdp ghhithhhuhgsrdhiohdpuhhpsghoohhktghluhgsrdgtohhmnecukfhppeeguddrkedtrd ejvddrheefnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhho mhepmhgvsegsohhnfhgrtggvmhhunhihohhkihdrtghomh X-ME-Proxy: Received: from susa (unknown [41.80.72.53]) by mail.messagingengine.com (Postfix) with ESMTPA id E87AE240065; Tue, 13 Apr 2021 17:00:53 -0400 (EDT) From: Bonface Munyoki K. References: <20210404122005.33127-1-me@bonfacemunyoki.com> <20210404122005.33127-7-me@bonfacemunyoki.com> Date: Wed, 14 Apr 2021 00:00:47 +0300 In-Reply-To: (Efraim Flashner's message of "Tue, 13 Apr 2021 16:14:48 +0300") Message-ID: <867dl5oq68.fsf@bonfacemunyoki.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1618347740; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=ETXgJEOME6bnSUGmdc29b86KnjiSGRhX0WVcHEpBp/Q=; b=jE+M6puHV3Lk3VwPJOaWlYKQ5JHiNwM4ItCmiZK6JtzWH6u94S5/GMzKBFf6LP3M1Zpw9d CFzvbX9fcF7paUcG9OBaKLQmjuMPkWe7Q/jJ2Jk6FzGC2neqBi5Ne85I1FKjABYEms2/Rg H2mK+m3x1iHJ7uCd48cjChlz9tPAMvb7qGpdwf8PAqMcidRI84IuVm6HNQ5UCSjPQMresN WKEbhIvse+bLUSQuwzoqH3A2K8ma6WAqSFyihKcHMK5A+NtGbGfSwHagqNJ217ybiNiIo+ JlvTnIo1u3656v1Sm4D4YBx2BuWPy9gQfqya2YQKuo1NZlmcsAektEGsJ3uObA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1618347740; a=rsa-sha256; cv=none; b=Mel5DkNQu50zHHMEs3+65wj5Wc4/OzzxItqgNWFRkm+XbuPSHqzVeNUtC8glRql8vZCAlW n+LJLqzGy+ZohGiD21S2U2a3PYk6bekLzG9cl+Bj/UK0FpIxYW5bowo+SrMVDwkEsFhfFz euVe3ZWBl7lJOvPRSvT/Xn0IcgVZRQbvZT0Fcc7c03NizB21ptvKNSbUXhHtTP0UYLLmy6 JVNrfLCdtl1NOfGvZ2bfFATGLlunBUtq48lOAgKQ2/BTWbdKAoabR8oXLdljhM8TIzb3KB PqAMVgfMFaInyASfjosy8fT0CU0OFujGEOQ9w08HNvVwDIQ7N/Nrtl6W1jFf8A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=bonfacemunyoki.com header.s=fm1 header.b=kIQ5uIzP; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm2 header.b=XbPCM9RW; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: 1.27 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=bonfacemunyoki.com header.s=fm1 header.b=kIQ5uIzP; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm2 header.b=XbPCM9RW; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: D16C41B445 X-Spam-Score: 1.27 X-Migadu-Scanner: scn0.migadu.com X-TUID: hQOxuu4f7EnL --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Efraim Flashner writes: > I would put this in music.scm near lilypond. > Makes sense. [...] > > If this is a package that would be installed then you can change the > name to abjad, no need to keep the python prefix. > I don't quite get this. Do you mean a package that would be installed and run as some executable as opposed to a library? >> +(define-public python-abjad >> + (package >> + (name "python-abjad") >> + (version "3.3") >> + (source >> + (origin >> + (method url-fetch) >> + (uri >> + (string-append >> + "https://github.com/Abjad/abjad/archive/refs/tags/v" >> + version ".tar.gz")) > > This should be a pypi URI or be downloaded using git-fetch > Noted. >> + (sha256 >> + (base32 >> + "0dvj40g8kq1jdp09gb2chxxb7959vxv5h4m8ywg4qigsw3f11xnx")))) >> + (build-system python-build-system) >> + (arguments >> + `(#:phases >> + (modify-phases %standard-phases >> + (add-after 'unpack 'patch-source >> + (lambda _ >> + (substitute* "setup.py" >> + (("uqbar>=3D0.4.4, <0.5.0") "uqbar>=3D0.4.4, <=3D0.5.1") > > I would just take off the <0.5.0 and not try to make it just high enough > to include the version packaged. > Makes sense! >> + (("pytest>=3D5.4.3") "pytest>=3D5.3")) > > We also have pytest-6. Of course this is also fine. > Sure! >> + #t)) >> + (replace 'check >> + (lambda _ > > (lambda* (#:key tests? #:allow-other-keys) > (when tests? > Noted. >> + ;; See: https://stackoverflow.com/a/34140498 >> + (invoke "python" "-m" "pytest" "tests") >> + #t))))) > > I'm sure that not all of these need to be propagated. The source should > be patched to refer to lilypond and I'm guessing most of the rest can > either be inputs (they'll get wrapped with the python wrapper) or > native-inputs if they're only needed for tests. > Makes a lot of sense! >> + (propagated-inputs >> + `(("lilypond" ,lilypond) ;; Required for tests to pass! >> + ("python-black" ,python-black) >> + ("python-flake8" ,python-flake8) >> + ("python-isort" ,python-isort) >> + ("python-mypy" ,python-mypy) >> + ("python-ply" ,python-ply) >> + ("python-pytest" ,python-pytest) >> + ("python-pytest-cov" ,python-pytest-cov) >> + ("python-quicktions" ,python-quicktions) >> + ("python-roman" ,python-roman) >> + ("python-six" ,python-six) >> + ("python-sphinx-autodoc-typehints" >> + ,python-sphinx-autodoc-typehints) >> + ("python-uqbar" ,python-uqbar))) >> + (home-page "https://abjad.github.io") >> + (synopsis >> + "Abjad is a Python API for building LilyPond files.") > > I'd shorten this to "Python API for building LilyPind files" > Thanks for the suggestions! >> + (description >> + "Abjad is a Python API for building LilyPond files.") >> + (license license:expat))) >> --=20 >> 2.31.0 >>=20 >>=20 >>=20 >>=20 =2D-=20 Bonface M. K. D4F09EB110177E03C28E2FE1F5BBAE1E0392253F Humble GNU Emacs User / Bearer of scheme-y parens Curator: / Twitter: @BonfaceKilz --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJKBAEBCAA0FiEE1PCesRAXfgPCji/h9buuHgOSJT8FAmB2BoIWHG1lQGJvbmZh Y2VtdW55b2tpLmNvbQAKCRD1u64eA5IlP0IQD/wMxUt8Gx2IX1ubBZA7Dkq6Qz/p dwWwBla35pfgrDrdNVDcBaAPejOqWyzzWi/cIPePk3aoupTQeX5L2UEVqdymFXPT jgLptYYFQrlWbAeY8cxNDrc/C/78sHOn2aOvQI4fo3hvzy2EDwYc9GFth0aAbwxm u1YDFzWVKNanp8JYObTr0tbTatcsCjsnJMDzd3XSG7PJcpnLcS71dpyk1MP3J2/s hx6Ap43b7QK8OOD7jOtrkR/oSf3vmn6Zi4cFMouoBvEjJyUKz5Ro83VO1c8t5qPc Xkl8YtrT+Dn4GHEuzZp7Llo3AgouH4KdZHcL2QrRIC58R7JOWDd4TbFss8YBapfu lIQDPB4Ie50nYm0dMdnQvBcrJPHSLLsQXaxx2a4g6KyYIwzdCOg2s+E+ZBtza/Vz iWlKa1/JcfBxjO9RZa0b7wJXuXN2kYeV61Hd4TgTAAXcfHpwnpCUlWNQtDmkddkF fYSVmlRae2DtpuY9xYhNBwf50+GMZd3igxlN968lUi/ff07eI1scL/9F45D9+cvP bHc4cNzwXzxMQDbE49snGlLhwYUJsG9XbkkLuCAZ9DNgUkrq2XzfZgwo1YK3a3b0 lWk3j0Ff/S2k/RHa/3O+nOuEBrXwNn4dvwKwSBrA4wYQ3spBloQl0Huf+qAaISnb sQ4bNsOMco5e9ux2OA== =dQ6J -----END PGP SIGNATURE----- --=-=-=--