From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id GB6ZKxHTI2HKbgEAgWs5BA (envelope-from ) for ; Mon, 23 Aug 2021 18:55:45 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id kOElJxHTI2EvLAAAbx9fmQ (envelope-from ) for ; Mon, 23 Aug 2021 16:55:45 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 60735FAF9 for ; Mon, 23 Aug 2021 18:55:45 +0200 (CEST) Received: from localhost ([::1]:38772 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mIDEe-0002ny-EV for larch@yhetil.org; Mon, 23 Aug 2021 12:55:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51620) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mIDD1-0007F5-1V for guix-patches@gnu.org; Mon, 23 Aug 2021 12:54:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:59221) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mIDCz-0006GZ-QL for guix-patches@gnu.org; Mon, 23 Aug 2021 12:54:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mIDCz-0003JU-J4 for guix-patches@gnu.org; Mon, 23 Aug 2021 12:54:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49867] [PATCH v2 13/31] gnu: Add ocaml-mirage-crypto. Resent-From: pukkamustard Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 23 Aug 2021 16:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49867 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: pukkamustard Cc: 49867@debbugs.gnu.org, Julien Lepiller Received: via spool by 49867-submit@debbugs.gnu.org id=B49867.162973758212673 (code B ref 49867); Mon, 23 Aug 2021 16:54:01 +0000 Received: (at 49867) by debbugs.gnu.org; 23 Aug 2021 16:53:02 +0000 Received: from localhost ([127.0.0.1]:42534 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mIDBy-0003I0-AR for submit@debbugs.gnu.org; Mon, 23 Aug 2021 12:53:02 -0400 Received: from mout02.posteo.de ([185.67.36.66]:50183) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mIDBs-0003Hi-31 for 49867@debbugs.gnu.org; Mon, 23 Aug 2021 12:52:57 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 772C3240105 for <49867@debbugs.gnu.org>; Mon, 23 Aug 2021 18:52:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1629737565; bh=j7cQKnKmP3JMnOPNGb5w0Vlvc0sC6Z5o56/JZ+6nnBs=; h=From:To:Cc:Subject:Date:From; b=lPZHsomkS53eXyIJlkTd8Q4U3hngbL3nlF1a74YUHGgUsmg3u/qwMtGZk2j1SZNdL NU4F8k6DaGwDZW3vwDtq7XK2Vh61CaIomWUICKxxQwNl9qwS4e0Rmp8XCBT/ho9RRI nNQ3rXjBILCHIbfpGp7seFKkELQYGbG41XFCmnO8GmE+sVJXSJ+4jgCHvnzh5AiQzi jTSTAl/fvjfnwxMFfQdWOrpiCyYmCpNXI3aJnhGBcXzB2rlnlc+mkWTIxu6lE18Eq5 h4dTohYDUtOEXQtIqxSNaF325JNT0wOMnHt15AdWabimnGDKAWkk0EEpXptgubX8Sr UqpXlOR0Yf17g== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Gtdb0033vz6tmG; Mon, 23 Aug 2021 18:52:43 +0200 (CEST) References: <86pmun5cp5.fsf@posteo.net> <20210809070124.25641-1-pukkamustard@posteo.net> <20210809070124.25641-13-pukkamustard@posteo.net> <20210821160154.407b4928@tachikoma.lepiller.eu> <86a6l8qlrf.fsf@posteo.net> From: pukkamustard In-reply-to: <86a6l8qlrf.fsf@posteo.net> Date: Mon, 23 Aug 2021 16:52:42 +0000 Message-ID: <867dgcqf1h.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1629737745; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=w66Bh52RFuE5HV+9Sh2OLe1mwb3UADoCuX8T+fjg0mQ=; b=foM7RDA3yg7JZueFgMVgf0DeJRiiQKwZuPpCc2ZgXqzlZmJf4P261/SoG8AyQu/D3PqA8p 26v2oNRN3vS6mMsocRf82BOAK3RypYtJWx7Pm9tfwP8N8sRm8DYcQVB0Rko0XPGfSUv5Fj j6S4/39fwjfk5AmNXrF2E7wLIuk5vrSLx8XVepNR19rjDuvB04O51JIvvotfM6IecPLFcn T1UWcpd3+SLP0XVIcYrz93atxdYoRQ+ICztCN1gBcgaxbT7ACg3POddOD2+6wKbIHuBIwS eC/sXWQDsuU1QcWnY+r8/FG53aYpaZFavljfIMBGrpTNch2KYawpmb9Q/GytXQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1629737745; a=rsa-sha256; cv=none; b=Oq0nthLfczFo/6KUsAHX5/0PfwTTdURp8RFssb37RIUaN6ulK+M5hriFNcVx5VYWOabyh0 +s2zqThaZr03ZaKo0pFQ5jivao4O3CYfagQfvBWN3vpa2q6M63UtlPmC3j2S4qy1m+UKUg sblbOWGNcRoWKPCzIQECzUrxOwwRzGvyva+mktdV9Kr7dlxCmXuOGgeI7QgldR+Z0bJCif VGxKHufWdj9GG38VaHb4tFBbE0kYd3q6r1ttiK225oq6/xEEPeaVsDoGJIJQq3lTfth+mU hR7s7rW8mbepqnulBehVkLJh3Q3mBqi3qIJhBm0bbYeyxkuN3ddO3Y2BXnk66w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=lPZHsomk; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.32 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=lPZHsomk; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 60735FAF9 X-Spam-Score: -1.32 X-Migadu-Scanner: scn0.migadu.com X-TUID: fSLh6g1U9ZfH pukkamustard writes: > Julien Lepiller writes: > >> Trying to build ocaml-mirage-crypto, I get errors during the >> tests: >> >> ocamlopt tests/test_symmetric_runner.exe (exit 2) >> >> Error: Files >> /gnu/store/id3dchcsw5gijsnn73kw5sn9ymjj90ai-ocaml-eqaf-0.7/lib/ocaml/site-lib/eqaf/bigstring/eqaf_bigstring.cmxa >> and >> /gnu/store/id3dchcsw5gijsnn73kw5sn9ymjj90ai-ocaml-eqaf-0.7/lib/ocaml/site-lib/eqaf/eqaf.cmxa >> make inconsistent assumptions over implementation Eqaf >> >> this seems to indicate Eqaf did not build properly? Does it >> build for >> you? > > Negative. Can confirm that ocaml-mirage-crypto does not build > when rebased on > master. I will investigate. This seems to be related to the recently added dune profile parameter (https://issues.guix.gnu.org/49868). The installed eqaf.cmxa seems to be the one built by using the "dev" profile, whereas eqaf_bigstring.cmxa is expecting the Eqaf module built with the "release" profile: ``` $ ocamlobjinfo /gnu/store/id3dchcsw5gijsnn73kw5sn9ymjj90ai-ocaml-eqaf-0.7/lib/ocaml/site-lib/eqaf/bigstring/eqaf_bigstring.cmxa [..] Implementations imported: 193f160ab58c2c455f4e1fe1425b8971 Eqaf [..] $ ocamlobjinfo /gnu/store/id3dchcsw5gijsnn73kw5sn9ymjj90ai-ocaml-eqaf-0.7/lib/ocaml/site-lib/eqaf/eqaf.cmxa [..] CRC of implementation: f693310ffd4f92f54cd1fde8271782b8 [..] ``` With (arguments `(#:profile "dev")): ``` $ ocamlobjinfo /gnu/store/v2s1h1is0ci2ij2h8k5fbna3j8ycrw9y-ocaml-eqaf-0.7/lib/ocaml/site-lib/eqaf/bigstring/eqaf_bigstring.cmxa [..] Implementations imported: [..] -------------------------------- Eqaf $ ocamlobjinfo /gnu/store/v2s1h1is0ci2ij2h8k5fbna3j8ycrw9y-ocaml-eqaf-0.7/lib/ocaml/site-lib/eqaf/eqaf.cmxa [..] CRC of implementation: f693310ffd4f92f54cd1fde8271782b8 [..] ``` When using the "dev" profile the ocaml-eqaf and ocaml-mirage-crypto build and pass the checks. (I assume that the missing CRC in eqaf_bigstring.cmxa means it does not check the CRC of the Eqaf implementation.) If I set (arguments `(#:package "eqaf")), then also everything builds fine and the hashes seem to be right: ``` $ ocamlobjinfo /gnu/store/cyw1n07cqdh25w5awww185s44yzbcyss-ocaml-eqaf-0.7/lib/ocaml/site-lib/eqaf/bigstring/eqaf_bigstring.cmxa Implementations imported: 193f160ab58c2c455f4e1fe1425b8971 Eqaf $ ocamlobjinfo /gnu/store/cyw1n07cqdh25w5awww185s44yzbcyss-ocaml-eqaf-0.7/lib/ocaml/site-lib/eqaf/eqaf.cmxa CRC of implementation: 193f160ab58c2c455f4e1fe1425b8971 ``` This seems weird. I don't understand why dune installs the eqaf.cmxa built with "dev" profile but eqaf_bigstring.cmxa with "release" profile. Maybe this is a bug in dune? It does seem that using the dune "--profile" options on its own is not very common. Opam uses the dune "-p" option. This sets the profile to "release" and does a couple of other things (https://dune.readthedocs.io/en/stable/opam.html?highlight=build%20profile#invocation-from-opam). I don't think many people use the "--profile" option on its own. For our dune-build-system I think it makes more sense to always use the "-p" flag. This requires adding the explicit OCaml package(s) to many specifications in Guix. I also think the "profile" parameter should be removed as the interactions with the "package" parameter (dune "-p") are not as expected. Sorry for not doing this research before submitting the patch that added the "profile" parameter. Thoughts? -pukkamustard