unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Sarah Morgensen <iskarian@mgsn.dev>
To: Maxime Devos <maximedevos@telenet.be>
Cc: 49813@debbugs.gnu.org
Subject: [bug#49813] [PATCH 04/34] gnu: tao: Fix regex in FIND-FILES invocation.
Date: Sat, 28 Aug 2021 15:59:32 -0700	[thread overview]
Message-ID: <867dg52n1n.fsf@mgsn.dev> (raw)
In-Reply-To: Maxime Devos's message of "Sun, 22 Aug 2021 11:53:24 +0200 (6 days, 13 hours, 3 minutes ago)"

Hi Maxime,

Thanks for taking a look at this.

Maxime Devos <maximedevos@telenet.be> writes:

> Sarah Morgensen schreef op zo 01-08-2021 om 14:18 [-0700]:
>> -                         (find-files "include" "\\.h"))
>> +                         (find-files "include" "\\.h$"))
>
> C++ header files are sometimes named "something.hpp" instead
> of "something.h", so you might want to verify these don't exist.
> (And if they do exist, keep the regex "\\.h", or make it "\\.(h|hpp)$"?)
>
> Likewise for 'kaldi', 'shogun' and 'rtags'.  Otherwise, these
> new regexes look good to me (but I didn't test them).

Good catch.  I just checked the sources for all of those, and I can
verify that they don't exist.  (Shogun and rtags do have .hpp files in
their source, but only in other directories.)

--
Sarah




      parent reply	other threads:[~2021-08-28 23:00 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-01 21:16 [bug#49813] [PATCH 00/34] Fix regexes in FIND-FILES invocations Sarah Morgensen
2021-08-01 21:18 ` [bug#49813] [PATCH 01/34] gnu: wpa-supplicant-minimal: Fix regex in FIND-FILES invocation Sarah Morgensen
2021-08-01 21:18 ` [bug#49813] [PATCH 02/34] gnu: hostapd: " Sarah Morgensen
2021-08-01 21:18 ` [bug#49813] [PATCH 03/34] gnu: infamous-plugins: " Sarah Morgensen
2021-08-01 21:18 ` [bug#49813] [PATCH 04/34] gnu: tao: " Sarah Morgensen
2021-08-22  9:53   ` Maxime Devos
2021-08-01 21:18 ` [bug#49813] [PATCH 05/34] gnu: kcov: " Sarah Morgensen
2021-08-01 21:18 ` [bug#49813] [PATCH 06/34] gnu: astyle: " Sarah Morgensen
2021-08-01 21:18 ` [bug#49813] [PATCH 07/34] gnu: unshield: " Sarah Morgensen
2021-08-01 21:18 ` [bug#49813] [PATCH 08/34] gnu: cook: " Sarah Morgensen
2021-08-01 21:18 ` [bug#49813] [PATCH 09/34] gnu: libabigail: " Sarah Morgensen
2021-08-01 21:20 ` [bug#49813] [PATCH 10/34] gnu: grfcodec: " Sarah Morgensen
2021-08-01 21:20 ` [bug#49813] [PATCH 11/34] gnu: go-github-com-keybase-go-ps: " Sarah Morgensen
2021-08-01 21:20 ` [bug#49813] [PATCH 12/34] gnu: guile-sly: " Sarah Morgensen
2021-08-01 21:20 ` [bug#49813] [PATCH 13/34] gnu: g-wrap: " Sarah Morgensen
2021-08-01 21:20 ` [bug#49813] [PATCH 14/34] gnu: guile-ncurses: " Sarah Morgensen
2021-08-01 21:20 ` [bug#49813] [PATCH 15/34] gnu: guile-gi: " Sarah Morgensen
2021-08-01 21:20 ` [bug#49813] [PATCH 16/34] gnu: guile-ac-d-bus: " Sarah Morgensen
2021-08-01 21:20 ` [bug#49813] [PATCH 17/34] gnu: belle-sip: " Sarah Morgensen
2021-08-01 21:21 ` [bug#49813] [PATCH 18/34] gnu: python-libsvm: " Sarah Morgensen
2021-08-01 21:21 ` [bug#49813] [PATCH 19/34] gnu: kaldi: " Sarah Morgensen
2021-08-02  3:27 ` [bug#49813] [PATCH 20/34] gnu: kaldi-gstreamer-server: " Sarah Morgensen
2021-08-02  3:27 ` [bug#49813] [PATCH 21/34] gnu: tensorflow: " Sarah Morgensen
2021-08-02  3:27 ` [bug#49813] [PATCH 22/34] gnu: sendmail: " Sarah Morgensen
2021-08-02  3:27 ` [bug#49813] [PATCH 23/34] gnu: scotch: " Sarah Morgensen
2021-08-02  3:27 ` [bug#49813] [PATCH 24/34] gnu: atlas: " Sarah Morgensen
2021-08-02  3:27 ` [bug#49813] [PATCH 25/34] gnu: hypre: " Sarah Morgensen
2021-08-02  3:27 ` [bug#49813] [PATCH 26/34] gnu: qtpass: " Sarah Morgensen
2021-08-02  3:27 ` [bug#49813] [PATCH 27/34] gnu: john-the-ripper-jumbo: " Sarah Morgensen
2021-08-02  3:27 ` [bug#49813] [PATCH 28/34] gnu: python-robotframework-sshlibrary: " Sarah Morgensen
2021-08-02  3:27 ` [bug#49813] [PATCH 29/34] gnu: python-cram: " Sarah Morgensen
2021-08-02  3:27 ` [bug#49813] [PATCH 30/34] gnu: aegis: " Sarah Morgensen
2021-08-02  3:27 ` [bug#49813] [PATCH 31/34] gnu: bullet: " Sarah Morgensen
2021-08-02  3:27 ` [bug#49813] [PATCH 32/34] gnu: shogun: " Sarah Morgensen
2021-08-02  3:27 ` [bug#49813] [PATCH 33/34] gnu: alpine: " Sarah Morgensen
2021-08-02  3:27 ` [bug#49813] [PATCH 34/34] gnu: rtags: " Sarah Morgensen
2021-08-28 22:59 ` Sarah Morgensen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=867dg52n1n.fsf@mgsn.dev \
    --to=iskarian@mgsn.dev \
    --cc=49813@debbugs.gnu.org \
    --cc=maximedevos@telenet.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).