From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id EBvkBNLsLWHEgwAAgWs5BA (envelope-from ) for ; Tue, 31 Aug 2021 10:48:18 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id +FR2ANLsLWEUNwAAbx9fmQ (envelope-from ) for ; Tue, 31 Aug 2021 08:48:18 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B1DA61A914 for ; Tue, 31 Aug 2021 10:48:17 +0200 (CEST) Received: from localhost ([::1]:40778 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mKzRH-0000vO-Os for larch@yhetil.org; Tue, 31 Aug 2021 04:48:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59618) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mKzOB-0006tu-UE for guix-patches@gnu.org; Tue, 31 Aug 2021 04:45:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:49559) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mKzOA-0003kw-LN for guix-patches@gnu.org; Tue, 31 Aug 2021 04:45:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mKzOA-00076j-IS for guix-patches@gnu.org; Tue, 31 Aug 2021 04:45:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49780] [PATCH 00/14] import: Use PARSE-COMMAND-LINE for options. Resent-From: zimoun Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 31 Aug 2021 08:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49780 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= , Sarah Morgensen Cc: 49780@debbugs.gnu.org Received: via spool by 49780-submit@debbugs.gnu.org id=B49780.163039944827242 (code B ref 49780); Tue, 31 Aug 2021 08:45:02 +0000 Received: (at 49780) by debbugs.gnu.org; 31 Aug 2021 08:44:08 +0000 Received: from localhost ([127.0.0.1]:32872 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mKzNH-00075J-Vo for submit@debbugs.gnu.org; Tue, 31 Aug 2021 04:44:08 -0400 Received: from mail-wr1-f46.google.com ([209.85.221.46]:44015) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mKzNC-00074f-OM for 49780@debbugs.gnu.org; Tue, 31 Aug 2021 04:44:06 -0400 Received: by mail-wr1-f46.google.com with SMTP id b6so26369037wrh.10 for <49780@debbugs.gnu.org>; Tue, 31 Aug 2021 01:44:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-transfer-encoding; bh=lVoMqwM6LVnA9u6F2FSexzQbHvndvf8paS6atse09k8=; b=fQr4cCXWTc4us+xEtSv76G2CnUkPk82R8suCnkbzGEI69wJjfjsGgeWLuWlAkWDkNn 9+65T0oRv3jwy5usp7EN3/OQ7NDXdaAXn/Qqq9h97fQbMBQuM6wBRmn+82JOIokSr7ln PK06wf8wSvZLpvCcp4qKdcRkDEJymjbsXI4WkHlRoRf9DIeKS39tSWT5UOU9sf6OwTfw H5IDGs0W7S9Jv5KrHm/4DFlTPN3jIoj0SManw3BqXR6iLAnf/VWyYFMEuLxF+R4L4aua X85DaIR9mtePSO2aTgqP4WpwXaL1AxC6D+G0za6ylBeCQ2C9a62daub8v9pefAWh+pMg ogpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=lVoMqwM6LVnA9u6F2FSexzQbHvndvf8paS6atse09k8=; b=YXDMb4c3sqjvfhN9VKCkoZ24rHsylMBlCsk2pH/vS+lLYoezwF+VJ+/WFRo9dmJRqA y3t6YGUljhGEh71wQumK6uDeZGE91ZcJUAMDS1IuOpNQiOiVnxDcmKYTf7pveVuL6brS 6+j1TdL8rNIlQVEKcxp9AKDjjDM6dEhmWEe62tiG0A73qy+FhcRQA5BiSbrVjW5yc8dY TWPDJM6DwK33OavTgvphStbJjSycXInbjyRnMRgIEXhBDJoHDW9A/JUHMv01Xm8vbRvU Liq842CiEDKhWXlgt4WreWWFsC/vEczA2PZu/hKl2y18QP7+B7kRTE5iVkIZey2SQv8N hoNQ== X-Gm-Message-State: AOAM532M9ZhJ7PqYU01S2utHBMGMGhSXGy8Qx+ZAl/O61+mKNeSEmclg fo0RDI+I/RKYFHVaWu6SC1K5HHyVfwGT1A== X-Google-Smtp-Source: ABdhPJyicGiyjENe9LbHWN9oNIbs4SNDbHFXGfhj6jTBc/WNWnsHulTk99AQhYldfoSIikw5/U2Fdg== X-Received: by 2002:adf:ec8b:: with SMTP id z11mr30136929wrn.122.1630399436852; Tue, 31 Aug 2021 01:43:56 -0700 (PDT) Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id n8sm17748196wra.24.2021.08.31.01.43.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Aug 2021 01:43:56 -0700 (PDT) From: zimoun In-Reply-To: <87czquttrx.fsf@gnu.org> References: <87czquttrx.fsf@gnu.org> Date: Tue, 31 Aug 2021 10:24:12 +0200 Message-ID: <867dg210pf.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1630399697; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=lVoMqwM6LVnA9u6F2FSexzQbHvndvf8paS6atse09k8=; b=EM2iIX7xzQdGuaZhptH7CRcy2sc+XnNPxBUCkz6PWvjHL9Ds+XzD0K4We+30AOiZE+WfNs LeZrIpm7hDXjzPg93wKQy7aRfgFFvRf7Rb4s9X66CFEMLK8DZfLpy8N3uFyrg1Tzbql8Ls 5cVM2gd/ug2U4DMuqFSzHIQQm5z0GGIxGLZiIcO3QcTRQ0WTeLb41iDOyLBIOf6eN8dm8D e0dVTx/aeoPFyXjFWK58PZRfhD+Po+OSok2FFwDuMojWI/9r/9RTUcOAjdv6b456BYk1+5 +RNLujcpn5NUR1iwEkA4hWG2DmijJmio5DLo1A89ci1teOHQQAN/b9R0mVONbA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1630399697; a=rsa-sha256; cv=none; b=hDvq4IQ+Do5lgbE2RipznKS7sCQvI/r/V+/2fd1oGu6nlzCV5MWgzm3J26hqeP/3Pf55Ui vgJ66KBbzywV83NwTyOAsd8ic+Qm7/Ejv9oEsWTaIlrSm9CjmrCuGIk4PlHqK8+A0nGadv epBvqAXBgieQIRUmI5jA7hiPddvTrfeeySzDx7Zoa6Fcu3oTZXFd5OoH1ov6GF+SFWs4Wl djFA2dgSLWZhPm+jH7/eIfoj8sqXc6qq+ZbCg6DOtAwtpO9Mx+gI7YviwC2VHJdxsNjzb4 v82Vy/WQMDdkbbV+UtWL+R/+VpGfQDGpe5hHpLUq4HD6ap9CmY5LSDI+pRWx1Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=fQr4cCXW; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.32 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=fQr4cCXW; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: B1DA61A914 X-Spam-Score: -1.32 X-Migadu-Scanner: scn0.migadu.com X-TUID: bfdR+Qc5pLDh Hi, Cool! Thanks Sarah for the improvement. On Tue, 03 Aug 2021 at 17:47, Ludovic Court=C3=A8s wrote: > Sarah Morgensen skribis: > >> I noticed that we have an ARGS-FOLD* wrapper called PARSE-COMMAND-LINE w= hich has >> the same invalid argument message as the importers, the same argument ha= ndler, >> and has an option hint feature. So let's use that in the importers. >> >> The change is identical across all importers, and the semantics as far a= s return >> value are identical, so this should just be a drop-in. > > Neat, that=E2=80=99s a welcome change. I hope you won=E2=80=99t hate me = for suggesting > this, but I think such systematic API evolution changes can go in a > single commit. WDYT? Well, the previous replacement before the introduction of option hint had been done with several commits. ;-) --8<---------------cut here---------------start------------->8--- 4056ba3645 scripts: show: Replace 'args-fold*' by 'parse-command-line'. [...] 946f563d91 scripts: describe: Replace 'args-fold*' by 'parse-command-line'. --8<---------------cut here---------------end--------------->8--- Whatever, now it is pushed. :-) Cheers, simon PS: For the interested reader, the story is not complete yet, the subcommands =E2=80=9Cguix system=E2=80=9D does not enjoy such. ;-)