From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id gJNeKV/ShmG6jgAAgWs5BA (envelope-from ) for ; Sat, 06 Nov 2021 20:07:11 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id EPTlJF/ShmHGYQAAbx9fmQ (envelope-from ) for ; Sat, 06 Nov 2021 19:07:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E6F0B36605 for ; Sat, 6 Nov 2021 20:07:10 +0100 (CET) Received: from localhost ([::1]:47106 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mjR1y-0008DA-0S for larch@yhetil.org; Sat, 06 Nov 2021 15:07:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57910) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mjR1s-0008Cw-Hq for guix-patches@gnu.org; Sat, 06 Nov 2021 15:07:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:39147) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mjR1q-0007Jn-Oz for guix-patches@gnu.org; Sat, 06 Nov 2021 15:07:04 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mjR1q-0003kt-ES for guix-patches@gnu.org; Sat, 06 Nov 2021 15:07:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47754] [PATCH] gnu: transformations: fix with-latest option for git source package. Resent-From: zimoun Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 06 Nov 2021 19:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47754 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Z572 <873216071@qq.com> Cc: 47754@debbugs.gnu.org Received: via spool by 47754-submit@debbugs.gnu.org id=B47754.163622561014404 (code B ref 47754); Sat, 06 Nov 2021 19:07:02 +0000 Received: (at 47754) by debbugs.gnu.org; 6 Nov 2021 19:06:50 +0000 Received: from localhost ([127.0.0.1]:50693 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mjR1e-0003kG-2E for submit@debbugs.gnu.org; Sat, 06 Nov 2021 15:06:50 -0400 Received: from mail-wm1-f53.google.com ([209.85.128.53]:37614) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mjR1c-0003jy-BZ for 47754@debbugs.gnu.org; Sat, 06 Nov 2021 15:06:49 -0400 Received: by mail-wm1-f53.google.com with SMTP id y84-20020a1c7d57000000b00330cb84834fso12013470wmc.2 for <47754@debbugs.gnu.org>; Sat, 06 Nov 2021 12:06:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=o44N8jhjiCLIahEvQ5ESYjaO0rttJGnBPyr4ZzvyBgw=; b=C3xfAroySoaGDcUHMglPy1ac3lPzlGHyZi7XYM9xaYBSrp0mlZceUez+knH/40t7pv le8g0modAJcSymm6UGDnzv4x970dM9AJJPSJhRtDVZ0Z5WmLlQSusHFkDn/5RDhERzDX BN+g2f0l0ziiAfa6XIkHxJbpN4JSGmsb1Tbxb701vuRMQf1u0oiS5qlTySQ9cQ+Qrk2W a/eBSgVYmHjKlVTANAdcIGToJsj4A4PYt92twFZZD10y7ebCxH73pBAza3WWegixisen t7P+3hcVkrbKdpDdfAaEk/jmE7xUKCoqHBg9b9y9HTk+Ay335LqvaPxo2nZpxYSiFwea 4OyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=o44N8jhjiCLIahEvQ5ESYjaO0rttJGnBPyr4ZzvyBgw=; b=wPGMBkun0byT8d6Nlupe0ybHZrwx5hKYodruC6erno4BxbExX0tSM4rMeQRcJFJIJJ jHNig1j/V2SVT89sQhfkjBtR138mhakLmUkNPY51ILsh+3hcV4Ot1yDrNIIRdjq8k3m1 yQ9gSsui4ErdT7wOR/He1YRUfu2L/20gwEnVORf/hM4UelGHoeMr1WcWR0y3yiyEGtHz uaVmwp8y3XhBgbDiJ2tmGsxrAaziux4SvRJrsjZbmJBNL5SYJguuC8JVgYK94icnyomn T+RIE9K8vB0vkF6kZEJ4GtAFuvVcyB6tXzheENNLsl3cYX85E3txccNzoIpZ5bLSexd8 0SPg== X-Gm-Message-State: AOAM533uqV5s4pVQEZwKaKf3Ssx8vvcd5Qc9k9rikfHGBZ7W7bLtnmq/ s3Q55EauFacGutl4whQp+Q/AMF5p0zFl/A== X-Google-Smtp-Source: ABdhPJyOuiPVCZ5JkJVQxGpYZ3BehpCFupkHZOmAPYkDhtl/q56w+XBKtfBT0w12w1QN8/l/+WYlMg== X-Received: by 2002:a05:600c:4f0f:: with SMTP id l15mr21937472wmq.25.1636225602304; Sat, 06 Nov 2021 12:06:42 -0700 (PDT) Received: from lili (pop.92-184-112-12.mobile.abo.orange.fr. [92.184.112.12]) by smtp.gmail.com with ESMTPSA id k21sm10948053wmj.45.2021.11.06.12.06.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Nov 2021 12:06:41 -0700 (PDT) From: zimoun In-Reply-To: References: <87y265sfsr.fsf@gmail.com> Date: Sat, 06 Nov 2021 19:17:05 +0100 Message-ID: <867ddldu8u.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1636225631; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=o44N8jhjiCLIahEvQ5ESYjaO0rttJGnBPyr4ZzvyBgw=; b=aahvjkhe8ydA0zvFvs9dL4LzwPCshG1ZSsao0KKKH0Bq7uw74qXw6k2Oj8Nr+kAk3ewyEM ezQ/TNfp7+y3PepHl65TlrGdS3nUsC5sWWjz6U41jvWiRcr7772CHqBfmti7XQ8oQ+TkeH PVrdMpVva+q0/KtHjb4Wh+98JBHATpouAkPIUWpMORMVCAAhgiV+UIM6Rxp2Ux+XEMFrZw N/z+kNm4+1JcMaS+Rzky0oscnVP15hNKz87JzHPIO+EU5k5sCmsUYKzgVnrQiJAt4ki9Au aZfieCG0T441YeTL1ExyP6au/XfSolFuycmcJ3PUT9p6ddVkLEzLAMD7TrGnJw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1636225631; a=rsa-sha256; cv=none; b=UZhlPu3rTn1hZHYZ31V5zJzRUK7XoMuExiRoWCqCtVbGxXrjo2YaC1iXc5/g4v9ORXfQU3 gO24EwEYej8I4wg/yWVCJgf6HcVxsqPx7u0rOtmv0sI0o44mYC63Ex4j1MKkx0wkfX/t32 urTmpGUWnIyIREfMzXl032bZgwLDnej2rUif+LzGJUdxd6QSaPdSeiAfc1PO8b2A1kowLa ba50tWhLJ+z+s2mEi5BTC/3Ig0Vru9I0wGfwiVq3wI01LedSajupqErqOgRAKZWzMk5a/8 mqd6H/gtn+bOHHByT3PghodWhP3ECftPH4xQSasYr8HecA7xR2u64RSKkbYXpw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=C3xfAroy; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.32 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=C3xfAroy; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: E6F0B36605 X-Spam-Score: -1.32 X-Migadu-Scanner: scn0.migadu.com X-TUID: NrBvKhd0xY9H Hi, On Thu, 04 Nov 2021 at 19:17, Z572 <873216071@qq.com> wrote: >>> If a package is a git source package, after use "with-latest" >>> option, it's url >>> will become to it's source. and build will fail. >>> >>> This patch just fix this. >> >> I see. However, I am not convinced your example is correct, because >> for instance, >> >> $ file $(guix build r-soupx -S) >> /gnu/store/1z0j6i4a9xwwd8d3955m7vq3f1x4p3aq-r-soupx-0.3.1-1.a3354be-checkout: >> directory >> >> What you are seeing is: Git upstream source is modified by Guix (for >> instance, patches are applied or files are removed; in the field >> 'origin') and "guix build -S" returns what Guix actually builds, not >> what upstream provides. Therefore, in this case, the modified source >> is returned as compressed archive. However, when using the >> transformation 'with-latest', in this case, "guix build -S >> --with-latest" returns what upstream provides, thus a directory (or >> something else as a file). > > I looked source again, just because of "upstream-source-compiler" don't support > git source package, all will become to use url-fetch. [...] > I'm have no idea how to change it, so i just check if package is > git-source, use "git-checkout" instead of "upstream-source". >> Maybe I miss something, but from me, the inconsistency comes from the >> behavior of "guix build -S", not about the behaviour of 'with-latest' >> transformation. And I also miss why the build would fail. I am sorry if I misread you. What are you trying to solve? Cheers, simon