From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id ECluOjc2w2Fz0gAAgWs5BA (envelope-from ) for ; Wed, 22 Dec 2021 15:29:11 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id EMkYNjc2w2FDQQAAB5/wlQ (envelope-from ) for ; Wed, 22 Dec 2021 14:29:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 953271CFD8 for ; Wed, 22 Dec 2021 15:29:11 +0100 (CET) Received: from localhost ([::1]:54170 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n02cA-0001FZ-Qm for larch@yhetil.org; Wed, 22 Dec 2021 09:29:10 -0500 Received: from eggs.gnu.org ([209.51.188.92]:53472) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n02c2-0001F3-Kn for guix-patches@gnu.org; Wed, 22 Dec 2021 09:29:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:45622) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n02c2-0005Xs-9b for guix-patches@gnu.org; Wed, 22 Dec 2021 09:29:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n02c2-00044g-1Z for guix-patches@gnu.org; Wed, 22 Dec 2021 09:29:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#52731] [PATCH] import: texlive: Check if Subversion is installed. Resent-From: zimoun Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 22 Dec 2021 14:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52731 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Xinglu Chen , Liliana Marie Prikler , 52731@debbugs.gnu.org Received: via spool by 52731-submit@debbugs.gnu.org id=B52731.164018329115604 (code B ref 52731); Wed, 22 Dec 2021 14:29:01 +0000 Received: (at 52731) by debbugs.gnu.org; 22 Dec 2021 14:28:11 +0000 Received: from localhost ([127.0.0.1]:57168 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n02bC-00043b-Jc for submit@debbugs.gnu.org; Wed, 22 Dec 2021 09:28:10 -0500 Received: from mail-wr1-f42.google.com ([209.85.221.42]:40523) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n02bB-00043O-9t for 52731@debbugs.gnu.org; Wed, 22 Dec 2021 09:28:09 -0500 Received: by mail-wr1-f42.google.com with SMTP id q16so5284773wrg.7 for <52731@debbugs.gnu.org>; Wed, 22 Dec 2021 06:28:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:subject:in-reply-to:references:date:message-id:mime-version :content-transfer-encoding; bh=4vn3aO5mTGnI3Egx83ZUOMPUG4KRXXb+xZzpG/9L1x0=; b=H05TOhe0VT4JlSRRVjOOUtpQrMAY/BgAP+UG3nJsQpoTlpZLoDJ9H/4nUgEZmtm/CK mVWKPWld4Cr+7Hu8DDFii0Spen8zzUbJ9hYOpNYaOejMAIiE5OTt6EdVcbqgJ7ZrZzX4 M2e6tto6TE5D4MO2wejqilZBsbsFW9Uir5p8XgSKdTgQJX05BUcWymX7ocH9tRKNjLUm 5d3Fxmb9ANFS7aCwoPd4WWNERko7osFocbWaj+Ys1Le6p+j6mK36kqFV5fif1HuRa3nE PyW4BLTippO+rVAfGHM5OdrYLi6lWMXLpjby5GSLiNG1bnxjUE5pSEb+u3hOxqUSl3lN Z4vQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=4vn3aO5mTGnI3Egx83ZUOMPUG4KRXXb+xZzpG/9L1x0=; b=Rykf8aJcgrrNfAgM2wSyFU+76f2pO1o+rFGXOzeDeGOZNb7GiAWvL1F+0B4kUNLSaW 9rXvnE0+UkJ8jnKbkMplP1EbL7r79BCpwTnxCVsiZvtD8PhBJzQhDvGwRJL5SQann9dZ tayat74RTZbopcWrVYHcyWEJsMnJCCDcXpxzL+706xrv/8hZgWk6M93z5lNCvI/yqw0V X+UkW7ktOJQ9VMz1H7tvNP+wqD3eluISkfmG23LZAng/6gKeg2xhWwseWJdXyLLrkYAh vnQ8TNRhrf3ZSdVTdWP2fpnQzH6uiwC+FVG8OFxZ9OXps0m6uVRwbI0j5pMvwhzhsNnl pLhw== X-Gm-Message-State: AOAM532FPHPpHVU9vwfh2gUCs1pmywlUCsJsg95qTkIgLyrcu7U3qez0 YZUd5pRjPkRI7WVVuD+5smE+t0YTghk= X-Google-Smtp-Source: ABdhPJxes31piN6jfRWmnXHjLnMTpXd9qhuLm8/R6l/l97UY+IrDsl3l0GSJaEha+RmRurqJ2sTUBA== X-Received: by 2002:a5d:64ac:: with SMTP id m12mr2329165wrp.659.1640183283376; Wed, 22 Dec 2021 06:28:03 -0800 (PST) Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id o8sm2525548wry.20.2021.12.22.06.28.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Dec 2021 06:28:03 -0800 (PST) From: zimoun In-Reply-To: <87a6gswyb4.fsf@yoctocell.xyz> References: <132d0f25d38be2a34abec3c43e4d685cdd0abe65.1640163645.git.public@yoctocell.xyz> <62f7af317db40e543c8e329ccf86849cda08eca4.camel@ist.tugraz.at> <87a6gswyb4.fsf@yoctocell.xyz> Date: Wed, 22 Dec 2021 15:23:54 +0100 Message-ID: <867dbwsop1.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1640183351; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=4vn3aO5mTGnI3Egx83ZUOMPUG4KRXXb+xZzpG/9L1x0=; b=jtFKoxWdNL9CiubjgqVsOOTKWwzcvY40BoZEdoE4IdG9o3ju7I1gkcpwl121XzrMaZa2cH jtVdFCdhCI1W5zUYvKvKc/CogJ6ZQ1fA6WYuV5LKiwTXngzEwjJ4jxGToY97+vVf6bJASO 1UmhUIgv9tDp0rcG3DpJcYuJtUlnnoI8EMvDt5YUioB8BxL/yLlNI6Cn6vAqjJL61D1eVC tG7a/1oxKZn9ZTFhllJasY3n05PNH682k/WkBkUoLUgJEYwgg8zpP12ChKGOUt0et8HL+a Ku6SHUe22JwGJ/AXHMr8AkUZfrYrcJPSO0Ix/HJR8TIoB6MVhtBi0r6EQkgFzA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1640183351; a=rsa-sha256; cv=none; b=S/mAbShbd8DERhGVn9f2Mmcf72+sGG4DN02EZxzuBX5u8X4ZqwZkLqlI72uWIiEGgOIgR/ q8AoTSV5fGZnZ4ZBfKdeujuWwc6oZVSSSayWCU9SDnGorLILZ22kI0FxpD1NdUDu/z6Z1c aNjhbMnOHuKj8e64OMwHQ3jAgH8jzIiJ/D7BfWaL3RrwqsgKOXo/sr5JltdknTV++Nu4OW yHxrc4rESmr9PNpIGpgwCSwAmH258tt4SNa9/fudovAUCkx/5HFEAFdR1yQ6Iwp93DV7YG iOiblp34NhahbtHmNnhvye4gzu8HVhRtCny84mG+LuYOskjJQRK7LculzPtV1w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=H05TOhe0; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.44 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=H05TOhe0; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 953271CFD8 X-Spam-Score: -2.44 X-Migadu-Scanner: scn0.migadu.com X-TUID: C/ZgkhM4JzVw Hi, Your patch is an improvement considering this old discussion [1]. 1: On Wed, 22 Dec 2021 at 14:42, Xinglu Chen wrote: > Which =E2=80=98svn-fetch=E2=80=99 are you referring to (there are two AFA= ICS)? The > Texlive importer uses =E2=80=98download-multi-svn-to-store=E2=80=99, whic= h itself uses > =E2=80=98svn-fetch=E2=80=99 from (guix build svn), but it requires the = =E2=80=98svn=E2=80=99 program to > be in PATH. > > There is another =E2=80=98svn-fetch=E2=80=99 procedure, in (guix svn-down= load), but that > one returns a fixed-output derivation, so it can only be used if we > already know the hash (which we don=E2=80=99t, that=E2=80=99s why we are = fetching the > SVN repo). The one in (guix svn-download) uses under the hood (guix build svn), if I read correctly: --8<---------------cut here---------------start------------->8--- #~(begin (use-modules (guix build svn)) (svn-fetch '#$(svn-reference-url ref) '#$(svn-reference-revision ref) #$output #:svn-command (string-append #+svn "/bin/svn") #:recursive? #$(svn-reference-recursive? ref) #:user-name #$(svn-reference-user-name ref) #:password #$(svn-reference-password ref))))) --8<---------------cut here---------------end--------------->8--- Anyway. :-) > Importers that fetch a Git repo don=E2=80=99t need =E2=80=98git=E2=80=99 = to be in PATH since > they use the Guile-Git bindings to libgit2. But we don=E2=80=99t have Gu= ile > bindings to SVN (or Hg, CVS, Bzr), so the program has to be installed on > the host system. I think it is not related how the call is done, here (invoke =E2=80=9Csvn= =E2=80=9D =E2=80=9Cexport=E2=80=9D =E2=80=A6) and not (libsvn-export =E2=80=A6). In the snippet above, #+svn is transparently picked from the current subversion package. Maybe the bit --8<---------------cut here---------------start------------->8--- (define (subversion-package) "Return the default Subversion package." (let ((distro (resolve-interface '(gnu packages version-control)))) (module-ref distro 'subversion))) --8<---------------cut here---------------end--------------->8--- could go to =E2=80=99(guix build svn)=E2=80=99, used overthere instead of = =E2=80=9C#:key (svn-command "svn")=E2=80=9D; and maybe exported if needed. WDYT? 1: Cheers, simon