From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34254)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d1UT7-0007Zx-9T
	for guix-patches@gnu.org; Fri, 21 Apr 2017 05:03:10 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d1UT1-000584-Ir
	for guix-patches@gnu.org; Fri, 21 Apr 2017 05:03:09 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:33329)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1d1UT1-00057z-Fi
	for guix-patches@gnu.org; Fri, 21 Apr 2017 05:03:03 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d1UT1-0003Fo-80
	for guix-patches@gnu.org; Fri, 21 Apr 2017 05:03:03 -0400
Subject: bug#26544: [PATCH v2 6/8] system: vm: Use
	operating-system-kernel-arguments.
Resent-Message-ID: <handler.26544.B26544.149276534512437@debbugs.gnu.org>
References: <20170421022127.20524-1-dannym@scratchpost.org>
	<20170421022127.20524-7-dannym@scratchpost.org>
From: Mathieu Othacehe <m.othacehe@gmail.com>
In-reply-to: <20170421022127.20524-7-dannym@scratchpost.org>
Date: Fri, 21 Apr 2017 11:02:37 +0200
Message-ID: <8660hykuaa.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 26544@debbugs.gnu.org


LGTM!

Danny Milosavljevic writes:

> * gnu/system/vm.scm (system-qemu-image/shared-store-script):
> Use operating-system-kernel-arguments.
> ---
>  gnu/system/vm.scm | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/gnu/system/vm.scm b/gnu/system/vm.scm
> index 4f915c4f9..2c8b954c8 100644
> --- a/gnu/system/vm.scm
> +++ b/gnu/system/vm.scm
> @@ -490,11 +490,8 @@ it is mostly useful when FULL-BOOT?  is true."
>                                  #:full-boot? full-boot?
>                                  #:disk-image-size disk-image-size)))
>      (define kernel-arguments
> -      #~(list "--root=/dev/vda1"
> -              (string-append "--system=" #$os-drv)
> -              (string-append "--load=" #$os-drv "/boot")
> -              #$@(if graphic? #~() #~("console=ttyS0"))
> -              #+@(operating-system-user-kernel-arguments os)))
> +      #~(list #$@(if graphic? #~() #~("console=ttyS0"))
> +              #+@(operating-system-kernel-arguments os os-drv "/dev/vda1")))
>  
>      (define qemu-exec
>        #~(list (string-append #$qemu "/bin/" #$(qemu-command (%current-system)))