From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39502)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dIbUJ-0003Xo-At
	for guix-patches@gnu.org; Wed, 07 Jun 2017 09:59:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dIbUG-0005tw-7R
	for guix-patches@gnu.org; Wed, 07 Jun 2017 09:59:07 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:58891)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1dIbUG-0005tr-3k
	for guix-patches@gnu.org; Wed, 07 Jun 2017 09:59:04 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dIbUE-0004VD-Fr
	for guix-patches@gnu.org; Wed, 07 Jun 2017 09:59:02 -0400
Subject: bug#27275: [PATCH 1/2] pull: Add a dependency to guile-git.
Resent-Message-ID: <handler.27275.B27275.149684393917294@debbugs.gnu.org>
References: <20170607120405.7156-1-m.othacehe@gmail.com>
	<20170607120553.7382-1-m.othacehe@gmail.com> <87r2yw56q4.fsf@gnu.org>
From: Mathieu Othacehe <m.othacehe@gmail.com>
In-reply-to: <87r2yw56q4.fsf@gnu.org>
Date: Wed, 07 Jun 2017 15:58:56 +0200
Message-ID: <8660g7kifz.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: 27275@debbugs.gnu.org


Hi Ludo,

Thanks for the fast review :)

>>            (set! %load-compiled-path
>>              (cons* json
>> +                   (string-append #$guile-git "/lib/guile/"
>> +                                  #$(effective-version)-
>> +                                  "/site-ccache")
>
> ‘guile-git’ can be #f so you have to account for that.

Just on question about that. The easier I come up with is something like
:
 
--8<---------------cut here---------------start------------->8---
(set! %load-path
      (append
       `(,@(if
               (and #$guile-git #$guile-bytestructures)
               (list
                (string-append #$guile-git "/share/guile/site/"
                               #$(effective-version))
                (string-append #$guile-bytestructures "/share/guile/site/"
                               #$(effective-version)))
             '()))
       (cons* json
              (string-append #$guile-ssh "/share/guile/site/"
                             #$(effective-version))
              %load-path)))
--8<---------------cut here---------------end--------------->8---

Any idea on how to write that smoothly ?

Thanks,

Mathieu