unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Mathieu Othacehe <m.othacehe@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 27275@debbugs.gnu.org
Subject: bug#27275: [PATCH 1/2] pull: Add a dependency to guile-git.
Date: Wed, 07 Jun 2017 15:58:56 +0200	[thread overview]
Message-ID: <8660g7kifz.fsf@gmail.com> (raw)
In-Reply-To: <87r2yw56q4.fsf@gnu.org>


Hi Ludo,

Thanks for the fast review :)

>>            (set! %load-compiled-path
>>              (cons* json
>> +                   (string-append #$guile-git "/lib/guile/"
>> +                                  #$(effective-version)-
>> +                                  "/site-ccache")
>
> ‘guile-git’ can be #f so you have to account for that.

Just on question about that. The easier I come up with is something like
:
 
--8<---------------cut here---------------start------------->8---
(set! %load-path
      (append
       `(,@(if
               (and #$guile-git #$guile-bytestructures)
               (list
                (string-append #$guile-git "/share/guile/site/"
                               #$(effective-version))
                (string-append #$guile-bytestructures "/share/guile/site/"
                               #$(effective-version)))
             '()))
       (cons* json
              (string-append #$guile-ssh "/share/guile/site/"
                             #$(effective-version))
              %load-path)))
--8<---------------cut here---------------end--------------->8---

Any idea on how to write that smoothly ?

Thanks,

Mathieu

  reply	other threads:[~2017-06-07 13:59 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-07 12:04 bug#27275: [PATCH 0/2] Add (guix git) module Mathieu Othacehe
2017-06-07 12:05 ` bug#27275: [PATCH 1/2] pull: Add a dependency to guile-git Mathieu Othacehe
2017-06-07 12:05   ` bug#27275: [PATCH 2/2] guix: git: Add new module Mathieu Othacehe
2017-06-07 12:21     ` Ludovic Courtès
2017-06-07 12:21   ` bug#27275: [PATCH 1/2] pull: Add a dependency to guile-git Ludovic Courtès
2017-06-07 13:58     ` Mathieu Othacehe [this message]
2017-06-08 12:06       ` Ludovic Courtès
2017-06-08 14:49         ` Mathieu Othacehe
2017-06-08 20:52           ` Ludovic Courtès
2017-06-09  7:51             ` Mathieu Othacehe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8660g7kifz.fsf@gmail.com \
    --to=m.othacehe@gmail.com \
    --cc=27275@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).