Andreas Enge <andreas@enge.fr> writes:

> Hello,
>
> On Sat, Oct 10, 2020 at 03:52:17PM +0200, Malte Frank Gerdes wrote:
>> Subject: [PATCH 2/7] gnu: Add perl-alien-wxwidgets.
>
> during build, I see the following messages:
> starting phase `build'
> Building Alien-wxWidgets
> 'media' library not found: some functionality will be missing
>
> Does this matter? Should we add more inputs?

I checked that and (i'm also not a perl user, in fact i have never read
as much perl as in those packages in order to get slic3r :D) i can't
see any reason why it shouldn't find that library. It /is/ there. It's
part of wxwidgets. So i don't know what is going on there :/

> Then this:
> starting phase `check'
> t/01_load.t .......... ok
> t/zy_pod_coverage.t .. skipped: Test::Pod::Coverage 1.00 required for testing
> POD coverage
> t/zz_pod.t ........... skipped: Test::Pod 1.00 required for testing POD
>
> Similarly, add (native-)inputs?

As Tobias said, it might be perfectly fine to ignore these. I added the
relevant bits nonetheless, because it might be of help sometimes (or not
:D).

> Concerning these, I ran this command:
> $ guix gc --references
> /gnu/store/r8lbv88cg2nqkk0a2hjcvrs0z3ljqrcy-perl-alien-wxwidgets-0.69
> /gnu/store/a41jn9pcrgpkgba6vpd3m56r0fsczsv2-wxwidgets-gtk2-3.0.5.1
> /gnu/store/r8lbv88cg2nqkk0a2hjcvrs0z3ljqrcy-perl-alien-wxwidgets-0.69
>
> So wxwidgets-gtk2 should be a normal, non-native input.
> Why -gtk2? Does this warrant a comment?

i don't know why i chose wxwidgets-gtk2 - it works perfectly fine with
wxwidgets, sorry!

> I would suggest insignificantly beefed up descriptive fields:
>     (synopsis "Module for building, finding and using wxWidgets binaries")
>     (description "Alien::wxWidgets can be used to detect and get configuration
> settings from an installed wxWidgets package.")

I have modified the patch according to your suggestions.


Malte