From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id aDbSBy7e62BsiwAAgWs5BA (envelope-from ) for ; Mon, 12 Jul 2021 08:16:14 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id IPOOAy7e62B4JQAA1q6Kng (envelope-from ) for ; Mon, 12 Jul 2021 06:16:14 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 946C83AC96 for ; Mon, 12 Jul 2021 08:16:13 +0200 (CEST) Received: from localhost ([::1]:51760 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m2pEi-0004MF-J5 for larch@yhetil.org; Mon, 12 Jul 2021 02:16:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53012) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m2pEZ-0004K3-3c for guix-patches@gnu.org; Mon, 12 Jul 2021 02:16:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:53046) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m2pEY-0005s1-MA for guix-patches@gnu.org; Mon, 12 Jul 2021 02:16:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m2pEY-0004en-Bz for guix-patches@gnu.org; Mon, 12 Jul 2021 02:16:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49169] [PATCH 00/11] Removing input labels from package definitions Resent-From: Sarah Morgensen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 12 Jul 2021 06:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49169 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 49169@debbugs.gnu.org Received: via spool by 49169-submit@debbugs.gnu.org id=B49169.162607052017851 (code B ref 49169); Mon, 12 Jul 2021 06:16:02 +0000 Received: (at 49169) by debbugs.gnu.org; 12 Jul 2021 06:15:20 +0000 Received: from localhost ([127.0.0.1]:36359 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m2pDr-0004dq-Ti for submit@debbugs.gnu.org; Mon, 12 Jul 2021 02:15:20 -0400 Received: from out1.migadu.com ([91.121.223.63]:34514) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m2pDl-0004dc-Kp for 49169@debbugs.gnu.org; Mon, 12 Jul 2021 02:15:17 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1626070510; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OCMpdSwm9bMHnMFcLMlMISLLHCldruI9oJE/MyLlWxU=; b=TYBu27a6ykSGYeO2UbG5Az3c8WxqJvhNlI0axHdeW+JKUebF3GAAl0pA9Yo22xt/saNMiy WNtpvlWtgcOOE4I0EwYICht8PuTMOPj88FA+SFPxQaNGvpabu+0tWRbH53YyEvlNWhrgk6 ZwmDLdhniNXebNr5+kxx6q11f3sBKeY= References: <20210622090221.15182-1-ludo@gnu.org> <20210630204832.25753-1-ludo@gnu.org> <868s2ekbw5.fsf_-_@mgsn.dev> <87pmvpahgq.fsf_-_@gnu.org> Date: Sun, 11 Jul 2021 23:15:07 -0700 In-Reply-To: <87pmvpahgq.fsf_-_@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Sun, 11 Jul 2021 01:15:33 +0200") Message-ID: <865yxgjbx0.fsf_-_@mgsn.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Migadu-Auth-User: iskarian@mgsn.dev X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: Sarah Morgensen X-ACL-Warn: , Sarah Morgensen via Guix-patches From: Sarah Morgensen via Guix-patches via X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1626070573; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=OCMpdSwm9bMHnMFcLMlMISLLHCldruI9oJE/MyLlWxU=; b=MW9giijF4B/c1nFOWE+0uif6CHf6auEVh3wtUt1fhRKFrVNQoz7ukmzwn7Yy4hcleiA/B/ 3oA54z5+RuCCruYgSePbfgtwMfQjuwBl6VU4wgh1fBBYvyb6Z0jWZDUntRJeUkArdEvDOX 2Idw7viS5jUhXrytIaq3QL70tFvISU9JVRxn4kIys0Z6BmDXPe0fFT9hJixRy3GYiMx41F E+vYAxH7DnbvQGofVvq5qltYWQkUTUAeVXt/zvY6Ou3N/KxQAT+meBE42LR38H4b6CpYs4 tFSHgM2YyEkUo65dnsatN+bZ1W97S3FJcLgzpzSTBbI9RISHBub5AsYwpgB1MA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1626070573; a=rsa-sha256; cv=none; b=Elk4T4PUwPbydO9xTMFyE+OqLkTVuDJsuUFnotlrkdo8nioPR0XbHMblwLcOYsoFNKX9/v zLDrNJ4t8vNBX/VeYCCr57trL1V4yNmNx5vGo4Q+LDA8DlpCuhXB9Qlro8ncC4BCcABlDX aiU4Vfm1tMbIpG5B21pwrkSd1V6N3xYGoI6YVdnSyVI0it8umxiObFbkuU+fm639juy853 cB6NClZhEhoGopCR8atSGzC5vOk7HH7j3nu/ZMlrvGcj8Lrhl6Tou6FTYlvT/GvTRUPnl0 zIp+QvhvM/WyvduxwzbF/em5Mn2BX6ZCou2RSKxcRJiYsMGBNpFzPRCSfgNFgg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=mgsn.dev header.s=key1 header.b=TYBu27a6; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.90 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=mgsn.dev header.s=key1 header.b=TYBu27a6; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 946C83AC96 X-Spam-Score: -2.90 X-Migadu-Scanner: scn1.migadu.com X-TUID: cFao41jv/ThK Hi! Ludovic Court=C3=A8s writes: > On closer inspection, it seems that this change would affect the Crate > importer. Unfortunately, Crate packages live in their own world and are > unaffected by package input simplification. Well, that was an interesting code dive :) They really do live in their own world... > > This is unfortunate, also because they probably never even use input > labels that can be seen in #:cargo-development-inputs and the likes. > > That said, it would be good to simplify that too, and I=E2=80=99m open to > suggestions on how to achieve that! I have submitted a patchset [0] which just has the crate importer use the same sanitizer as package inputs, which should be good enough until we get rid of input labels in the internals. In the longer term, perhaps we would benefit from some way of indicating inputs which are just source? Something like (package ... (source-inputs ...)) where the listed packages only provide their source instead of any outputs, and only transitively include other packages via source-inputs. This would bypass any patching done in phases, but I don't think that's common enough in these "source" packages that it would be onerous to use origin patches/snippets instead. This would be useful for any build system which does not (re)use artifacts from a package's dependencies (such as cargo and go). [0] https://issues.guix.gnu.org/49531 -- Sarah