From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id wEVEH1R+LmFxLAAAgWs5BA (envelope-from ) for ; Tue, 31 Aug 2021 21:09:08 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id SAHEGlR+LmFPRQAAB5/wlQ (envelope-from ) for ; Tue, 31 Aug 2021 19:09:08 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4474C279CA for ; Tue, 31 Aug 2021 21:09:08 +0200 (CEST) Received: from localhost ([::1]:54398 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mL987-0000hQ-AF for larch@yhetil.org; Tue, 31 Aug 2021 15:09:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44746) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mL982-0000h1-1R for guix-patches@gnu.org; Tue, 31 Aug 2021 15:09:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:52095) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mL981-0005r2-Q4 for guix-patches@gnu.org; Tue, 31 Aug 2021 15:09:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mL981-0002po-JW for guix-patches@gnu.org; Tue, 31 Aug 2021 15:09:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50274] [PATCH] guix: git: Adds feature to download git repository to the store. References: <20210830163918.19419-1-jgart@dismail.de> Resent-From: Sarah Morgensen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 31 Aug 2021 19:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50274 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: jgart Cc: Julien Lepiller , 50274@debbugs.gnu.org Received: via spool by 50274-submit@debbugs.gnu.org id=B50274.163043691110849 (code B ref 50274); Tue, 31 Aug 2021 19:09:01 +0000 Received: (at 50274) by debbugs.gnu.org; 31 Aug 2021 19:08:31 +0000 Received: from localhost ([127.0.0.1]:35408 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mL97X-0002ov-Ls for submit@debbugs.gnu.org; Tue, 31 Aug 2021 15:08:31 -0400 Received: from out0.migadu.com ([94.23.1.103]:31558) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mL97V-0002om-4l for 50274@debbugs.gnu.org; Tue, 31 Aug 2021 15:08:30 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1630436907; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to; bh=d32OmA4UkyArP7IF3Hd2lFyszFUKUTG0Yw+OkPMxNsM=; b=MF2/1WhAcvEjxm1c0fRLs6bQP+iQCPfrAILeoRg8YJdERHf/7ldhX/sBPJI/0cBtS4U75b fEiHrxqi/1bsNjVq57OBxj67XtnOsog5D5lTKzXtwG4mq6/6gUGCwvJFGQqMAta4ztk6TN AjRPH0zSiKnQnZp6xruY0Gl9bxSL7fg= From: Sarah Morgensen Date: Tue, 31 Aug 2021 12:08:25 -0700 In-Reply-To: Sarah Morgensen's message of "Tue, 31 Aug 2021 11:50:48 -0700 (15 minutes, 42 seconds ago)" Message-ID: <865yvl1lg6.fsf@mgsn.dev> MIME-Version: 1.0 Content-Type: text/plain X-Migadu-Auth-User: iskarian@mgsn.dev X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1630436948; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=d32OmA4UkyArP7IF3Hd2lFyszFUKUTG0Yw+OkPMxNsM=; b=X1JnY55THm6Vr5J7RPs5eyUlZgFj5TJz5JhMdVsBdCmLGQOc5j3ijneM7QMSfV45czR785 IDZCmpL95cZ2LX4HoU09NgtzvULm/fn/wSoctvYBpWzwiZxBTw0A4vpD8RSJXkk+3fVvnz DNfihx4inQTIsfPMb2FCwXujdVM4HTXv8mzoxObJ9tRkU7t+bx3Idbs/R9IULsfcdjh4Vd qu3S9VDR0RaIyGar91Vc74k2tdrVLGAv+/EdYdPY03LsBzsb3nt8ZyS5nhrSIUgB7mTXaS yn/kacr9TgoWOs5j3mt05rHmG2CXZ7XuHbWqXxzgrJNpG3tfdjFYEpS8Cj5IMQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1630436948; a=rsa-sha256; cv=none; b=BnVqZah82jBVyxdmNqbUjIo25vDvMcJepJlQUKF1/OEavb/byjCi/f0qMsRMXT5IV0Heo0 WZwnaer86FhqXlKJ41OoAv7uEIcT0PKmYtsvyAZ3fGGCSZSle/XuHCJbx3nX/4YFBkY96p /PJ6gj1yksVq8J5RYaxO2cKJvdX+zZnnfq5dMSuFs3dry2JlOnykILKYWT3Ht0yQFEA+3M RxH8+leQ2O/KNGfahO23NFS8wpC3/eRcd+EMtn1oEVpL5gm/f111nD2kdiCZX0eLMxzLY4 DnPg0yD5ZSPrz1xmsCdVO2axaAnu9s4Vj3Q6b56HQ9sX9eGlBh6fXK0px+1sOA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=mgsn.dev header.s=key1 header.b="MF2/1WhA"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=mgsn.dev (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: 0.18 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=mgsn.dev header.s=key1 header.b="MF2/1WhA"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=mgsn.dev (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 4474C279CA X-Spam-Score: 0.18 X-Migadu-Scanner: scn0.migadu.com X-TUID: bJWv6HfSVn/v Hi again, Sarah Morgensen writes: >> (fetch (assq-ref opts 'download-proc)) >> + (git-fetch (assq-ref opts 'git-download-proc)) >> + (commit (assq-ref opts 'commit)) >> (path (parameterize ((current-terminal-columns >> (terminal-columns))) >> - (fetch (uri->string uri) >> - #:verify-certificate? >> - (assq-ref opts 'verify-certificate?)))) >> - (hash (call-with-input-file >> - (or path >> - (leave (G_ "~a: download failed~%") >> - arg)) >> - (cute port-hash (assoc-ref opts 'hash-algorithm) <>))) >> + (if commit >> + (git-fetch (uri->string uri) commit) > > You don't actually seem to use the download-git-to-store procedure you > wrote above. An oversight? Please disregard this comment. I read too fast and didn't catch that git-fetch took the value of 'git-download-proc :) -- Sarah