From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id yGgsDAtkiGLFRQAAbAwnHQ (envelope-from ) for ; Sat, 21 May 2022 06:01:15 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id UNRNCwtkiGIusAAAG6o9tA (envelope-from ) for ; Sat, 21 May 2022 06:01:15 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B626A14853 for ; Sat, 21 May 2022 06:01:13 +0200 (CEST) Received: from localhost ([::1]:54416 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nsGIi-0003o8-AP for larch@yhetil.org; Sat, 21 May 2022 00:01:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55898) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nsGIY-0003nn-An for guix-patches@gnu.org; Sat, 21 May 2022 00:01:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:46566) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nsGIY-0001xz-2D for guix-patches@gnu.org; Sat, 21 May 2022 00:01:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nsGIX-0000Sj-RL for guix-patches@gnu.org; Sat, 21 May 2022 00:01:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55517] [PATCH]: gnu: emacs-magit: Drop the libgit backend. Resent-From: Zhu Zihao Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 21 May 2022 04:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55517 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: 55517@debbugs.gnu.org Received: via spool by 55517-submit@debbugs.gnu.org id=B55517.16531056541750 (code B ref 55517); Sat, 21 May 2022 04:01:01 +0000 Received: (at 55517) by debbugs.gnu.org; 21 May 2022 04:00:54 +0000 Received: from localhost ([127.0.0.1]:40460 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nsGIP-0000S5-IY for submit@debbugs.gnu.org; Sat, 21 May 2022 00:00:54 -0400 Received: from mail-m972.mail.163.com ([123.126.97.2]:63593) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nsGIJ-0000Rd-4L for 55517@debbugs.gnu.org; Sat, 21 May 2022 00:00:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-ID:MIME-Version; bh=BHHZ0 akO4FFvZX8VJXdstofCBndVQGZZzxNDG6r+xrA=; b=GPIQZGrLyCoFDy0Ewickp wIIRKlcrSuCqhOcZb58wysA1gcbx6caA0AJrBrtUat/22yjd2o45Plxo/GcUCK1X 4lwoTF7bBreyMIYZif/V/KM6Tk7zN3IO90rNJzn92D+lxsaW1F5daXGjJ3n4evcs cKdGTPeBUI9v5FaPtbdvpQ= Received: from asus-laptop (unknown [27.38.118.8]) by smtp2 (Coremail) with SMTP id GtxpCgDH8M3fY4hisMEtDw--.13590S2; Sat, 21 May 2022 12:00:32 +0800 (CST) References: <868rqykt19.fsf@163.com> <86sfp6je99.fsf@163.com> <87tu9jbpkj.fsf_-_@gmail.com> User-agent: mu4e 1.6.10; emacs 27.2 From: Zhu Zihao Date: Sat, 21 May 2022 11:45:46 +0800 In-reply-to: <87tu9jbpkj.fsf_-_@gmail.com> Message-ID: <865ylzy1pr.fsf@163.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-CM-TRANSID: GtxpCgDH8M3fY4hisMEtDw--.13590S2 X-Coremail-Antispam: 1Uf129KBjvJXoW7ur4rGr4kCrWruFyxKw45KFg_yoW8trWfpF WrW3yjkr18Xr10vwnrGF4Svr10ya1rtry3t3WrurWrAa1DWwnaq34qkrs8Wa4UGr97Kayj qw4j9w1qgF15ZaDanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0zR53k_UUUUU= X-Originating-IP: [27.38.118.8] X-CM-SenderInfo: pdoosuxxwbztlvw6il2tof0z/xtbBawAIr1et45O60QAAst X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1653105674; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=BHHZ0akO4FFvZX8VJXdstofCBndVQGZZzxNDG6r+xrA=; b=mO0Grc6OL1bGXjcqmvUlDHc4WSR7Fv6HI0ulWZz/v/e1mBm3HI8Ni+NLGDQ6XEhpAQfFyf yULnV+V6pWQ+MoNAkjzkj9y/OVvuky6ZDJJLtTN2rFsNkhfkZiKJQCKOaAC+xf2eFb/tLQ crWQIlHaloYMlUwZLHtRHWsn39Pzbm2JWe2W0puOZ1msyIZ7+x7jR3V1kreL25jv7VNjzT iT5uuDOt3zjLMW3lfwz3RclDew7ql4iB4VhEGFEhKgj+LOENQrx8DD3nFhpYREjQOfgo8+ E7SEJP2uN3wChfa5qrjSNYzAuubz1SOfkJ2RnX/Cem1mgs9MbDept5IQn8dlZA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1653105674; a=rsa-sha256; cv=none; b=U+5rknyQeMN7Ia1Q2PachhbST+8+MA4UooAkXX0LOPv+7IjtOSiZKfWkhle5t7nEG5WN+X xVbcnhoEb8RrV5UEs48QxKpVZ1EfirsdfVt3aSrgM5BSZun4yvrf/IJy4+WLRIAHtq1y53 mexuqZ4xNZYvu7vjjM50+eTzTAHTTRm304RLx75SGNaoyOvlFLF0zEknB9ZxDVSYSEL2Se SOzXM/g7/0wmUkHydcizYEvaV0RIGJ4Jo6ywdhGQenkPuBTwmLMugnQ6p5g57zkFEyph3g UnTxJNTL18ucqY2v7jkIe4DfuRG1DqqaXiCMaOZFmw/pmoqxywy4O3tV2rXKYA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=163.com header.s=s110527 header.b=GPIQZGrL; dmarc=fail reason="SPF not aligned (relaxed)" header.from=163.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 4.35 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=163.com header.s=s110527 header.b=GPIQZGrL; dmarc=fail reason="SPF not aligned (relaxed)" header.from=163.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: B626A14853 X-Spam-Score: 4.35 X-Migadu-Scanner: scn0.migadu.com X-TUID: YnNyl7OrK4hx --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Maxim Cournoyer writes: > Hi Zhu, > > Zhu Zihao writes: > >> Fix the typo in commit message >> >>>>From 8a2de5764a67bea1cbf789c8d6ce0ab0878ec40b Mon Sep 17 00:00:00 2001 >> From: Zhu Zihao >> Date: Thu, 19 May 2022 13:01:46 +0800 >> Subject: [PATCH] gnu: emacs-magit: Drop the libgit backend. >> >> Drop the libgit backend for following reasons: >> >> 1. The libgit backend of Magitis very incomplete. There's almost no bene= fits, >> but extra maintenance efforts. > > Could you elaborate about "almost no benefits"? Even if it's a small > benefit, if it makes it faster, I'd still keep it since Magit is at > times excruciatingly slow. It's slow? AFAIK magit user always complain that magit on Windows system is slow. The process creation on *nix is much cheaper than Windows, so Magit is not slow on *nix. I've elaborated the reason in https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D55427. The libgit backend of Magit is almost nothing, only one function is implemented. `magit-bare-repo-p` will be used in magit-toplevel which is called frequently in the magit source code. But this function is cached. You can still say it's faster, but it's fair to say the libgit backend doesn't worth the maintenance effort due to the inactive status of upstream. >> 2. The libgit backend of Magit can be considered as an extra package. An= d it's >> still in Proof-Of-Concept status so its quaility doesn't satisfy the >> requirement of Guix package. > > There's not really any "quality requirements" for Guix package; we > package stable releases when they're available; the rest is up to us > Guix users. If you really wants to keep the libgit backend. I'd suggest to make it a dedicated package. If emacs-libgit is broken (again), magit is still usable= .=20 > Do you happen to have a link to some exchange where Magit authors would > recommend against using the libgit library at this point in time to > speed up Magit? Otherwise, I'm not convinced. No, I've said above. The libgit backend is very very very imcomplete. > > Thanks, > > Maxim =2D-=20 Retrieve my PGP public key: gpg --recv-keys D47A9C8B2AE3905B563D9135BE42B352A9F6821F Zihao --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIsEARYIADMWIQRefA5qkqvnKdl/GTlmOX+E92aT+QUCYohj0BUcYWxsX2J1dF9s YXN0QDE2My5jb20ACgkQZjl/hPdmk/l1dwEA7Lx3vw5Qe6deTnxgi4+9s/laiwVF zcCuENu6uLilTfYBAOsENZP5vOTBfMcOzD/vJ45XDtDWBYSwl2gRETebu2EM =S2bE -----END PGP SIGNATURE----- --=-=-=--