From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id 2JOtJxGJaGcVawAAqHPOHw:P1 (envelope-from ) for ; Sun, 22 Dec 2024 21:48:01 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id 2JOtJxGJaGcVawAAqHPOHw (envelope-from ) for ; Sun, 22 Dec 2024 22:48:01 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=tiE1nYNq; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=XpM2Aow4; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1734904081; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=kZDYeCNmlA/OW9xSZCcYB7kJUW4h8Yu3eeFtoP+0s8M=; b=Dhl12OpqLybRP1xyu9/ISw6OWLeoJZpPgxzFByVEV4kstiCUgs1LON8aiSWeMb4b/u4mb1 MltV5ZXk0nOu2c7sYwnC9WmfANaBP+3Hjk/tVAhQbN/npDcpb4FYS1Vb+EHzqUjlMK9MOC MPvmt8H7UJp0WESLt320OyLbNQOhDuck1KCVZuIe/VvxSHi9cTc2jSwbIcfH/r7TMhiR9a NkGd7DScP5uF2xTuVRkHShiFUyFyuRUvrzHRy5AEVUsR+ZQdTmOi5TPXe4osbFZ/f7EV2x ADeyejVUkKSiIuivjTHsnx7vwwIaByA7RMIT8LT1CTOSdTbZIBBwM/5ztCJXgg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=tiE1nYNq; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=XpM2Aow4; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1734904081; a=rsa-sha256; cv=none; b=W95NE6SrkirkF1dkHo2ARH2Oc+oVd16veSMZdgXW9iycxIEgDAPRucWKwt/OfjyeZhAv1v +9YcbsCGdzapOMA2b4OMG7yrzIvSQtiQNuy0QTgVhO2lvW2a2mfLgdHcEAqL5/I3esz4EE fHyQGpKoSDSmvaOM6tC2EBRhHSKXFtpmNt/qZ7UIJdUBIuUQdfHdoPGQgqKgC6djCKd7cx Lumk9M4aFIN/yipXmronzw0nMKAemGH5000MSlHga1IoyGL1uXzOQw0I+TY5c062y76rtO Lr7nRzFkurz+DmpsCPTXgpmQm99bdZfO1JvNgTkd6TV+Q4dVUemzEP6gHZz+Ng== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 42F267AFE3 for ; Sun, 22 Dec 2024 22:48:01 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tPTni-0002Xn-5T; Sun, 22 Dec 2024 16:47:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tPTn0-0002QO-0s for guix-patches@gnu.org; Sun, 22 Dec 2024 16:47:07 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tPTmw-0002A3-9z for guix-patches@gnu.org; Sun, 22 Dec 2024 16:47:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:From:To:In-Reply-To:References:Subject; bh=kZDYeCNmlA/OW9xSZCcYB7kJUW4h8Yu3eeFtoP+0s8M=; b=tiE1nYNq4Gc92SxPzc65Ul2sIrYLDALCZ8eqEde75pKKWIvSTJWjP+EgZIfOp2qNG+Dc1ZgBFpcI8/twlWC3C8xmduG7CmUGq+sm9SvNst3UuQV2zueaVlQeoztT6c9u16kUNHw4PjnzHuKDJ5g4+I38p+ajGAXaJCV8y8RmHX2kHO6E9DdR95kNExvZci87yO+uY1F5Q8Yq35zevWe4dNA/z++lzeHC0uktH/avHEzQ1A1w4HqcqucKT9ZNe79BrA7FPXGEpsja/Mm2l8Ze2wc/ljaJ7wOQ5ZMaCDq4Q+Z1x+h9U+wcvlUgCqubkxOrMxKuiEWcxQbtWuefi1Ow8w==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tPTmw-0003Ko-3t for guix-patches@gnu.org; Sun, 22 Dec 2024 16:47:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#74505] [PATCH] Update freeciv to version 3.1.3 References: In-Reply-To: Resent-From: Rodion Goritskov Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 22 Dec 2024 21:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74505 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 74505@debbugs.gnu.org Received: via spool by 74505-submit@debbugs.gnu.org id=B74505.173490397912741 (code B ref 74505); Sun, 22 Dec 2024 21:47:02 +0000 Received: (at 74505) by debbugs.gnu.org; 22 Dec 2024 21:46:19 +0000 Received: from localhost ([127.0.0.1]:52241 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tPTmF-0003JQ-Ax for submit@debbugs.gnu.org; Sun, 22 Dec 2024 16:46:19 -0500 Received: from mail-wr1-f42.google.com ([209.85.221.42]:47425) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tPTmB-0003JH-SD for 74505@debbugs.gnu.org; Sun, 22 Dec 2024 16:46:17 -0500 Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-38634c35129so2735833f8f.3 for <74505@debbugs.gnu.org>; Sun, 22 Dec 2024 13:46:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734903915; x=1735508715; darn=debbugs.gnu.org; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=kZDYeCNmlA/OW9xSZCcYB7kJUW4h8Yu3eeFtoP+0s8M=; b=XpM2Aow4jwJtzNuEY4VFHZ+mUg0Jbk1yAY4gwH1xqY5hjwrxzr0F6fUD4S0Y5JTqfC GHFEaiZpajX5OCzCOPnO2iprhPBjKfwXGP8MF/PiwakDO/elQFCQfDEHeTsqU4Fd89Ie aSEdVzz7cIadvYFqXpOtpyGmoLlzcDjXp/KABk0WLVScMHmORSJkNS0ys7Y8Adq6qYAg WLXz809LbBbnC/wCQ3XIeWBb6yDxR+TxcGJRhl7ixfDb+DlA0hGO4jDEnrG5D9Pzkjhc +NqygccKVpnFksNpTsgHHkuWc+8JYt7UVCoz+F13qWx78LOxN8NE21rTMMYM0hlXTD9M yvRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734903915; x=1735508715; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=kZDYeCNmlA/OW9xSZCcYB7kJUW4h8Yu3eeFtoP+0s8M=; b=bNlxk12bCZUO57pIDhCWa7cGbXOaTmsn5uWRbk1z8YsJEQ0FeooWvaQJuRj+IWd209 5PbeOXnpVfH0l4pvPr8qMBmjiky3FQNM9Vodxs7gv3Upn76l2zTX+u3IQoyO5CuVMcBX Fg211CFNT45bD+QTFM9MlUKJ4SkBK/cjSH/xVG0g+rJvETm4XD9vN/tOpVFANF8TXHrh HmdsHEcji4Oj+nYCkxFwFqmSlCBm54Kid+6yyOPc2Rk5ICKqvOOgbCn13GId3YXqNWgN URahJt2/hSEvrirjKlihL/vUAfj87WIv4yGlFg1NEPUZph38JsqEcVO0P4z8tNRqCXke sYog== X-Gm-Message-State: AOJu0YxWH5SJ4GtfVsQAelEzxcuLZvlNUAVIq/8bCy6vSdwVM9xlWVjJ dUR5iPQ2+zWB6Cx0qIU+hRmuW5SgVyq4gmCyvtqkyqSM8nnoBvaPaO66zg== X-Gm-Gg: ASbGncsiPwI/zHDprU18enCN5DXPTm2RkKEi+lNSEm+lqtFKfCEze5dN/WaMgfhBjEf 6sk9iGipwz5GdxuyNRm5ti40l/2NvMv0Dp7HnPAn/MH8G1s0JjRQJGR7Y0jqJs9PoDojAcGS1/A Kf7cJJgMwRe1jI7/COl3X4SgGSAYuokIpzuYwxIDlOi3TdgPZN2dnWi6pLaXUqRwA3QU/DCOiDe yYkxyEBkO3xemsohFzcVrmTp33Chne0gkXSPGShz2gMfxPNj7bv4G0Ocr9WPFSctkl6v+j+A/bk YtRohXqj/+zIWj9QVKw+INcpx9zqOA16/W4qgQX03Q== X-Google-Smtp-Source: AGHT+IHMtMsEsbML9S/JS1GEEgY6c1bAmNXn00J9QVPjxwFB178LjWz+AVNAQgxSkzJRZ0niKcVTFQ== X-Received: by 2002:a5d:64ac:0:b0:385:effc:a279 with SMTP id ffacd0b85a97d-38a223ff46cmr8259964f8f.58.1734903914512; Sun, 22 Dec 2024 13:45:14 -0800 (PST) Received: from bumblebee-serious (port-92-193-175-166.dynamic.as20676.net. [92.193.175.166]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a1c89e2b0sm9932648f8f.82.2024.12.22.13.45.12 for <74505@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Dec 2024 13:45:13 -0800 (PST) From: Rodion Goritskov Date: Sun, 22 Dec 2024 22:45:08 +0100 Message-ID: <865xnbv1cr.fsf@bumblebee-serious.mail-host-address-is-not-set> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Queue-Id: 42F267AFE3 X-Migadu-Scanner: mx13.migadu.com X-Migadu-Spam-Score: -3.80 X-Spam-Score: -3.80 X-TUID: l6TIPOgwDlrE Hi Gustavo, Thank you for the updated patch - it works great now (not a big fan of freeciv, but at least game starts and sound works fine after selecting sdl in sound options). I don't have any comments about the changes in patch. But I noticed some things to improve in commit messages and patch naming. Looks like now it is not fully up to the Guix commit style practices. Lets take a look on some package update commit message example [1] Commit message first line should be in format: > gnu: : Update to And then in following lines specific changes should be described: > * gnu/packages/.scm (): Update to > [inputs]: For broad and detailed commit logs standards you could check GNU Coding Standards [2]. But examples are easier (: Also, please send an updated version of the patch with the next revision, so it would be easier for maintainers to distinct and apply it. To do this you could specify the revision 2 in git send-email. You could find some instructions in documentation [3] at the end of the Single Patches section. Also, you could take a look on the mumi CLI tool, it makes working with patches much easier [4]. Happy hacking! [1] - https://git.savannah.gnu.org/cgit/guix.git/commit/?id=af28be202cb2b7fd0fc2e277467304f81c78ab74 [2] - https://www.gnu.org/prep/standards/html_node/Change-Logs.html#Change-Logs [3] - https://guix.gnu.org/manual/devel/en/html_node/Sending-a-Patch-Series.html [4] - https://guix.gnu.org/manual/devel/en/html_node/Debbugs-User-Interfaces.html#Command_002dLine-Interface