From: Zhu Zihao <all_but_last@163.com>
To: Guillaume Le Vaillant <glv@posteo.net>
Cc: 45191@debbugs.gnu.org
Subject: [bug#45191] [PATCH] Improve reproducibility of package ECL
Date: Mon, 14 Dec 2020 19:21:01 +0800 [thread overview]
Message-ID: <864kko4orm.fsf@163.com> (raw)
In-Reply-To: <87o8ixdekm.fsf@yamatai>
[-- Attachment #1.1: Type: text/plain, Size: 890 bytes --]
Guillaume Le Vaillant writes:
> Zhu Zihao <all_but_last@163.com> skribis:
>
>> + (use-modules (ice-9 ftw))
>> + (let* ((lib (string-append (assoc-ref outputs "out") "/lib"))
>> + (dir (car (scandir lib (lambda (x)
>> + (string-prefix? "ecl-" x))))))
>> + (delete-file (string-append lib "/" dir "/build-stamp")))
>
> Wouldn't something like the following suffice?
>
> --8<---------------cut here---------------start------------->8---
> (delete-file (string-append (assoc-ref outputs "out")
> "/lib/ecl-" ,version "/build-stamp"))
> --8<---------------cut here---------------end--------------->8---
Changed and submit a new patch now.
Actually I hope upstream can help fix this problem[1](e.g. Add a configure
option --disable-time-stamp) but get no reply
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 255 bytes --]
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-ecl-Return-t-in-wrap-phase.patch --]
[-- Type: text/x-patch, Size: 1067 bytes --]
From cad4e253aefa52cacda5df37970dad6cc32e6600 Mon Sep 17 00:00:00 2001
From: Zhu Zihao <all_but_last@163.com>
Date: Sat, 12 Dec 2020 10:33:37 +0800
Subject: [PATCH 1/2] gnu: ecl: Return #t in wrap phase.
* gnu/packages/lisp.scm(ecl)[arguments]<phases>: In phase "wrap", return #t.
---
gnu/packages/lisp.scm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/gnu/packages/lisp.scm b/gnu/packages/lisp.scm
index 3d446290a7..4592724867 100644
--- a/gnu/packages/lisp.scm
+++ b/gnu/packages/lisp.scm
@@ -280,7 +280,8 @@ interface to the Tk widget system.")
(input-path lib "/include"))
`("kernel-headers" ,@libraries)))
`("LIBRARY_PATH" suffix ,library-directories)
- `("LD_LIBRARY_PATH" suffix ,library-directories)))))
+ `("LD_LIBRARY_PATH" suffix ,library-directories))
+ #t)))
(add-after 'wrap 'check (assoc-ref %standard-phases 'check))
(add-before 'check 'fix-path-to-ecl
(lambda _
--
2.29.2
[-- Attachment #3: 0002-gnu-ecl-Remove-build-stamp-to-improve-reproducibilit.patch --]
[-- Type: text/x-patch, Size: 1692 bytes --]
From 1554e044a3e2eede8bf4637395ca4da2388d8e9e Mon Sep 17 00:00:00 2001
From: Zhu Zihao <all_but_last@163.com>
Date: Sat, 12 Dec 2020 10:34:37 +0800
Subject: [PATCH 2/2] gnu: ecl: Remove build-stamp to improve reproducibility.
* gnu/packages/lisp.scm(ecl)[arguments]<phases>: Add "remove-build-stamp" phase.
Move "wrap" phase after "remove-build-stamp" phase.
---
gnu/packages/lisp.scm | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/gnu/packages/lisp.scm b/gnu/packages/lisp.scm
index 4592724867..f250e8804b 100644
--- a/gnu/packages/lisp.scm
+++ b/gnu/packages/lisp.scm
@@ -16,6 +16,7 @@
;;; Copyright © 2019 Jesse Gildersleve <jessejohngildersleve@protonmail.com>
;;; Copyright © 2019, 2020 Guillaume Le Vaillant <glv@posteo.net>
;;; Copyright © 2020 Marius Bakke <mbakke@fastmail.com>
+;;; Copyright © 2020 Zhu Zihao <all_but_last@163.com>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -258,7 +259,12 @@ interface to the Tk widget system.")
(contrib-asdf "contrib/asdf/asdf.lisp"))
(copy-file guix-asdf contrib-asdf))
#t))
- (add-after 'install 'wrap
+ (add-after 'install 'remove-build-stamp
+ (lambda* (#:key outputs #:allow-other-keys)
+ (delete-file (string-append (assoc-ref outputs "out")
+ "/lib/ecl-" ,version "/build-stamp"))
+ #t))
+ (add-after 'remove-build-stamp 'wrap
(lambda* (#:key inputs outputs #:allow-other-keys)
(let* ((ecl (assoc-ref outputs "out"))
(input-path (lambda (lib path)
--
2.29.2
[-- Attachment #4: Type: text/plain, Size: 165 bytes --]
[1]: https://gitlab.com/embeddable-common-lisp/ecl/-/issues/616
--
Retrieve my PGP public key:
gpg --recv-keys D47A9C8B2AE3905B563D9135BE42B352A9F6821F
Zihao
next prev parent reply other threads:[~2020-12-14 12:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-12 2:39 [bug#45191] [PATCH] Improve reproducibility of package ECL Zhu Zihao
2020-12-13 13:24 ` Guillaume Le Vaillant
2020-12-14 11:21 ` Zhu Zihao [this message]
2020-12-14 13:55 ` bug#45191: " Guillaume Le Vaillant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=864kko4orm.fsf@163.com \
--to=all_but_last@163.com \
--cc=45191@debbugs.gnu.org \
--cc=glv@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).