unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: zimoun <zimon.toutoune@gmail.com>
To: Efraim Flashner <efraim@flashner.co.il>
Cc: 52186-done@debbugs.gnu.org, maxim.cournoyer@gmail.com
Subject: [bug#52186] [core-updates-frozen PATCH v2 00/17] Fix Julia on i686-linux.
Date: Sat, 04 Dec 2021 19:27:45 +0100	[thread overview]
Message-ID: <864k7okyxq.fsf@gmail.com> (raw)
In-Reply-To: <YaurWWJZXx7C78jT@3900XT>

Hi Efraim,

Thanks!


On Sat, 04 Dec 2021 at 19:54, Efraim Flashner <efraim@flashner.co.il> wrote:

> I made a couple of changes, mostly to use target-x86-32? and
> target-64bit?. Patches pushed! Thanks.

I get 44 instances using ’string-prefix? “i686”’ vs 5 instance using
’target-x86-32’.  For my information, why is target-x86-32 preferred
here? 


--8<---------------cut here---------------start------------->8---
$ find . -name "*.scm" | xargs grep 'string-prefix' | grep i686 
./build-aux/compile-all.scm:    (if (string-prefix? "i686" %host-type)
./guix/utils.scm:      (string-prefix? "i686-" target)))
./gnu/build/bootloader.scm:                            ((string-prefix? "i686" system)
./gnu/packages/video.scm:     (if (string-prefix? "i686" (%current-system))
./gnu/packages/scheme.scm:                         (string-prefix? "i686" system))
./gnu/packages/scheme.scm:                       (string-prefix? "i686" system))
./gnu/packages/linux.scm:               (or (string-prefix? "i686-" system)
./gnu/packages/maths.scm:        ((string-prefix? "i686" system)
./gnu/packages/maths.scm:               (string-prefix? "i686" system)
./gnu/packages/maths.scm:                       (string-prefix? "i686" system))
./gnu/packages/maths.scm:                                  (string-prefix? "i686" system))
./gnu/packages/image.scm:                                    ((string-prefix? "i686" target)
./gnu/packages/tls.scm:                           ((string-prefix? "i686" target)
./gnu/packages/databases.scm:                      ,@(if (string-prefix? "i686" (%current-system))
./gnu/packages/music.scm:                         (string-prefix? "i686" system))
./gnu/packages/music.scm:                            (string-prefix? "i686" system)))
./gnu/packages/music.scm:                         (string-prefix? "i686" system))
./gnu/packages/gstreamer.scm:         ,@(if (string-prefix? "i686" (or (%current-target-system)
./gnu/packages/gl.scm:         ,@(if (string-prefix? "i686" (or (%current-target-system)
./gnu/packages/algebra.scm:              ((string-prefix? "i686" system)
./gnu/packages/python-xyz.scm:               (when (string-prefix? "i686" ,(%current-system))
./gnu/packages/machine-learning.scm:                                     ((string-prefix? "i686" system)
./gnu/packages/machine-learning.scm:                              (string-prefix? "i686" system)))
./gnu/packages/xorg.scm:     (filter (lambda (system) (string-prefix? "i686-" system))
./gnu/packages/xorg.scm:       (filter (lambda (system) (or (string-prefix? "i686-" system)
./gnu/packages/compression.scm:       ,@(if (string-prefix? "i686" (or (%current-target-system)
./gnu/packages/compression.scm:                        ((string-prefix? "i686" system)
./gnu/packages/compression.scm:                 ((string-prefix? "i686" system)
./gnu/packages/node.scm:                                        ((? (cut string-prefix? "i686" <>))
./gnu/packages/node.scm:                                         ((? (cut string-prefix? "i686" <>))
./gnu/packages/haskell-web.scm:       #:tests? ,(not (string-prefix? "i686" (or (%current-target-system)
./gnu/packages/package-management.scm:                                     (string-prefix? "i686" system)))
./gnu/packages/bioinformatics.scm:                      (string-prefix? "i686" system))
./gnu/packages/graph.scm:                                        ((string-prefix? "i686" system)
./gnu/packages/graph.scm:                                       ((string-prefix? "i686" system)
./gnu/packages/lean.scm:                   (not (or (string-prefix? "i686" arch)
./gnu/packages/virtualization.scm:                  ((? (cut string-prefix? "i686" <>))
./gnu/packages/virtualization.scm:   ((string-prefix? "i686" system)
./gnu/packages/virtualization.scm:                                   ((string-prefix? "i686" system)
./gnu/packages/password-utils.scm:                         (string-prefix? "i686" system)) "sse2")
./gnu/ci.scm:    (and (or (string-prefix? "i686-" system)
./gnu/system/install.scm:                                      (string-prefix? "i686" %host-type))))
./gnu/tests/install.scm:   ((string-prefix? "i686" system)
./gnu/tests/install.scm:                            ((string-prefix? "i686" #$system)
--8<---------------cut here---------------end--------------->8---

--8<---------------cut here---------------start------------->8---
$ find . -name "*.scm" | xargs grep 'target-x86-32'
./guix/utils.scm:            target-x86-32?
./guix/utils.scm:(define* (target-x86-32? #:optional (target (or (%current-target-system)
./tests/utils.scm:(test-equal "target-x86-32?"
./tests/utils.scm:  (map target-x86-32?
./gnu/packages/webkit.scm:             ,@(if (target-x86-32?)
--8<---------------cut here---------------end--------------->8---

Cheers,
simon




  reply	other threads:[~2021-12-04 18:34 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-29 18:21 [bug#52186] [core-updates-frozen] [PATCH] gnu: libunwind-julia: Fix build on i686-linux zimoun
2021-11-29 18:51 ` [bug#52186] [core-updates-frozen] Fix julia " zimoun
2021-12-01 15:52 ` [bug#52186] [core-updates-frozen PATCH v2 00/17] Fix Julia " zimoun
2021-12-04 17:54   ` bug#52186: " Efraim Flashner
2021-12-04 18:27     ` zimoun [this message]
2021-12-05  9:49       ` [bug#52186] " Efraim Flashner
2021-12-05 10:36         ` zimoun
2021-12-01 15:53 ` [bug#52186] [core-updates-frozen PATCH v2 01/17] gnu: libunwind-julia: Fix build " zimoun
2021-12-01 15:53   ` [bug#52186] [core-updates-frozen PATCH v2 02/17] gnu: julia-datastructures: Fix tests " zimoun
2021-12-01 15:53   ` [bug#52186] [core-updates-frozen PATCH v2 03/17] gnu: julia-benchmarktools: " zimoun
2021-12-01 15:53   ` [bug#52186] [core-updates-frozen PATCH v2 04/17] gnu: julia-finitedifferences: " zimoun
2021-12-01 15:53   ` [bug#52186] [core-updates-frozen PATCH v2 05/17] gnu: julia-configurations: " zimoun
2021-12-01 15:53   ` [bug#52186] [core-updates-frozen PATCH v2 06/17] gnu: julia-lazyarrays: " zimoun
2021-12-01 15:53   ` [bug#52186] [core-updates-frozen PATCH v2 07/17] gnu: julia-blockarrays: " zimoun
2021-12-01 15:53   ` [bug#52186] [core-updates-frozen PATCH v2 08/17] gnu: julia-mappedarrays: " zimoun
2021-12-01 15:53   ` [bug#52186] [core-updates-frozen PATCH v2 09/17] gnu: julia-arrayinterface: Disable tests for i686 zimoun
2021-12-01 15:54 ` [bug#52186] [core-updates-frozen PATCH v2 10/17] gnu: julia-interpolations: Disable tests in i686-linux zimoun
2021-12-01 15:54   ` [bug#52186] [core-updates-frozen PATCH v2 11/17] gnu: julia-reversediff: Disable tests on i686-linux zimoun
2021-12-01 15:54   ` [bug#52186] [core-updates-frozen PATCH v2 12/17] gnu: julia-intervalsets: Fix " zimoun
2021-12-01 15:54   ` [bug#52186] [core-updates-frozen PATCH v2 13/17] gnu: julia-woodburymatrices: " zimoun
2021-12-01 15:54   ` [bug#52186] [core-updates-frozen PATCH v2 14/17] gnu: julia-mutablearithmetics: " zimoun
2021-12-01 15:54   ` [bug#52186] [core-updates-frozen PATCH v2 15/17] gnu: julia-structarrays: " zimoun
2021-12-01 15:54   ` [bug#52186] [core-updates-frozen PATCH v2 16/17] gnu: julia-geometrybasics: " zimoun
2021-12-01 15:54   ` [bug#52186] [core-updates-frozen PATCH v2 17/17] gnu: julia-forwarddiff: Disable " zimoun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=864k7okyxq.fsf@gmail.com \
    --to=zimon.toutoune@gmail.com \
    --cc=52186-done@debbugs.gnu.org \
    --cc=efraim@flashner.co.il \
    --cc=maxim.cournoyer@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).